Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-937

Should use tajo.util.VersionInfo instead of TajoConstants.TAJO_VERSION

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:

      Description

      So far, we have used TajoConstants.TAJO_VERSION throughout the entire project. But, we adopted tajo.util.VersionInfo. It automatically generates version-info.properties in tajo-common-$

      {version}

      .jar. So, it always provides exact version. We should replace all of the usages of TajoConstants.TAJO_VERSION by tajo.util.VersionInfo.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user mhthanh opened a pull request:

        https://github.com/apache/tajo/pull/131

        TAJO-937: Should use tajo.util.VersionInfo instead of TajoConstants.TAJO_VERSION

        Replaced all of the usages of TajoConstants.TAJO_VERSION by tajo.util.VersionInfo.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/mhthanh/tajo TAJO-937

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/131.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #131


        commit bee568420afab67f004ff4f3cbf9d3d53d4e110e
        Author: mhthanh <maihaithanh@gmail.com>
        Date: 2014-09-03T08:42:22Z

        TAJO-937: Should use tajo.util.VersionInfo instead of
        TajoConstants.TAJO_VERSION

        commit 46a4c6609b50cbb07e4fae3e58706a4062bb0e44
        Author: mhthanh <maihaithanh@gmail.com>
        Date: 2014-09-03T08:46:18Z

        TAJO-937: Should use tajo.util.VersionInfo instead of
        TajoConstants.TAJO_VERSION

        commit b7dcb575e8b0b0cb7a0d25ecc1d0dde4063a45c8
        Author: mhthanh <maihaithanh@gmail.com>
        Date: 2014-09-03T08:46:18Z

        TAJO-937: Should use tajo.util.VersionInfo instead of
        TajoConstants.TAJO_VERSION

        commit 5bd4251895b8822b216ee32a2d671b2433a17fb6
        Author: mhthanh <maihaithanh@gmail.com>
        Date: 2014-09-03T08:49:16Z

        Merge branch 'TAJO-937' of https://github.com/mhthanh/tajo.git into TAJO-937


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user mhthanh opened a pull request: https://github.com/apache/tajo/pull/131 TAJO-937 : Should use tajo.util.VersionInfo instead of TajoConstants.TAJO_VERSION Replaced all of the usages of TajoConstants.TAJO_VERSION by tajo.util.VersionInfo. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mhthanh/tajo TAJO-937 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/131.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #131 commit bee568420afab67f004ff4f3cbf9d3d53d4e110e Author: mhthanh <maihaithanh@gmail.com> Date: 2014-09-03T08:42:22Z TAJO-937 : Should use tajo.util.VersionInfo instead of TajoConstants.TAJO_VERSION commit 46a4c6609b50cbb07e4fae3e58706a4062bb0e44 Author: mhthanh <maihaithanh@gmail.com> Date: 2014-09-03T08:46:18Z TAJO-937 : Should use tajo.util.VersionInfo instead of TajoConstants.TAJO_VERSION commit b7dcb575e8b0b0cb7a0d25ecc1d0dde4063a45c8 Author: mhthanh <maihaithanh@gmail.com> Date: 2014-09-03T08:46:18Z TAJO-937 : Should use tajo.util.VersionInfo instead of TajoConstants.TAJO_VERSION commit 5bd4251895b8822b216ee32a2d671b2433a17fb6 Author: mhthanh <maihaithanh@gmail.com> Date: 2014-09-03T08:49:16Z Merge branch ' TAJO-937 ' of https://github.com/mhthanh/tajo.git into TAJO-937
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/131#issuecomment-54412554

        +1
        The patch looks good to me.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/131#issuecomment-54412554 +1 The patch looks good to me.
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed. Thanks Mai!

        Show
        hyunsik Hyunsik Choi added a comment - committed. Thanks Mai!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/131

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/131
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #351 (See https://builds.apache.org/job/Tajo-master-build/351/)
        TAJO-937: Should use tajo.util.VersionInfo instead of TajoConstants.TAJO_VERSION. (Mai Hai Thanh via hyunsik) (hyunsik: rev bdc75750e9026a3c1bc0a9a7008505cb0bbedca4)

        • tajo-common/src/main/java/org/apache/tajo/TajoConstants.java
        • tajo-client/src/main/java/org/apache/tajo/cli/VersionCommand.java
        • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDatabaseMetaData.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #351 (See https://builds.apache.org/job/Tajo-master-build/351/ ) TAJO-937 : Should use tajo.util.VersionInfo instead of TajoConstants.TAJO_VERSION. (Mai Hai Thanh via hyunsik) (hyunsik: rev bdc75750e9026a3c1bc0a9a7008505cb0bbedca4) tajo-common/src/main/java/org/apache/tajo/TajoConstants.java tajo-client/src/main/java/org/apache/tajo/cli/VersionCommand.java tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDatabaseMetaData.java CHANGES tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java

          People

          • Assignee:
            mhthanh Mai Hai Thanh
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development