Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-913

Add some missed tests for constant value group-by keys

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: Planner/Optimizer
    • Labels:
      None

      Description

      This patch is trivial change. It adds two unit tests for constant key groupby as follows:

      select 123 as key, count(1) as total from lineitem group by key order by key, total;
      
      select l_partkey as a, timestamp '2014-07-07 04:28:31.561' as b, '##' as c, count(*) d from lineitem
      

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/60

        TAJO-913: Add some missed tests for constant value group-by keys.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-913

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/60.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #60


        commit 3f47df51d1868e59f2de2c6b29d5d38b2b5cb5f6
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2014-07-07T04:39:05Z

        TAJO-913: Add some missed tests for constant value group-by keys.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/60 TAJO-913 : Add some missed tests for constant value group-by keys. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-913 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/60.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #60 commit 3f47df51d1868e59f2de2c6b29d5d38b2b5cb5f6 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2014-07-07T04:39:05Z TAJO-913 : Add some missed tests for constant value group-by keys.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/60#issuecomment-48694067

        +1 for the patch

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/60#issuecomment-48694067 +1 for the patch
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed.

        Show
        hyunsik Hyunsik Choi added a comment - committed.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/60

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/60
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-build #284 (See https://builds.apache.org/job/Tajo-master-build/284/)
        TAJO-913: Add some missed tests for constant value group-by keys. (hyunsik: rev 52c8600dd59247b9be95f338ade4ea5aee2fba06)

        • CHANGES
        • tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithConstantKeys2.result
        • tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithConstantKeys1.result
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestGroupByQuery.java
        • tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithConstantKeys2.sql
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #284 (See https://builds.apache.org/job/Tajo-master-build/284/ ) TAJO-913 : Add some missed tests for constant value group-by keys. (hyunsik: rev 52c8600dd59247b9be95f338ade4ea5aee2fba06) CHANGES tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithConstantKeys2.result tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithConstantKeys1.result tajo-core/src/test/java/org/apache/tajo/engine/query/TestGroupByQuery.java tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithConstantKeys2.sql

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development