Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-909

{SortBased, Col}PartitionStoreExec should not write partition keys to files.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: Physical Operator
    • Labels:
      None

      Description

      See the title. Currently,

      {SortBased, Col}

      PartitionStoreExec write partition keys to files. So far, it seems to be work correctly because the physical schema of written tables omit partition key columns. But, the partitioned tables actually include partition key columns.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user babokim opened a pull request:

        https://github.com/apache/tajo/pull/64

        TAJO-909:

        {SortBased, Col}PartitionStoreExec should not write partition keys to files.



        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/babokim/tajo TAJO-909

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/64.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #64

        ----
        commit 1d7d3d687a48d43ee7f5976cff0efce786eeabca
        Author: 김형준 <babokim@babokim-mbp.server.gruter.com>
        Date: 2014-07-10T12:22:31Z

        TAJO-909: {SortBased, Col}

        PartitionStoreExec should not write partition keys to files.

        commit cec9182a5b50c2870c65daddb7454e9de4ab06d1
        Author: 김형준 <babokim@babokim-mbp.server.gruter.com>
        Date: 2014-07-10T12:41:46Z

        Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo

        Conflicts:
        tajo-core/src/test/java/org/apache/tajo/master/querymaster/TestQueryUnitStatusUpdate.java


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user babokim opened a pull request: https://github.com/apache/tajo/pull/64 TAJO-909 : {SortBased, Col}PartitionStoreExec should not write partition keys to files. You can merge this pull request into a Git repository by running: $ git pull https://github.com/babokim/tajo TAJO-909 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/64.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #64 ---- commit 1d7d3d687a48d43ee7f5976cff0efce786eeabca Author: 김형준 <babokim@babokim-mbp.server.gruter.com> Date: 2014-07-10T12:22:31Z TAJO-909 : {SortBased, Col} PartitionStoreExec should not write partition keys to files. commit cec9182a5b50c2870c65daddb7454e9de4ab06d1 Author: 김형준 <babokim@babokim-mbp.server.gruter.com> Date: 2014-07-10T12:41:46Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo Conflicts: tajo-core/src/test/java/org/apache/tajo/master/querymaster/TestQueryUnitStatusUpdate.java
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/64#issuecomment-48694544

        +1

        The patch looks good to me. I removed one unused method.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/64#issuecomment-48694544 +1 The patch looks good to me. I removed one unused method.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/64

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/64
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #283 (See https://builds.apache.org/job/Tajo-master-build/283/)
        TAJO-909:

        {SortBased, Col}

        PartitionStoreExec should not write partition keys to files. (Hyoungjun Kim via hyunsik) (hyunsik: rev 29db645ad02067464ed3e9b94b3e62d44ab2adf4)

        • tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ColPartitionStoreExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java
        • tajo-core/src/test/java/org/apache/tajo/master/querymaster/TestQueryUnitStatusUpdate.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #283 (See https://builds.apache.org/job/Tajo-master-build/283/ ) TAJO-909 : {SortBased, Col} PartitionStoreExec should not write partition keys to files. (Hyoungjun Kim via hyunsik) (hyunsik: rev 29db645ad02067464ed3e9b94b3e62d44ab2adf4) tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ColPartitionStoreExec.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java tajo-core/src/test/java/org/apache/tajo/master/querymaster/TestQueryUnitStatusUpdate.java CHANGES
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed.

        Show
        hyunsik Hyunsik Choi added a comment - committed.

          People

          • Assignee:
            hjkim Hyoungjun Kim
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development