Details

    • Type: Task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: SQL Parser
    • Labels:
      None

      Description

      We've founded that SQL is sufficient in this area, and many users satisfy with only SQL. I think that we don't need HiveQL compatibility feature anymore. Also, this elimination will reduce our code maintenance burden.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/46

        TAJO-887: Eliminate HiveQL support feature.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-887

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/46.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #46


        commit f81dbc744d1df4d6596ad908d6098192cfdd821d
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2014-06-24T08:31:42Z

        TAJO-887: Eliminate HiveQL support feature.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/46 TAJO-887 : Eliminate HiveQL support feature. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-887 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/46.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #46 commit f81dbc744d1df4d6596ad908d6098192cfdd821d Author: Hyunsik Choi <hyunsik@apache.org> Date: 2014-06-24T08:31:42Z TAJO-887 : Eliminate HiveQL support feature.
        Hide
        jihoonson Jihoon Son added a comment -

        Hi Hyunsik,
        if you have, would you share any data of HiveQL and SQL preference?

        Show
        jihoonson Jihoon Son added a comment - Hi Hyunsik, if you have, would you share any data of HiveQL and SQL preference?
        Hide
        hyunsik Hyunsik Choi added a comment -

        I meant general opinions of users that I have met so far. In addition, HiveQL feature has not been maintained for more than 6 months, and there have not been any ask for HiveQL. Even Hive moves to SQL.

        Show
        hyunsik Hyunsik Choi added a comment - I meant general opinions of users that I have met so far. In addition, HiveQL feature has not been maintained for more than 6 months, and there have not been any ask for HiveQL. Even Hive moves to SQL.
        Hide
        jihoonson Jihoon Son added a comment -

        Thanks for your comment. I just wonder that there are any public data.
        It's very interesting.
        Thanks!

        Show
        jihoonson Jihoon Son added a comment - Thanks for your comment. I just wonder that there are any public data. It's very interesting. Thanks!
        Hide
        hyunsik Hyunsik Choi added a comment -

        Thank you for you comment

        Currently, the code related to HiveQL causes lots of errors and warnings during unit testing. This is because the code has not been maintained anymore. As a result, I thought that now is the right time to eliminate it.

        Show
        hyunsik Hyunsik Choi added a comment - Thank you for you comment Currently, the code related to HiveQL causes lots of errors and warnings during unit testing. This is because the code has not been maintained anymore. As a result, I thought that now is the right time to eliminate it.
        Hide
        hyunsik Hyunsik Choi added a comment -

        If some committer gives +1, I'll remove it soon.

        Show
        hyunsik Hyunsik Choi added a comment - If some committer gives +1, I'll remove it soon.
        Hide
        jihoonson Jihoon Son added a comment -

        Thanks for explanation. I agree with you.
        But for your patch, Travis CI build is failed with an error.
        In addition, Hive related configurations also should be removed.

        Show
        jihoonson Jihoon Son added a comment - Thanks for explanation. I agree with you. But for your patch, Travis CI build is failed with an error. In addition, Hive related configurations also should be removed.
        Hide
        hyunsik Hyunsik Choi added a comment -

        Travis CI has some limitation where the stdout/error output must be less than 4MB. If the output is more than 4MB, the test is failed in Travis CI. Recently added unit tests make the output size to be more than 4MB. As a result, patches in these days are being failed.

        I manually verified the latest patch via 'mvn clean install'.

        In addition, in order to solve Travis CI failure, we need to change the travis script to redirect stdout to /dev/null. Instead, we need to remain stderr output in order to get the error causes from Travis's output. I'll create another Jira issue for it.

        Thanks!

        Show
        hyunsik Hyunsik Choi added a comment - Travis CI has some limitation where the stdout/error output must be less than 4MB. If the output is more than 4MB, the test is failed in Travis CI. Recently added unit tests make the output size to be more than 4MB. As a result, patches in these days are being failed. I manually verified the latest patch via 'mvn clean install'. In addition, in order to solve Travis CI failure, we need to change the travis script to redirect stdout to /dev/null. Instead, we need to remain stderr output in order to get the error causes from Travis's output. I'll create another Jira issue for it. Thanks!
        Hide
        jihoonson Jihoon Son added a comment -

        Thanks.
        I also verified with 'mvn clean install'.
        Here is my +1.

        Show
        jihoonson Jihoon Son added a comment - Thanks. I also verified with 'mvn clean install'. Here is my +1.
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed. Thanks for quick review.

        Show
        hyunsik Hyunsik Choi added a comment - committed. Thanks for quick review.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/46

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/46
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #258 (See https://builds.apache.org/job/Tajo-master-build/258/)
        TAJO-887: Eliminate HiveQL support feature. (hyunsik: rev fb2ea19c07bb08c96c816238613bf35cdfe5a32a)

        • tajo-core/src/main/antlr4/org/apache/tajo/engine/parser/HiveQLParser.g4
        • tajo-core/src/main/java/org/apache/tajo/engine/parser/HiveQLAnalyzer.java
        • tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
        • tajo-core/src/main/antlr4/org/apache/tajo/engine/parser/HiveQLLexer.g4
        • CHANGES
        • tajo-core/src/test/java/org/apache/tajo/engine/parser/TestHiveQLAnalyzer.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #258 (See https://builds.apache.org/job/Tajo-master-build/258/ ) TAJO-887 : Eliminate HiveQL support feature. (hyunsik: rev fb2ea19c07bb08c96c816238613bf35cdfe5a32a) tajo-core/src/main/antlr4/org/apache/tajo/engine/parser/HiveQLParser.g4 tajo-core/src/main/java/org/apache/tajo/engine/parser/HiveQLAnalyzer.java tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-core/src/main/antlr4/org/apache/tajo/engine/parser/HiveQLLexer.g4 CHANGES tajo-core/src/test/java/org/apache/tajo/engine/parser/TestHiveQLAnalyzer.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #260 (See https://builds.apache.org/job/Tajo-master-build/260/)
        TAJO-887: Eliminate HiveQL support feature. (missed elimination of hiveql config). (hyunsik: rev e52742d774b024985494911366aa1bbf854f8aea)

        • tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
        • tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #260 (See https://builds.apache.org/job/Tajo-master-build/260/ ) TAJO-887 : Eliminate HiveQL support feature. (missed elimination of hiveql config). (hyunsik: rev e52742d774b024985494911366aa1bbf854f8aea) tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development