Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-882

CLI hangs when a error occurs in the GlobalPlanner.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      See title.
      If a error occurs in the GlobalPlanner the query's status is ERROR. But CLI can't receive the error message.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user babokim opened a pull request:

        https://github.com/apache/tajo/pull/42

        TAJO-882: CLI hangs when a error occurs in the GlobalPlanner.

        I added a ErrorInjectionRewriter which throws NullPointerException.
        You can inject a error status using the following code.
        ```
        try

        { // Inject in LogicalPlanner //testingCluster.setAllTajoDaemonConfValue(("tajo.plan.rewriter.classes", // ErrorInjectionRewriter.class.getCanonicalName()); // Inject in PhysicalPlanner testingCluster.setAllWorkersConfValue("tajo.plan.rewriter.classes", ErrorInjectionRewriter.class.getCanonicalName()); }

        finally

        { // testingCluster.setAllTajoDaemonConfValue("tajo.plan.rewriter.classes", ""); testingCluster.setAllWorkersConfValue("tajo.plan.rewriter.classes", ""); }

        ```

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/babokim/tajo TAJO-882

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/42.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #42


        commit ed65d8543c99d88dfbad141a0c6a0a82da408a1b
        Author: 김형준 <babokim@babokim-macbook-pro.local>
        Date: 2014-06-19T01:46:13Z

        TAJO-882: CLI hangs when a error occurs in the GlobalPlanner.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user babokim opened a pull request: https://github.com/apache/tajo/pull/42 TAJO-882 : CLI hangs when a error occurs in the GlobalPlanner. I added a ErrorInjectionRewriter which throws NullPointerException. You can inject a error status using the following code. ``` try { // Inject in LogicalPlanner //testingCluster.setAllTajoDaemonConfValue(("tajo.plan.rewriter.classes", // ErrorInjectionRewriter.class.getCanonicalName()); // Inject in PhysicalPlanner testingCluster.setAllWorkersConfValue("tajo.plan.rewriter.classes", ErrorInjectionRewriter.class.getCanonicalName()); } finally { // testingCluster.setAllTajoDaemonConfValue("tajo.plan.rewriter.classes", ""); testingCluster.setAllWorkersConfValue("tajo.plan.rewriter.classes", ""); } ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/babokim/tajo TAJO-882 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/42.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #42 commit ed65d8543c99d88dfbad141a0c6a0a82da408a1b Author: 김형준 <babokim@babokim-macbook-pro.local> Date: 2014-06-19T01:46:13Z TAJO-882 : CLI hangs when a error occurs in the GlobalPlanner.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/42#issuecomment-46959425

        +1

        The patch looks good to me.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/42#issuecomment-46959425 +1 The patch looks good to me.
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master branch.

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master branch.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/42

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/42
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #256 (See https://builds.apache.org/job/Tajo-master-build/256/)
        TAJO-882: CLI hangs when a error occurs in the GlobalPlanner. (Hyoungjun Kim via hyunsik) (hyunsik: rev dff6a30740bb2348868ebd527ced0a48973bf45c)

        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalOptimizer.java
        • tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoWorkerClientService.java
        • tajo-core/src/main/java/org/apache/tajo/engine/utils/test/ErrorInjectionRewriter.java
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java
        • tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #256 (See https://builds.apache.org/job/Tajo-master-build/256/ ) TAJO-882 : CLI hangs when a error occurs in the GlobalPlanner. (Hyoungjun Kim via hyunsik) (hyunsik: rev dff6a30740bb2348868ebd527ced0a48973bf45c) CHANGES tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalOptimizer.java tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java tajo-core/src/main/java/org/apache/tajo/worker/TajoWorkerClientService.java tajo-core/src/main/java/org/apache/tajo/engine/utils/test/ErrorInjectionRewriter.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java

          People

          • Assignee:
            hjkim Hyoungjun Kim
            Reporter:
            hjkim Hyoungjun Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development