Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-861

tajo-dump script are not executable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.9.0
    • Fix Version/s: 0.9.0
    • Component/s: conf and scripts
    • Labels:
      None

      Description

      makes all ".sh,tajo,tajo-dump,tsql" files below tajo-$project.version/bin readable and executable for anyone on a UNIX system.

      1. TAJO-861.patch
        0.7 kB
        Jinho Kim

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #247 (See https://builds.apache.org/job/Tajo-master-build/247/)
        TAJO-861: tajo-dump script are not executable. (jinho) (jinossy: rev 07225fa3486546872fe1d6e5d917ee0857795317)

        • CHANGES
        • tajo-dist/pom.xml
        • tajo-dist/src/main/bin/tajo-dump
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #247 (See https://builds.apache.org/job/Tajo-master-build/247/ ) TAJO-861 : tajo-dump script are not executable. (jinho) (jinossy: rev 07225fa3486546872fe1d6e5d917ee0857795317) CHANGES tajo-dist/pom.xml tajo-dist/src/main/bin/tajo-dump
        Hide
        jhkim Jinho Kim added a comment -

        I've committed it
        Thank you!

        Show
        jhkim Jinho Kim added a comment - I've committed it Thank you!
        Hide
        jhkim Jinho Kim added a comment -

        Jihoon Son
        I forgot to commit this patch.
        Thank you!

        Show
        jhkim Jinho Kim added a comment - Jihoon Son I forgot to commit this patch. Thank you!
        Hide
        jihoonson Jihoon Son added a comment -

        Jinho Kim,
        the above problem is not related with this issue.
        Would you commit this patch, please?
        Thanks.

        Show
        jihoonson Jihoon Son added a comment - Jinho Kim , the above problem is not related with this issue. Would you commit this patch, please? Thanks.
        Hide
        jihoonson Jihoon Son added a comment -

        Thanks. I'll investigate, too.

        Show
        jihoonson Jihoon Son added a comment - Thanks. I'll investigate, too.
        Hide
        jhkim Jinho Kim added a comment -

        Thank you for the review.
        No, jihoon. I will check it.

        Show
        jhkim Jinho Kim added a comment - Thank you for the review. No, jihoon. I will check it.
        Hide
        jihoonson Jihoon Son added a comment -

        +1
        This patch looks good to me.

        Jinho, I have a question. When I try to restore databases using tajo-dump script, the below error occurs for every 'create table' statement.

        ERROR: syntax error at or near '<EOF>'
        

        Do you know what is the reason of this error?

        Show
        jihoonson Jihoon Son added a comment - +1 This patch looks good to me. Jinho, I have a question. When I try to restore databases using tajo-dump script, the below error occurs for every 'create table' statement. ERROR: syntax error at or near '<EOF>' Do you know what is the reason of this error?
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12647847/TAJO-861.patch
        against master revision 8e65022.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-dist.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/443//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/443//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12647847/TAJO-861.patch against master revision 8e65022. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-dist. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/443//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/443//console This message is automatically generated.

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development