Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-847

Supporting MariaDB-based Store, which is compatible with MySQL.

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.9.0
    • Fix Version/s: 0.9.0
    • Component/s: Catalog, conf and scripts
    • Labels:
      None
    • Environment:

      Tested with Hadoop 2.4.0, Tajo 0.8.0, MariaDB 5.5.37, MariaDB-Java-Client (JDBC) 1.1.7 in OpenJDK 1.7.0_55 + Ubuntu 14.04 LTS x86_64

      Description

      There exists an open-source database MariaDB (http://mariadb.org) which can be replacement for MySQL; Since the interface of MariaDB is perfectly compatible to that of MySQL, it is easy to construct CatalogStore to use MariaDB in Tajo.

      Therefore, I hereby suggest MariaDBStore by duplicating MySQLStore.

      1. TAJO-847.patch
        20 kB
        Jinhang Choi

        Activity

        Hide
        cepiross Jinhang Choi added a comment -

        This patch also includes resolution of NullPointerException in Connection (AbstractDBStore) when Tajo Master tries to check isValid exactly after Session is removed from SessionManager.

        Show
        cepiross Jinhang Choi added a comment - This patch also includes resolution of NullPointerException in Connection (AbstractDBStore) when Tajo Master tries to check isValid exactly after Session is removed from SessionManager.
        Hide
        tajoqa Tajo QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12646751/TAJO-847.patch
        against master revision 5bdfe88.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-server.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/434//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/434//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12646751/TAJO-847.patch against master revision 5bdfe88. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-server. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/434//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/434//console This message is automatically generated.
        Hide
        jihoonson Jihoon Son added a comment -

        Thanks Jinhang.
        I'll review the patch.

        Show
        jihoonson Jihoon Son added a comment - Thanks Jinhang. I'll review the patch.
        Hide
        jihoonson Jihoon Son added a comment -

        Jinhang Choi, apologize for late review.
        For more convenient review, would you mind creating an issue on apache tajo github?
        Thanks.

        Show
        jihoonson Jihoon Son added a comment - Jinhang Choi , apologize for late review. For more convenient review, would you mind creating an issue on apache tajo github? Thanks.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user cepiross opened a pull request:

        https://github.com/apache/tajo/pull/32

        TAJO-847: Supporting MariaDB-based Store, which is compatible with MySQL...

        This patch also includes resolution of NullPointerException in Connection (AbstractDBStore) when Tajo Master tries to check isValid exactly after Session is removed from SessionManager.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/cepiross/tajo branch-0.8.1

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/32.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #32


        commit b545644be7f83293ca063f79bf76db42fbaae179
        Author: Jinhang Choi <jinhang@linewalks.com>
        Date: 2014-06-05T05:57:26Z

        TAJO-847: Supporting MariaDB-based Store, which is compatible with MySQL.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user cepiross opened a pull request: https://github.com/apache/tajo/pull/32 TAJO-847 : Supporting MariaDB-based Store, which is compatible with MySQL... This patch also includes resolution of NullPointerException in Connection (AbstractDBStore) when Tajo Master tries to check isValid exactly after Session is removed from SessionManager. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cepiross/tajo branch-0.8.1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/32.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #32 commit b545644be7f83293ca063f79bf76db42fbaae179 Author: Jinhang Choi <jinhang@linewalks.com> Date: 2014-06-05T05:57:26Z TAJO-847 : Supporting MariaDB-based Store, which is compatible with MySQL.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user cepiross closed the pull request at:

        https://github.com/apache/tajo/pull/32

        Show
        githubbot ASF GitHub Bot added a comment - Github user cepiross closed the pull request at: https://github.com/apache/tajo/pull/32
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user cepiross opened a pull request:

        https://github.com/apache/tajo/pull/33

        TAJO-847: Supporting MariaDB-based Store, which is compatible with MySQL.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/cepiross/tajo TAJO-847

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/33.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #33


        commit c188c7d61b2766c2e50b79df7701cfa1791af70e
        Author: Jinhang Choi <jinhang@linewalks.com>
        Date: 2014-06-05T06:16:26Z

        TAJO-847: Supporting MariaDB-based Store, which is compatible with MySQL.

        This patch also includes resolution of NullPointerException in
        Connection (AbstractDBStore) when Tajo Master tries to check isValid
        exactly after Session is removed from SessionManager.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user cepiross opened a pull request: https://github.com/apache/tajo/pull/33 TAJO-847 : Supporting MariaDB-based Store, which is compatible with MySQL. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cepiross/tajo TAJO-847 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/33.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #33 commit c188c7d61b2766c2e50b79df7701cfa1791af70e Author: Jinhang Choi <jinhang@linewalks.com> Date: 2014-06-05T06:16:26Z TAJO-847 : Supporting MariaDB-based Store, which is compatible with MySQL. This patch also includes resolution of NullPointerException in Connection (AbstractDBStore) when Tajo Master tries to check isValid exactly after Session is removed from SessionManager.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/33#issuecomment-45289511

        0.8.1 branch does not include .travis.yml file. So, it will not work in 0.8.1 branch.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/33#issuecomment-45289511 0.8.1 branch does not include .travis.yml file. So, it will not work in 0.8.1 branch.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/33#issuecomment-45457348

        @cepiross
        as @hyunsik commented above, this patch cannot be applied to branch 0.8.1. It causes Travis CI build failure.
        Please change the target branch to master.
        Thanks.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/33#issuecomment-45457348 @cepiross as @hyunsik commented above, this patch cannot be applied to branch 0.8.1. It causes Travis CI build failure. Please change the target branch to master. Thanks.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user cepiross closed the pull request at:

        https://github.com/apache/tajo/pull/33

        Show
        githubbot ASF GitHub Bot added a comment - Github user cepiross closed the pull request at: https://github.com/apache/tajo/pull/33
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user cepiross opened a pull request:

        https://github.com/apache/tajo/pull/39

        TAJO-847: Supporting MariaDB-based Store, which is compatible with MySQL.

        I have switched TAJO-847 pull request from branch-0.8.1 to master.
        Please check this version.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/cepiross/tajo TAJO-847

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/39.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #39


        commit 4bdd2773275747398e26a4025e4cc90d55b56d3a
        Author: Jinhang Choi <jinhang@linewalks.com>
        Date: 2014-06-16T06:41:18Z

        TAJO-847: Supporting MariaDB-based Store, which is compatible with MySQL.

        commit 715400908ca72311dac15367a38e61b6521db54a
        Author: Jinhang Choi <jinhang@linewalks.com>
        Date: 2014-06-17T07:13:23Z

        TAJO-847: MariaDB JDBC NPE Consideration.

        Change JDBC NullPointerException to be MariaDBStore-specific handling.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user cepiross opened a pull request: https://github.com/apache/tajo/pull/39 TAJO-847 : Supporting MariaDB-based Store, which is compatible with MySQL. I have switched TAJO-847 pull request from branch-0.8.1 to master. Please check this version. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cepiross/tajo TAJO-847 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/39.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #39 commit 4bdd2773275747398e26a4025e4cc90d55b56d3a Author: Jinhang Choi <jinhang@linewalks.com> Date: 2014-06-16T06:41:18Z TAJO-847 : Supporting MariaDB-based Store, which is compatible with MySQL. commit 715400908ca72311dac15367a38e61b6521db54a Author: Jinhang Choi <jinhang@linewalks.com> Date: 2014-06-17T07:13:23Z TAJO-847 : MariaDB JDBC NPE Consideration. Change JDBC NullPointerException to be MariaDBStore-specific handling.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/39#discussion_r13846303

        — Diff: tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java —
        @@ -152,9 +152,20 @@ protected String getCatalogUri()

        { return catalogUri; }

        + protected boolean isConnValid(int timeout) throws CatalogException {
        — End diff –

        As I know, this function is a temporal solution to handle the internal NPE of MariaDB. Would you leave some descriptions of the error and this solution?

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/39#discussion_r13846303 — Diff: tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java — @@ -152,9 +152,20 @@ protected String getCatalogUri() { return catalogUri; } + protected boolean isConnValid(int timeout) throws CatalogException { — End diff – As I know, this function is a temporal solution to handle the internal NPE of MariaDB. Would you leave some descriptions of the error and this solution?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/39#issuecomment-46277006

        Hi Jinhang,
        The patch looks good to me.
        I left only one comment.
        Thanks!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/39#issuecomment-46277006 Hi Jinhang, The patch looks good to me. I left only one comment. Thanks!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user cepiross commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/39#discussion_r13847503

        — Diff: tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java —
        @@ -152,9 +152,20 @@ protected String getCatalogUri()

        { return catalogUri; }

        + protected boolean isConnValid(int timeout) throws CatalogException {
        — End diff –

        As @jihoonson stated, I experienced Tajo Session removal, indicating that MariaDB JDBC disconnection, when I tried to execute a query directly after dropping table schema, as following:

        *NOTE! this log is only after applying latest TAJO-847 patch*
        2014-06-17 12:48:35,466 INFO org.apache.tajo.master.GlobalEngine: =============================================
        2014-06-17 12:48:35,489 INFO org.apache.tajo.catalog.CatalogServer: relation "linewalks.test" is deleted from the catalog (192.168.0.15:26005)
        2014-06-17 12:48:35,504 INFO org.apache.tajo.master.GlobalEngine: relation "linewalks.test" is purged.
        2014-06-17 12:48:43,526 INFO org.apache.tajo.master.GlobalEngine: Query: select * from table20
        2014-06-17 12:48:43,526 INFO org.apache.tajo.master.GlobalEngine: hive.query.mode:false
        2014-06-17 12:48:43,529 INFO org.apache.tajo.catalog.store.MariaDBStore: Conn abortion when checking isValid; retrieve false to create another Conn.
        2014-06-17 12:48:43,565 INFO org.apache.tajo.master.GlobalEngine: =============================================
        2014-06-17 12:48:43,565 INFO org.apache.tajo.master.GlobalEngine: Optimized Query:

        2014-06-17 12:48:43,565 INFO org.apache.tajo.master.GlobalEngine: =============================================
        2014-06-17 12:48:47,272 INFO org.apache.tajo.master.session.SessionManager: Session a1121c5d-51ea-4397-b345-e062cd32350f is removed.

        [Error description]
        In other words, the query sequence always incurs NullPointerException in invoking Conn.isValid method when using up-to-date MariaDB JDBC Connector.
        [Solution]
        To avoid the drawback, I have agreed with @jihoonson to insert MariaDBStore-specific NPE handling, isConnValid method; which is a temporal solution until MariaDB JDBC resolves disconnection issue.

        Show
        githubbot ASF GitHub Bot added a comment - Github user cepiross commented on a diff in the pull request: https://github.com/apache/tajo/pull/39#discussion_r13847503 — Diff: tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java — @@ -152,9 +152,20 @@ protected String getCatalogUri() { return catalogUri; } + protected boolean isConnValid(int timeout) throws CatalogException { — End diff – As @jihoonson stated, I experienced Tajo Session removal, indicating that MariaDB JDBC disconnection, when I tried to execute a query directly after dropping table schema, as following: * NOTE! this log is only after applying latest TAJO-847 patch * 2014-06-17 12:48:35,466 INFO org.apache.tajo.master.GlobalEngine: ============================================= 2014-06-17 12:48:35,489 INFO org.apache.tajo.catalog.CatalogServer: relation "linewalks.test" is deleted from the catalog (192.168.0.15:26005) 2014-06-17 12:48:35,504 INFO org.apache.tajo.master.GlobalEngine: relation "linewalks.test" is purged. 2014-06-17 12:48:43,526 INFO org.apache.tajo.master.GlobalEngine: Query: select * from table20 2014-06-17 12:48:43,526 INFO org.apache.tajo.master.GlobalEngine: hive.query.mode:false 2014-06-17 12:48:43,529 INFO org.apache.tajo.catalog.store.MariaDBStore: Conn abortion when checking isValid; retrieve false to create another Conn. 2014-06-17 12:48:43,565 INFO org.apache.tajo.master.GlobalEngine: ============================================= 2014-06-17 12:48:43,565 INFO org.apache.tajo.master.GlobalEngine: Optimized Query: … 2014-06-17 12:48:43,565 INFO org.apache.tajo.master.GlobalEngine: ============================================= 2014-06-17 12:48:47,272 INFO org.apache.tajo.master.session.SessionManager: Session a1121c5d-51ea-4397-b345-e062cd32350f is removed. [Error description] In other words, the query sequence always incurs NullPointerException in invoking Conn.isValid method when using up-to-date MariaDB JDBC Connector. [Solution] To avoid the drawback, I have agreed with @jihoonson to insert MariaDBStore-specific NPE handling, isConnValid method; which is a temporal solution until MariaDB JDBC resolves disconnection issue.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user cepiross commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/39#discussion_r13848338

        — Diff: tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MariaDBStore.java —
        @@ -0,0 +1,301 @@
        +/**
        + * Licensed to the Apache Software Foundation (ASF) under one
        + * or more contributor license agreements. See the NOTICE file
        + * distributed with this work for additional information
        + * regarding copyright ownership. The ASF licenses this file
        + * to you under the Apache License, Version 2.0 (the
        + * "License"); you may not use this file except in compliance
        + * with the License. You may obtain a copy of the License at
        + *
        + * http://www.apache.org/licenses/LICENSE-2.0
        + *
        + * Unless required by applicable law or agreed to in writing, software
        + * distributed under the License is distributed on an "AS IS" BASIS,
        + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
        + * See the License for the specific language governing permissions and
        + * limitations under the License.
        + */
        +
        +/**
        + *
        + */
        +package org.apache.tajo.catalog.store;
        +
        +import org.apache.hadoop.conf.Configuration;
        +import org.apache.tajo.catalog.CatalogUtil;
        +import org.apache.tajo.catalog.exception.CatalogException;
        +import org.apache.tajo.exception.InternalException;
        +
        +import java.sql.*;
        +import java.util.HashMap;
        +import java.util.Map;
        +
        +public class MariaDBStore extends AbstractDBStore {
        + /** 2014-06-09: First versioning */
        + private static final int MARIADB_CATALOG_STORE_VERSION = 2;
        +
        + private static final String CATALOG_DRIVER = "org.mariadb.jdbc.Driver";
        + protected String getCatalogDriverName()

        { + return CATALOG_DRIVER; + }

        +
        + public MariaDBStore(final Configuration conf) throws InternalException

        { + super(conf); + }

        +
        + @Override
        + public int getDriverVersion()

        { + return MARIADB_CATALOG_STORE_VERSION; + }

        +
        + protected Connection createConnection(Configuration conf) throws SQLException

        { + Connection con = DriverManager.getConnection(getCatalogUri(), this.connectionId, + this.connectionPassword); + //TODO con.setAutoCommit(false); + return con; + }

        +
        + @Override
        + protected boolean isConnValid(int timeout) throws CatalogException {
        + boolean isValid = false;
        +
        + try

        { + isValid = super.isConnValid(timeout); + }

        catch (NullPointerException e) {
        + LOG.info("Conn abortion when checking isValid; retrieve false to create another Conn.");
        — End diff –

        MariaDBStore's isValid NPE handling will give NACK to getConnection method so that Tajo tries to connect another JDBC session.

        Show
        githubbot ASF GitHub Bot added a comment - Github user cepiross commented on a diff in the pull request: https://github.com/apache/tajo/pull/39#discussion_r13848338 — Diff: tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MariaDBStore.java — @@ -0,0 +1,301 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +/** + * + */ +package org.apache.tajo.catalog.store; + +import org.apache.hadoop.conf.Configuration; +import org.apache.tajo.catalog.CatalogUtil; +import org.apache.tajo.catalog.exception.CatalogException; +import org.apache.tajo.exception.InternalException; + +import java.sql.*; +import java.util.HashMap; +import java.util.Map; + +public class MariaDBStore extends AbstractDBStore { + /** 2014-06-09: First versioning */ + private static final int MARIADB_CATALOG_STORE_VERSION = 2; + + private static final String CATALOG_DRIVER = "org.mariadb.jdbc.Driver"; + protected String getCatalogDriverName() { + return CATALOG_DRIVER; + } + + public MariaDBStore(final Configuration conf) throws InternalException { + super(conf); + } + + @Override + public int getDriverVersion() { + return MARIADB_CATALOG_STORE_VERSION; + } + + protected Connection createConnection(Configuration conf) throws SQLException { + Connection con = DriverManager.getConnection(getCatalogUri(), this.connectionId, + this.connectionPassword); + //TODO con.setAutoCommit(false); + return con; + } + + @Override + protected boolean isConnValid(int timeout) throws CatalogException { + boolean isValid = false; + + try { + isValid = super.isConnValid(timeout); + } catch (NullPointerException e) { + LOG.info("Conn abortion when checking isValid; retrieve false to create another Conn."); — End diff – MariaDBStore's isValid NPE handling will give NACK to getConnection method so that Tajo tries to connect another JDBC session.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/39#issuecomment-46410114

        Thanks @cepiross,
        this patch looks good to me.
        Here is my +1, and I'll commit this patch if there aren't any objections for a while.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/39#issuecomment-46410114 Thanks @cepiross, this patch looks good to me. Here is my +1, and I'll commit this patch if there aren't any objections for a while.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/39#issuecomment-46424981

        I've just committed it.
        Please close this pull request.
        Thanks!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/39#issuecomment-46424981 I've just committed it. Please close this pull request. Thanks!
        Hide
        jihoonson Jihoon Son added a comment -

        The latest patch got +1 from GitHub.
        Jinhang Choi, thanks for your contribution!

        Show
        jihoonson Jihoon Son added a comment - The latest patch got +1 from GitHub. Jinhang Choi , thanks for your contribution!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #249 (See https://builds.apache.org/job/Tajo-master-build/249/)
        TAJO-847: Supporting MariaDB-based Store, which is compatible with MySQL. (Jinhang Choi via jihoon) (jihoonson: rev 9f54c4b73f676dbfd2e2c8e53d24e7e1430b8292)

        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/table_properties.sql
        • CHANGES
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/tables.sql
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MariaDBStore.java
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/databases.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/indexes.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/columns.sql
        • tajo-docs/src/main/sphinx/configuration/catalog_configuration.rst
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/partition_methods.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/partitions.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/stats.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/tablespaces.sql
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #249 (See https://builds.apache.org/job/Tajo-master-build/249/ ) TAJO-847 : Supporting MariaDB-based Store, which is compatible with MySQL. (Jinhang Choi via jihoon) (jihoonson: rev 9f54c4b73f676dbfd2e2c8e53d24e7e1430b8292) tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/table_properties.sql CHANGES tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/tables.sql tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MariaDBStore.java tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/databases.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/indexes.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/columns.sql tajo-docs/src/main/sphinx/configuration/catalog_configuration.rst tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/partition_methods.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/partitions.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/stats.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/tablespaces.sql
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user cepiross commented on the pull request:

        https://github.com/apache/tajo/pull/39#issuecomment-46518021

        Thanks for your help!

        Show
        githubbot ASF GitHub Bot added a comment - Github user cepiross commented on the pull request: https://github.com/apache/tajo/pull/39#issuecomment-46518021 Thanks for your help!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user cepiross closed the pull request at:

        https://github.com/apache/tajo/pull/39

        Show
        githubbot ASF GitHub Bot added a comment - Github user cepiross closed the pull request at: https://github.com/apache/tajo/pull/39
        Hide
        cepiross Jinhang Choi added a comment -

        Already shipped on Tajo master branch.

        Show
        cepiross Jinhang Choi added a comment - Already shipped on Tajo master branch.

          People

          • Assignee:
            cepiross Jinhang Choi
            Reporter:
            cepiross Jinhang Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 24h
              24h
              Remaining:
              Remaining Estimate - 24h
              24h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development