Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-829

Same constants in groupby clause may cause planning error.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0, 0.8.1
    • Component/s: Planner/Optimizer
    • Labels:
      None

      Description

      select l_partkey as a, '##' as b, '##' as c, count(*) d
      from lineitem
      group by a, b, c
      

      See the above query case. This query causes the planning error. This patch fixes the bug. Also, this patch removes duplicated group by keys.

      I verified 'mvn clean install'.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/10

        TAJO-829: Same constants in groupby clause may cause planning error.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-829

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/10.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #10


        commit 1c21e8bb692a33530cb804291517f57635b4b091
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2014-05-14T06:04:41Z

        TAJO-829: Same constants in groupby clause may cause planning error.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/10 TAJO-829 : Same constants in groupby clause may cause planning error. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-829 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/10.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #10 commit 1c21e8bb692a33530cb804291517f57635b4b091 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2014-05-14T06:04:41Z TAJO-829 : Same constants in groupby clause may cause planning error.
        Hide
        blrunner Jaehwa Jung added a comment -

        +1

        Thank you for your contribution.
        Push it.

        Show
        blrunner Jaehwa Jung added a comment - +1 Thank you for your contribution. Push it.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/10

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/10
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master and branch-0.8.1. Thanks!

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master and branch-0.8.1. Thanks!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-build #219 (See https://builds.apache.org/job/Tajo-master-build/219/)
        TAJO-829: Same constants in groupby clause may cause planning error. (hyunsik: rev 1c21e8bb692a33530cb804291517f57635b4b091)

        • tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithSameConstantKeys1.sql
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/rewrite/ProjectionPushDownRule.java
        • tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithSameConstantKeys1.result
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestGroupByQuery.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #219 (See https://builds.apache.org/job/Tajo-master-build/219/ ) TAJO-829 : Same constants in groupby clause may cause planning error. (hyunsik: rev 1c21e8bb692a33530cb804291517f57635b4b091) tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithSameConstantKeys1.sql tajo-core/src/main/java/org/apache/tajo/engine/planner/rewrite/ProjectionPushDownRule.java tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithSameConstantKeys1.result tajo-core/src/test/java/org/apache/tajo/engine/query/TestGroupByQuery.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.8.1-build #99 (See https://builds.apache.org/job/Tajo-0.8.1-build/99/)
        TAJO-829: Same constants in groupby clause may cause planning error. (hyunsik: rev 9e2b31c2ea3534f5014ee10004e40468ecd4c9fb)

        • tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithSameConstantKeys1.result
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestGroupByQuery.java
        • tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithSameConstantKeys1.sql
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/rewrite/ProjectionPushDownRule.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.8.1-build #99 (See https://builds.apache.org/job/Tajo-0.8.1-build/99/ ) TAJO-829 : Same constants in groupby clause may cause planning error. (hyunsik: rev 9e2b31c2ea3534f5014ee10004e40468ecd4c9fb) tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithSameConstantKeys1.result tajo-core/src/test/java/org/apache/tajo/engine/query/TestGroupByQuery.java tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithSameConstantKeys1.sql tajo-core/src/main/java/org/apache/tajo/engine/planner/rewrite/ProjectionPushDownRule.java

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development