Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-824

Improve SimpleParser to handle JSON statements

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Not A Problem
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: SQL Shell
    • Labels:
      None

      Description

      Currently, JSON statements are directly executed in TajoCli without parsing. Thus, we cannot provide a lot of useful functions such as inline comments for JSON statements.

      1. TAJO-824.patch
        17 kB
        Jihoon Son

        Activity

        Hide
        jihoonson Jihoon Son added a comment -

        As discussed in Github (https://github.com/apache/tajo/pull/9), we need to separate the JSON cli from TajoCli instead of improving it.

        Show
        jihoonson Jihoon Son added a comment - As discussed in Github ( https://github.com/apache/tajo/pull/9 ), we need to separate the JSON cli from TajoCli instead of improving it.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/9#issuecomment-42941099

        Thank you for your agreement!

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/9#issuecomment-42941099 Thank you for your agreement!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson closed the pull request at:

        https://github.com/apache/tajo/pull/9

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson closed the pull request at: https://github.com/apache/tajo/pull/9
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/9#issuecomment-42940888

        Thanks.
        I'll start it at another issue.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/9#issuecomment-42940888 Thanks. I'll start it at another issue.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/9#issuecomment-42923028

        If the main purpose is for testing or debugging, it would be good to separate JsonCli from TajoCli and implement a simple JsonCli for only testing. If so, it will rarely add additional maintenance burden for us.

        Thanks!

        Thanks!

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/9#issuecomment-42923028 If the main purpose is for testing or debugging, it would be good to separate JsonCli from TajoCli and implement a simple JsonCli for only testing. If so, it will rarely add additional maintenance burden for us. Thanks! Thanks!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/9#issuecomment-42922410

        Hi Hyunsik.

        Thanks for your comment.
        I agree on that there are only few guys who directly execute JSON queries via cl. But, I think that JSON execution via cli is necessary for the purpose of test or debug.

        SQL-specialized cli sounds very interesting. Auto SQL completion will be very useful. However, as you said, maintaining a separate JSON cli will be a burden for us.
        Do you have any good idea?

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/9#issuecomment-42922410 Hi Hyunsik. Thanks for your comment. I agree on that there are only few guys who directly execute JSON queries via cl. But, I think that JSON execution via cli is necessary for the purpose of test or debug. SQL-specialized cli sounds very interesting. Auto SQL completion will be very useful. However, as you said, maintaining a separate JSON cli will be a burden for us. Do you have any good idea?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/9#issuecomment-42918750

        Hi Jihoon,

        Thank you for your contribution. Here is my comment for this feature.

        I'd like to propose separating JSON cli client from TajoCli. Later, we are improving TajoCli to be specified for SQL and we will add its related features like auto SQL completion. In my opinion, the improvement of TajoCli would be restricted if TajoCli supports both SQL and JSON.

        Also, I think that there are only few of guys want to directly input JSON to command line interface. This feature would be mostly used via Client API. I think that it may be hard for our development resource to maintain JSON Cli.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/9#issuecomment-42918750 Hi Jihoon, Thank you for your contribution. Here is my comment for this feature. I'd like to propose separating JSON cli client from TajoCli. Later, we are improving TajoCli to be specified for SQL and we will add its related features like auto SQL completion. In my opinion, the improvement of TajoCli would be restricted if TajoCli supports both SQL and JSON. Also, I think that there are only few of guys want to directly input JSON to command line interface. This feature would be mostly used via Client API. I think that it may be hard for our development resource to maintain JSON Cli.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jihoonson opened a pull request:

        https://github.com/apache/tajo/pull/9

        TAJO-824

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jihoonson/tajo-2 TAJO-824

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/9.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #9


        commit 20a8deccf1b6e0bda571507bffb542bd1e98c629
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2014-05-13T03:01:00Z

        TAJO-824


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jihoonson opened a pull request: https://github.com/apache/tajo/pull/9 TAJO-824 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jihoonson/tajo-2 TAJO-824 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/9.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #9 commit 20a8deccf1b6e0bda571507bffb542bd1e98c629 Author: Jihoon Son <jihoonson@apache.org> Date: 2014-05-13T03:01:00Z TAJO-824

          People

          • Assignee:
            jihoonson Jihoon Son
            Reporter:
            jihoonson Jihoon Son
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development