Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-816

NULL delimiter doesn't apply with HCatalogStore

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0, 0.8.1
    • Component/s: Catalog
    • Labels:
      None

      Description

      If we use csvfile.null with HCatalogStore, it will run without some exceptions. But we can't find serialization.null.format parameter on Hive as follows:

      • Tajo
        create external table table2 (id int, name text, score float, type text) using csv with ('csvfile.delimiter'='|','csvfile.null'=''
        > ) location 'hdfs://localhost:9010/tajo/warehouse/table2' ;
        
      • Hive
        hive> show create table table2;
        OK
        CREATE EXTERNAL TABLE table2(
          id int COMMENT '', 
          name string COMMENT '', 
          score float COMMENT '', 
          type string COMMENT '')
        ROW FORMAT DELIMITED 
          FIELDS TERMINATED BY '|' 
        STORED AS INPUTFORMAT 
          'org.apache.hadoop.mapred.TextInputFormat' 
        OUTPUTFORMAT 
          'org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat'
        LOCATION
          'hdfs://localhost:9010/tajo/warehouse/table2'
        TBLPROPERTIES (
          'csvfile.null'='', 
          'transient_lastDdlTime'='1399433333', 
          'csvfile.delimiter'='|')
        
      1. TAJO-816.patch
        7 kB
        Jaehwa Jung

        Activity

        Hide
        blrunner Jaehwa Jung added a comment -

        Created a review request against branch master in reviewboard
        https://reviews.apache.org/r/21158/

        Show
        blrunner Jaehwa Jung added a comment - Created a review request against branch master in reviewboard https://reviews.apache.org/r/21158/
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12643753/TAJO-816.patch
        against master revision 3ffb4ee.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        -1 release audit. The applied patch generated 1 release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-drivers/tajo-hcatalog.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/415//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/415//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/415//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12643753/TAJO-816.patch against master revision 3ffb4ee. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit. The applied patch generated 1 release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-drivers/tajo-hcatalog. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/415//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/415//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/415//console This message is automatically generated.
        Hide
        blrunner Jaehwa Jung added a comment -

        Hi Hyunsik Choi.

        Thank you for your review.
        I've just committed it to master and branch-0.8.1.

        Cheers
        Jaehwa

        Show
        blrunner Jaehwa Jung added a comment - Hi Hyunsik Choi . Thank you for your review. I've just committed it to master and branch-0.8.1. Cheers Jaehwa
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.8.1-build #98 (See https://builds.apache.org/job/Tajo-0.8.1-build/98/)
        TAJO-816: NULL delimiter doesn't apply with HCatalogStore. (jaehwa) (jhjung: rev 05cf595396a24c8fb0f6ae0525740fe5ff44a2e8)

        • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java
        • CHANGES
        • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/TestHCatalogStore.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.8.1-build #98 (See https://builds.apache.org/job/Tajo-0.8.1-build/98/ ) TAJO-816 : NULL delimiter doesn't apply with HCatalogStore. (jaehwa) (jhjung: rev 05cf595396a24c8fb0f6ae0525740fe5ff44a2e8) tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java CHANGES tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/TestHCatalogStore.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #218 (See https://builds.apache.org/job/Tajo-master-build/218/)
        TAJO-816: NULL delimiter doesn't apply with HCatalogStore. (jaehwa) (jhjung: rev 77fdbfb2e596c7b1c4d54dff9f4161b9b5378889)

        • CHANGES
        • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/TestHCatalogStore.java
        • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #218 (See https://builds.apache.org/job/Tajo-master-build/218/ ) TAJO-816 : NULL delimiter doesn't apply with HCatalogStore. (jaehwa) (jhjung: rev 77fdbfb2e596c7b1c4d54dff9f4161b9b5378889) CHANGES tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/TestHCatalogStore.java tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java

          People

          • Assignee:
            blrunner Jaehwa Jung
            Reporter:
            blrunner Jaehwa Jung
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development