Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-813

CLI should support comment character with multi-line query.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      ERROR occurs in the case of the following query in Tajo CLI.

      default> select
      > id
      > -- ,name1
      > from table2;
      ERROR: no such a column name id
      default>
      
      1. TAJO-813_2.patch
        29 kB
        Hyunsik Choi
      2. TAJO-813.patch
        26 kB
        Hyoungjun Kim

        Activity

        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12643743/TAJO-813.patch
        against master revision 3ffb4ee.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

        -1 release audit. The applied patch generated 1 release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-client tajo-core.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/414//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/414//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt
        Findbugs results: https://builds.apache.org/job/PreCommit-TAJO-Build/414//findbugsResult
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/414//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12643743/TAJO-813.patch against master revision 3ffb4ee. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. -1 release audit. The applied patch generated 1 release audit warnings. +1 core tests. The patch passed unit tests in tajo-client tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/414//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/414//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt Findbugs results: https://builds.apache.org/job/PreCommit-TAJO-Build/414//findbugsResult Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/414//console This message is automatically generated.
        Hide
        hjkim Hyoungjun Kim added a comment -

        I create a review request on RB. Please review this patch.
        https://reviews.apache.org/r/21187/

        Show
        hjkim Hyoungjun Kim added a comment - I create a review request on RB. Please review this patch. https://reviews.apache.org/r/21187/
        Hide
        hyunsik Hyunsik Choi added a comment -

        +1

        The patch fixes the bug correctly, and it includes unit tests. I changed some trivial things of your patch. The changes add more comments and refactor some variable names and methods. I'll commit it shortly. Thank you very much!

        Show
        hyunsik Hyunsik Choi added a comment - +1 The patch fixes the bug correctly, and it includes unit tests. I changed some trivial things of your patch. The changes add more comments and refactor some variable names and methods. I'll commit it shortly. Thank you very much!
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master branch. Thanks!

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master branch. Thanks!
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12643933/TAJO-813_2.patch
        against master revision eb4e54a.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 185 new Findbugs (version 1.3.9) warnings.

        -1 release audit. The applied patch generated 1 release audit warnings.

        -1 core tests. The patch failed these unit tests in tajo-client tajo-core:
        org.apache.tajo.engine.query.TestCTASQuery
        org.apache.tajo.master.querymaster.TestQueryUnitStatusUpdate
        org.apache.tajo.engine.eval.TestSQLDateTimeTypes
        org.apache.tajo.engine.function.TestDateTimeFunctions
        org.apache.tajo.engine.function.TestConditionalExpressions
        org.apache.tajo.cli.TestSimpleParser
        org.apache.tajo.engine.query.TestJoinOnPartitionedTables
        org.apache.tajo.engine.query.TestGroupByQuery
        org.apache.tajo.engine.query.TestInsertQuery
        org.apache.tajo.engine.query.TestNetTypes
        org.apache.tajo.engine.query.TestJoinBroadcast
        org.apache.tajo.engine.function.TestPatternMatchingPredicates
        org.apache.tajo.engine.query.TestAlterTable
        org.apache.tajo.engine.function.TestMathFunctions
        org.apache.tajo.engine.query.TestCreateTable
        org.apache.tajo.engine.query.TestSortQuery
        org.apache.tajo.engine.function.TestBuiltinFunctions
        org.apache.tajo.cli.TestTajoCli
        org.apache.tajo.benchmark.TestTPCH
        org.apache.tajo.engine.eval.TestIntervalType
        org.apache.tajo.engine.query.TestDropTable
        org.apache.tajo.engine.function.TestStringOperatorsAndFunctions
        org.apache.tajo.engine.query.TestTableSubQuery
        org.apache.tajo.engine.query.TestTablePartitions
        org.apache.tajo.engine.eval.TestPredicates
        org.apache.tajo.engine.eval.TestSQLExpression
        org.apache.tajo.engine.query.TestJoinQuery
        org.apache.tajo.engine.query.TestSelectQuery
        org.apache.tajo.engine.query.TestCaseByCases
        org.apache.tajo.engine.query.TestUnionQuery

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/417//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/417//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/417//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/417//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/417//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12643933/TAJO-813_2.patch against master revision eb4e54a. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 185 new Findbugs (version 1.3.9) warnings. -1 release audit. The applied patch generated 1 release audit warnings. -1 core tests. The patch failed these unit tests in tajo-client tajo-core: org.apache.tajo.engine.query.TestCTASQuery org.apache.tajo.master.querymaster.TestQueryUnitStatusUpdate org.apache.tajo.engine.eval.TestSQLDateTimeTypes org.apache.tajo.engine.function.TestDateTimeFunctions org.apache.tajo.engine.function.TestConditionalExpressions org.apache.tajo.cli.TestSimpleParser org.apache.tajo.engine.query.TestJoinOnPartitionedTables org.apache.tajo.engine.query.TestGroupByQuery org.apache.tajo.engine.query.TestInsertQuery org.apache.tajo.engine.query.TestNetTypes org.apache.tajo.engine.query.TestJoinBroadcast org.apache.tajo.engine.function.TestPatternMatchingPredicates org.apache.tajo.engine.query.TestAlterTable org.apache.tajo.engine.function.TestMathFunctions org.apache.tajo.engine.query.TestCreateTable org.apache.tajo.engine.query.TestSortQuery org.apache.tajo.engine.function.TestBuiltinFunctions org.apache.tajo.cli.TestTajoCli org.apache.tajo.benchmark.TestTPCH org.apache.tajo.engine.eval.TestIntervalType org.apache.tajo.engine.query.TestDropTable org.apache.tajo.engine.function.TestStringOperatorsAndFunctions org.apache.tajo.engine.query.TestTableSubQuery org.apache.tajo.engine.query.TestTablePartitions org.apache.tajo.engine.eval.TestPredicates org.apache.tajo.engine.eval.TestSQLExpression org.apache.tajo.engine.query.TestJoinQuery org.apache.tajo.engine.query.TestSelectQuery org.apache.tajo.engine.query.TestCaseByCases org.apache.tajo.engine.query.TestUnionQuery Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/417//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/417//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/417//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/417//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/417//console This message is automatically generated.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #215 (See https://builds.apache.org/job/Tajo-master-build/215/)
        TAJO-813: CLI should support comment character with multi-line query. (Hyoungjun Kim via hyunsik) (hyunsik: rev 8e523c12e50ff660b09b4d6fa289ea617e08fbfa)

        • tajo-core/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java
        • tajo-client/src/main/java/org/apache/tajo/cli/ParsedResult.java
        • tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java
        • tajo-client/src/main/java/org/apache/tajo/jdbc/TajoResultSetBase.java
        • tajo-client/src/main/java/org/apache/tajo/cli/SimpleParser.java
        • tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java
        • CHANGES
        • tajo-core/src/test/java/org/apache/tajo/cli/TestSimpleParser.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #215 (See https://builds.apache.org/job/Tajo-master-build/215/ ) TAJO-813 : CLI should support comment character with multi-line query. (Hyoungjun Kim via hyunsik) (hyunsik: rev 8e523c12e50ff660b09b4d6fa289ea617e08fbfa) tajo-core/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java tajo-client/src/main/java/org/apache/tajo/cli/ParsedResult.java tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java tajo-client/src/main/java/org/apache/tajo/jdbc/TajoResultSetBase.java tajo-client/src/main/java/org/apache/tajo/cli/SimpleParser.java tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java CHANGES tajo-core/src/test/java/org/apache/tajo/cli/TestSimpleParser.java

          People

          • Assignee:
            hjkim Hyoungjun Kim
            Reporter:
            hjkim Hyoungjun Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development