Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-812

Some methods of TajoDatabaseMetaData should result in an empty tuple list instead of SQLFeatureNotSupportedException.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0, 0.8.1
    • Component/s: JDBC Driver
    • Labels:
      None

      Description

      There are some methods that Tajo cannot support. getPrimaryKeys, getExportedKeys, and getImportedKeys are examples. Currently, these methods cause SQLFeatureNotSupportedException. But, they should return an empty list instead of the exception. This patch fixes this problem.

      In addition, this patch fixes some potential deadlock problem in NettyClientBase and NettyServerBase.

      1. TAJO-812.patch
        8 kB
        Hyunsik Choi

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/6

        TAJO-812: Some methods of TajoDatabaseMetaData should result in an empty tuple list instead of SQLFeatureNotSupportedException.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-812

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/6.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #6


        commit 291384cc3ac54087c7fa58934e9098e1390a9933
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2014-05-07T03:51:55Z

        TAJO-812: Some methods of TajoDatabaseMetaData should result in an empty tuple list instead of SQLFeatureNotSupportedException.

        commit f9a018756cec68a8e245ab269c195b9b84bfafe2
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2014-05-07T03:52:23Z

        Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-812


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/6 TAJO-812 : Some methods of TajoDatabaseMetaData should result in an empty tuple list instead of SQLFeatureNotSupportedException. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-812 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/6.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6 commit 291384cc3ac54087c7fa58934e9098e1390a9933 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2014-05-07T03:51:55Z TAJO-812 : Some methods of TajoDatabaseMetaData should result in an empty tuple list instead of SQLFeatureNotSupportedException. commit f9a018756cec68a8e245ab269c195b9b84bfafe2 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2014-05-07T03:52:23Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-812
        Hide
        blrunner Jaehwa Jung added a comment -

        +1

        Thank you for your contribution.
        It will be useful to some tajo jdbc clients.
        Push it.

        Show
        blrunner Jaehwa Jung added a comment - +1 Thank you for your contribution. It will be useful to some tajo jdbc clients. Push it.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12643691/TAJO-812.patch
        against master revision 70567fc.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-client tajo-jdbc tajo-rpc.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/413//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/413//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-jdbc.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/413//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12643691/TAJO-812.patch against master revision 70567fc. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-client tajo-jdbc tajo-rpc. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/413//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/413//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-jdbc.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/413//console This message is automatically generated.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/6

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/6
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-build #213 (See https://builds.apache.org/job/Tajo-master-build/213/)
        TAJO-812: Some methods of TajoDatabaseMetaData should result in an empty tuple list instead of SQLFeatureNotSupportedException. (hyunsik: rev 3ffb4ee24499865720eef518d8ccb1948c274d65)

        • pom.xml
        • tajo-project/src/site/resources/releases/0.8.0/relnotes.html
        • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoPreparedStatement.java
        • tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyClientBase.java
        • tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java
        • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDatabaseMetaData.java
        • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoMetaDataResultSet.java
        • tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyServerBase.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #213 (See https://builds.apache.org/job/Tajo-master-build/213/ ) TAJO-812 : Some methods of TajoDatabaseMetaData should result in an empty tuple list instead of SQLFeatureNotSupportedException. (hyunsik: rev 3ffb4ee24499865720eef518d8ccb1948c274d65) pom.xml tajo-project/src/site/resources/releases/0.8.0/relnotes.html tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoPreparedStatement.java tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyClientBase.java tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDatabaseMetaData.java tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoMetaDataResultSet.java tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyServerBase.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.8.1-build #97 (See https://builds.apache.org/job/Tajo-0.8.1-build/97/)
        TAJO-812: Some methods of TajoDatabaseMetaData should result in an empty tuple list instead of SQLFeatureNotSupportedException. (hyunsik: rev db3fa4f3e95925268f096674e94ddd9f162424f2)

        • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoPreparedStatement.java
        • tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyClientBase.java
        • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDatabaseMetaData.java
        • pom.xml
        • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoMetaDataResultSet.java
        • tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java
        • tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyServerBase.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.8.1-build #97 (See https://builds.apache.org/job/Tajo-0.8.1-build/97/ ) TAJO-812 : Some methods of TajoDatabaseMetaData should result in an empty tuple list instead of SQLFeatureNotSupportedException. (hyunsik: rev db3fa4f3e95925268f096674e94ddd9f162424f2) tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoPreparedStatement.java tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyClientBase.java tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDatabaseMetaData.java pom.xml tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoMetaDataResultSet.java tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyServerBase.java
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master and 0.8.1 branch.

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master and 0.8.1 branch.

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development