Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-807

Implement Round(numeric, int) function.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      round to s decimal places
      ex) select round(42.4382, 2); --> 42.44
      select round(round(425, 2) --> 425.0

      1. TAJO-807.patch
        4 kB
        Seungun Choe
      2. TAJO-807.patch
        5 kB
        Seungun Choe

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #218 (See https://builds.apache.org/job/Tajo-master-build/218/)
        TAJO-807: Implement Round(numeric, int) function. (Seungun Choe via hyunsik) (hyunsik: rev ad53ffeac5ee5c6b9f5b33ca45bb0c38490a8b95)

        • tajo-core/src/test/java/org/apache/tajo/engine/function/TestMathFunctions.java
        • tajo-core/src/main/java/org/apache/tajo/engine/function/math/RoundFloat8.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #218 (See https://builds.apache.org/job/Tajo-master-build/218/ ) TAJO-807 : Implement Round(numeric, int) function. (Seungun Choe via hyunsik) (hyunsik: rev ad53ffeac5ee5c6b9f5b33ca45bb0c38490a8b95) tajo-core/src/test/java/org/apache/tajo/engine/function/TestMathFunctions.java tajo-core/src/main/java/org/apache/tajo/engine/function/math/RoundFloat8.java CHANGES
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master branch. Thank you for your contribution.

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master branch. Thank you for your contribution.
        Hide
        hyunsik Hyunsik Choi added a comment -

        +1

        Show
        hyunsik Hyunsik Choi added a comment - +1
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12644078/TAJO-807.patch
        against master revision f1ead5e.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 184 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/418//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/418//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/418//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12644078/TAJO-807.patch against master revision f1ead5e. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 184 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/418//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/418//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/418//console This message is automatically generated.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12642601/TAJO-807.patch
        against master revision d5347c6.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 189 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/408//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/408//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/408//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12642601/TAJO-807.patch against master revision d5347c6. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 189 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/408//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/408//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/408//console This message is automatically generated.
        Hide
        seungunchoe Seungun Choe added a comment -

        https://reviews.apache.org/r/20878/
        Please review my patch

        Show
        seungunchoe Seungun Choe added a comment - https://reviews.apache.org/r/20878/ Please review my patch

          People

          • Assignee:
            seungunchoe Seungun Choe
            Reporter:
            seungunchoe Seungun Choe
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development