Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-792

Insert table with a qualified target table name can cause error.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0, 0.8.1
    • Component/s: None
    • Labels:
      None

      Description

      I made a table1 that is csv file format.
      And I create other table2 that is rc file format.

      insert overwrite into "table2" select * from "db"."table1" (o)
      insert overwrite into "db"."table2" select * from "db"."table1" (x)
      

      Recently days, Tajo was added rule [select * from "db"."table_name"].
      But, I think insert rule was not added.

      1. TAJO-792.patch
        4 kB
        Hyoungjun Kim

        Activity

        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12642613/TAJO-792.patch
        against master revision d5347c6.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 189 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/409//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/409//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/409//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12642613/TAJO-792.patch against master revision d5347c6. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 189 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/409//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/409//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/409//console This message is automatically generated.
        Hide
        hjkim Hyoungjun Kim added a comment -

        I create a review request.
        https://reviews.apache.org/r/20886/

        Show
        hjkim Hyoungjun Kim added a comment - I create a review request. https://reviews.apache.org/r/20886/
        Hide
        hyunsik Hyunsik Choi added a comment -

        +1

        The patch looks good to me. It also includes one unit test to verify the bug fix.

        Show
        hyunsik Hyunsik Choi added a comment - +1 The patch looks good to me. It also includes one unit test to verify the bug fix.
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master and branch-0.8.1.

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master and branch-0.8.1.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #211 (See https://builds.apache.org/job/Tajo-master-build/211/)
        TAJO-792: Insert table error with database name. (Hyoungjun Kim via hyunsik) (hyunsik: rev 08bcc2d8282fd3b066ed37eafc2c2b142227015d)

        • tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestInsertQuery.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java
        • CHANGES
        • tajo-core/src/test/resources/queries/TestInsertQuery/testInsertOverwriteWithDatabase.sql
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #211 (See https://builds.apache.org/job/Tajo-master-build/211/ ) TAJO-792 : Insert table error with database name. (Hyoungjun Kim via hyunsik) (hyunsik: rev 08bcc2d8282fd3b066ed37eafc2c2b142227015d) tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestInsertQuery.java tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java CHANGES tajo-core/src/test/resources/queries/TestInsertQuery/testInsertOverwriteWithDatabase.sql

          People

          • Assignee:
            hjkim Hyoungjun Kim
            Reporter:
            seungunchoe Seungun Choe
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development