Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      See title.

      default> select add_days(to_date('2013-12-30'), 10);
      ?add_days
      -------------------------------
      2014-01-09
      
      default> select add_days(to_date('2013-12-22'), -2);
      ?add_days
      -------------------------------
      2013-12-20
      
      1. TAJO-791.patch
        6 kB
        Hyoungjun Kim

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #211 (See https://builds.apache.org/job/Tajo-master-build/211/)
        TAJO-791: Implements ADD_DAYS() function (Hyoungjun Kim via hyunsik) (hyunsik: rev 86e09d7ece7f34e455fefcf9731184f5aa8e41ec)

        • tajo-common/src/main/java/org/apache/tajo/datum/IntervalDatum.java
        • tajo-core/src/test/java/org/apache/tajo/engine/function/TestDateTimeFunctions.java
        • tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/AddDays.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #211 (See https://builds.apache.org/job/Tajo-master-build/211/ ) TAJO-791 : Implements ADD_DAYS() function (Hyoungjun Kim via hyunsik) (hyunsik: rev 86e09d7ece7f34e455fefcf9731184f5aa8e41ec) tajo-common/src/main/java/org/apache/tajo/datum/IntervalDatum.java tajo-core/src/test/java/org/apache/tajo/engine/function/TestDateTimeFunctions.java tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/AddDays.java CHANGES
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master branch.

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master branch.
        Hide
        hyunsik Hyunsik Choi added a comment -

        +1

        The patch looks good to me.

        Show
        hyunsik Hyunsik Choi added a comment - +1 The patch looks good to me.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12642591/TAJO-791.patch
        against master revision 6200311.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 189 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-common tajo-core.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/405//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/405//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/405//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12642591/TAJO-791.patch against master revision 6200311. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 189 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-common tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/405//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/405//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/405//console This message is automatically generated.

          People

          • Assignee:
            hjkim Hyoungjun Kim
            Reporter:
            hjkim Hyoungjun Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development