Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-786

TajoDataMetaDatabase::getSchemas creates invalid MetaDataTuple

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0, 0.9.0
    • Component/s: JDBC Driver
    • Labels:
      None

      Description

      The parameter of MetaDataTuple should be 2 instead of 1.

      MetaDataTuple tuple = new MetaDataTuple(1);
      tuple.put(0, new TextDatum(DEFAULT_SCHEMA_NAME));
      tuple.put(1, new TextDatum(databaseName));
      
      1. TAJO-786_2.patch
        23 kB
        Hyunsik Choi
      2. TAJO-786.patch
        22 kB
        Hyunsik Choi

        Activity

        Hide
        hyunsik Hyunsik Choi added a comment -

        This patch fixes the bug. In addition, it adds more unit tests for TajoDataMetaDatabase::getColumn() method.

        Show
        hyunsik Hyunsik Choi added a comment - This patch fixes the bug. In addition, it adds more unit tests for TajoDataMetaDatabase::getColumn() method.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12641178/TAJO-786.patch
        against master revision cbe1d6e.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 7 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 200 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core tajo-jdbc.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/369//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/369//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/369//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-jdbc.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/369//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12641178/TAJO-786.patch against master revision cbe1d6e. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 200 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core tajo-jdbc. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/369//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/369//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/369//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-jdbc.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/369//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment - - edited

        The second patch fixes the bug where TajoDataMetaDatabase::getColumns() misses the column partition columns.

        Show
        hyunsik Hyunsik Choi added a comment - - edited The second patch fixes the bug where TajoDataMetaDatabase::getColumns() misses the column partition columns.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12641188/TAJO-786_2.patch
        against master revision cbe1d6e.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 7 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 200 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core tajo-jdbc.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/370//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/370//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/370//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-jdbc.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/370//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12641188/TAJO-786_2.patch against master revision cbe1d6e. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 200 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core tajo-jdbc. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/370//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/370//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/370//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-jdbc.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/370//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        The latest patch got +1 on RB. I'll commit it to master and 0.8.0. Thanks!

        Show
        hyunsik Hyunsik Choi added a comment - The latest patch got +1 on RB. I'll commit it to master and 0.8.0. Thanks!
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to 0.8.0 to master. Thanks for quick review.

        Show
        hyunsik Hyunsik Choi added a comment - committed it to 0.8.0 to master. Thanks for quick review.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #194 (See https://builds.apache.org/job/Tajo-master-build/194/)
        TAJO-786: TajoDataMetaDatabase::getSchemas creates invalid MetaDataTuple. (hyunsik: rev 9cd8dac357a2d8c33943211ca18f3837a293c489)

        • tajo-core/src/test/resources/results/TestTajoDatabaseMetaData/getSchemas2.result
        • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDriver.java
        • tajo-core/src/test/java/org/apache/tajo/jdbc/TestTajoDatabaseMetaData.java
        • tajo-core/src/test/resources/results/TestTajoDatabaseMetaData/getTableTypes.result
        • tajo-core/src/test/resources/results/TestTajoDatabaseMetaData/getTables2.result
        • tajo-core/src/test/resources/results/TestTajoDatabaseMetaData/getSchemas1.result
        • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDatabaseMetaData.java
        • CHANGES.txt
        • tajo-core/src/test/java/org/apache/tajo/jdbc/TestTajoJdbc.java
        • tajo-core/src/test/resources/results/TestTajoDatabaseMetaData/getTables1.result
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #194 (See https://builds.apache.org/job/Tajo-master-build/194/ ) TAJO-786 : TajoDataMetaDatabase::getSchemas creates invalid MetaDataTuple. (hyunsik: rev 9cd8dac357a2d8c33943211ca18f3837a293c489) tajo-core/src/test/resources/results/TestTajoDatabaseMetaData/getSchemas2.result tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDriver.java tajo-core/src/test/java/org/apache/tajo/jdbc/TestTajoDatabaseMetaData.java tajo-core/src/test/resources/results/TestTajoDatabaseMetaData/getTableTypes.result tajo-core/src/test/resources/results/TestTajoDatabaseMetaData/getTables2.result tajo-core/src/test/resources/results/TestTajoDatabaseMetaData/getSchemas1.result tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDatabaseMetaData.java CHANGES.txt tajo-core/src/test/java/org/apache/tajo/jdbc/TestTajoJdbc.java tajo-core/src/test/resources/results/TestTajoDatabaseMetaData/getTables1.result
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.8.0-build #87 (See https://builds.apache.org/job/Tajo-0.8.0-build/87/)
        TAJO-786: TajoDataMetaDatabase::getSchemas creates invalid MetaDataTuple. (hyunsik: rev 655c2c058bc6cd9cd6f68d6b9fe3ac037e0f1db8)

        • tajo-core/src/test/resources/results/TestTajoDatabaseMetaData/getSchemas1.result
        • tajo-core/src/test/java/org/apache/tajo/jdbc/TestTajoJdbc.java
        • tajo-core/src/test/resources/results/TestTajoDatabaseMetaData/getSchemas2.result
        • tajo-core/src/test/resources/results/TestTajoDatabaseMetaData/getTables1.result
        • CHANGES.txt
        • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDatabaseMetaData.java
        • tajo-core/src/test/java/org/apache/tajo/jdbc/TestTajoDatabaseMetaData.java
        • tajo-core/src/test/resources/results/TestTajoDatabaseMetaData/getTableTypes.result
        • tajo-core/src/test/resources/results/TestTajoDatabaseMetaData/getTables2.result
        • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDriver.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.8.0-build #87 (See https://builds.apache.org/job/Tajo-0.8.0-build/87/ ) TAJO-786 : TajoDataMetaDatabase::getSchemas creates invalid MetaDataTuple. (hyunsik: rev 655c2c058bc6cd9cd6f68d6b9fe3ac037e0f1db8) tajo-core/src/test/resources/results/TestTajoDatabaseMetaData/getSchemas1.result tajo-core/src/test/java/org/apache/tajo/jdbc/TestTajoJdbc.java tajo-core/src/test/resources/results/TestTajoDatabaseMetaData/getSchemas2.result tajo-core/src/test/resources/results/TestTajoDatabaseMetaData/getTables1.result CHANGES.txt tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDatabaseMetaData.java tajo-core/src/test/java/org/apache/tajo/jdbc/TestTajoDatabaseMetaData.java tajo-core/src/test/resources/results/TestTajoDatabaseMetaData/getTableTypes.result tajo-core/src/test/resources/results/TestTajoDatabaseMetaData/getTables2.result tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDriver.java

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development