Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-784

Improve TpchTestBase to be more general.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently, tajo provides TpchTestBase for TPC-H benchmark. But it is inefficient because it uses all queries which was written in java code. Other test cases use queries which was written in query file. Thus we should refactor it to extend QueryTestCaseBase. In addition, we need to add more TPC-H queries.

      1. TAJO-784.patch
        123 kB
        Jaehwa Jung

        Activity

        Hide
        blrunner Jaehwa Jung added a comment -

        Created a review request against branch master in reviewboard.
        https://reviews.apache.org/r/21719/

        Show
        blrunner Jaehwa Jung added a comment - Created a review request against branch master in reviewboard. https://reviews.apache.org/r/21719/
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12645836/TAJO-784.patch
        against master revision d0528d1.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 42 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 195 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/430//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/430//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/430//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12645836/TAJO-784.patch against master revision d0528d1. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 42 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 195 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/430//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/430//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/430//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment - - edited

        I think that this issue needs to be scheduled to only 0.9. 0.8.1 will be a minor release for bug fix.

        Show
        hyunsik Hyunsik Choi added a comment - - edited I think that this issue needs to be scheduled to only 0.9. 0.8.1 will be a minor release for bug fix.
        Hide
        blrunner Jaehwa Jung added a comment -

        Hi Hyunsik Choi

        I agree with you.
        After releasing 0.8.1, I'll rebase the patch against master branch.

        Cheers,
        Jaehwa

        Show
        blrunner Jaehwa Jung added a comment - Hi Hyunsik Choi I agree with you. After releasing 0.8.1, I'll rebase the patch against master branch. Cheers, Jaehwa
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12645836/TAJO-784.patch
        against master revision 7510f88.

        -1 patch. The patch command could not apply the patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/504//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12645836/TAJO-784.patch against master revision 7510f88. -1 patch. The patch command could not apply the patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/504//console This message is automatically generated.
        Hide
        blrunner Jaehwa Jung added a comment -

        This patch is too old. I'll try to find a better way for this issue later.

        Show
        blrunner Jaehwa Jung added a comment - This patch is too old. I'll try to find a better way for this issue later.

          People

          • Assignee:
            blrunner Jaehwa Jung
            Reporter:
            blrunner Jaehwa Jung
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development