Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      Now, we are working on new scheduler. The obsolete yarn-related part using resource manager is not used in the current source and may be an obstacle for our ongoing work. So, we need to remove the part using yarn resource manager. Later, we will recover this code when it is needed.

      1. TAJO-783_2.patch
        62 kB
        Hyunsik Choi
      2. TAJO-783.patch
        61 kB
        Hyunsik Choi

        Activity

        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12641045/TAJO-783.patch
        against master revision cbe1d6e.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 191 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/367//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/367//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/367//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12641045/TAJO-783.patch against master revision cbe1d6e. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 191 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/367//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/367//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/367//console This message is automatically generated.
        Hide
        jhkim Jinho Kim added a comment -

        Hyunsik Choi
        Can you remove unused dependencies ?

        • hadoop-yarn-client
        • hadoop-mapreduce-client-core
        • hadoop-yarn-server-tests
        Show
        jhkim Jinho Kim added a comment - Hyunsik Choi Can you remove unused dependencies ? hadoop-yarn-client hadoop-mapreduce-client-core hadoop-yarn-server-tests
        Hide
        hyunsik Hyunsik Choi added a comment -

        Jinho,

        Thank you for your comment. I uploaded the second patch which reflects your comments. It works well.

        Show
        hyunsik Hyunsik Choi added a comment - Jinho, Thank you for your comment. I uploaded the second patch which reflects your comments. It works well.
        Hide
        jhkim Jinho Kim added a comment -

        +1 for the patch.
        Thank you!!

        Show
        jhkim Jinho Kim added a comment - +1 for the patch. Thank you!!
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12641189/TAJO-783_2.patch
        against master revision cbe1d6e.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 191 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core tajo-maven-plugins.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/371//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/371//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/371//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12641189/TAJO-783_2.patch against master revision cbe1d6e. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 191 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core tajo-maven-plugins. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/371//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/371//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/371//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        Thanks. committed it to master.

        Show
        hyunsik Hyunsik Choi added a comment - Thanks. committed it to master.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #194 (See https://builds.apache.org/job/Tajo-master-build/194/)
        TAJO-783: Remove yarn-related code from tajo-core. (hyunsik) (hyunsik: rev 882f92c6d74818eee7f086a7c5f9467b44101abf)

        • tajo-core/src/main/java/org/apache/tajo/master/LazyTaskScheduler.java
        • tajo-maven-plugins/pom.xml
        • tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java
        • tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java
        • CHANGES.txt
        • tajo-core/src/main/java/org/apache/tajo/master/YarnTaskRunnerLauncherImpl.java
        • tajo-core/pom.xml
        • tajo-core/src/main/java/org/apache/tajo/master/DefaultTaskScheduler.java
        • tajo-core/src/main/java/org/apache/tajo/worker/YarnResourceAllocator.java
        • tajo-core/src/main/java/org/apache/tajo/master/rm/YarnTajoResourceManager.java
        • tajo-project/pom.xml
        • tajo-core/src/main/java/org/apache/tajo/master/rm/YarnRMContainerAllocator.java
        • tajo-core/src/main/java/org/apache/tajo/master/YarnContainerProxy.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #194 (See https://builds.apache.org/job/Tajo-master-build/194/ ) TAJO-783 : Remove yarn-related code from tajo-core. (hyunsik) (hyunsik: rev 882f92c6d74818eee7f086a7c5f9467b44101abf) tajo-core/src/main/java/org/apache/tajo/master/LazyTaskScheduler.java tajo-maven-plugins/pom.xml tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java CHANGES.txt tajo-core/src/main/java/org/apache/tajo/master/YarnTaskRunnerLauncherImpl.java tajo-core/pom.xml tajo-core/src/main/java/org/apache/tajo/master/DefaultTaskScheduler.java tajo-core/src/main/java/org/apache/tajo/worker/YarnResourceAllocator.java tajo-core/src/main/java/org/apache/tajo/master/rm/YarnTajoResourceManager.java tajo-project/pom.xml tajo-core/src/main/java/org/apache/tajo/master/rm/YarnRMContainerAllocator.java tajo-core/src/main/java/org/apache/tajo/master/YarnContainerProxy.java

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development