Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-759

Fix findbug errors added recently.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0, 0.9.0
    • Fix Version/s: 0.8.0, 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      Recently, some findbug errors are included in the source tree. Currently, It causes the failure of findbug test in jenkins. This patch fixes the findbug errors to disturb our pre-commit test.

      1. TAJO-759.patch
        27 kB
        Hyunsik Choi

        Activity

        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12640041/TAJO-759.patch
        against master revision 8982684.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 200 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-common tajo-catalog/tajo-catalog-server tajo-client tajo-common tajo-core/tajo-core-backend tajo-jdbc tajo-rpc tajo-storage.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/338//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/338//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-jdbc.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/338//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/338//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12640041/TAJO-759.patch against master revision 8982684. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 200 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-common tajo-catalog/tajo-catalog-server tajo-client tajo-common tajo-core/tajo-core-backend tajo-jdbc tajo-rpc tajo-storage. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/338//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/338//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-jdbc.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/338//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/338//console This message is automatically generated.
        Hide
        jhkim Jinho Kim added a comment -

        +1
        Ship it!

        Show
        jhkim Jinho Kim added a comment - +1 Ship it!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #172 (See https://builds.apache.org/job/Tajo-master-build/172/)
        TAJO-759: Fix findbug errors added recently. (hyunsik: rev 06a14960ee74d1bdd4dddf78955928b61563ff6f)

        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/GroupbyNode.java
        • tajo-common/src/main/java/org/apache/tajo/datum/TimestampDatum.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java
        • tajo-common/src/main/java/org/apache/tajo/datum/TimeDatum.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/Target.java
        • tajo-common/src/main/java/org/apache/tajo/common/type/IPv4.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/trevni/TrevniAppender.java
        • tajo-common/src/main/java/org/apache/tajo/datum/DateDatum.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Column.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/IndexDesc.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/NoSuchColumnException.java
        • tajo-client/src/main/java/org/apache/tajo/client/TajoDump.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
        • tajo-common/src/main/java/org/apache/tajo/datum/Inet4Datum.java
        • tajo-common/src/main/java/org/apache/tajo/datum/CharDatum.java
        • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoPreparedStatement.java
        • tajo-rpc/src/main/java/org/apache/tajo/rpc/ServerCallable.java
        • CHANGES.txt
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/ColumnStats.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/MemoryUtil.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/SortSpec.java
        • tajo-project/pom.xml
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/TableStats.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/FieldEval.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/TupleRange.java
        • tajo-common/src/main/java/org/apache/tajo/datum/TextDatum.java
        • tajo-common/src/main/java/org/apache/tajo/datum/DatumFactory.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/index/bst/BSTIndex.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #172 (See https://builds.apache.org/job/Tajo-master-build/172/ ) TAJO-759 : Fix findbug errors added recently. (hyunsik: rev 06a14960ee74d1bdd4dddf78955928b61563ff6f) tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/GroupbyNode.java tajo-common/src/main/java/org/apache/tajo/datum/TimestampDatum.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java tajo-common/src/main/java/org/apache/tajo/datum/TimeDatum.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/Target.java tajo-common/src/main/java/org/apache/tajo/common/type/IPv4.java tajo-storage/src/main/java/org/apache/tajo/storage/trevni/TrevniAppender.java tajo-common/src/main/java/org/apache/tajo/datum/DateDatum.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Column.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/IndexDesc.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/NoSuchColumnException.java tajo-client/src/main/java/org/apache/tajo/client/TajoDump.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java tajo-common/src/main/java/org/apache/tajo/datum/Inet4Datum.java tajo-common/src/main/java/org/apache/tajo/datum/CharDatum.java tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoPreparedStatement.java tajo-rpc/src/main/java/org/apache/tajo/rpc/ServerCallable.java CHANGES.txt tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/ColumnStats.java tajo-storage/src/main/java/org/apache/tajo/storage/MemoryUtil.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/SortSpec.java tajo-project/pom.xml tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/TableStats.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/FieldEval.java tajo-storage/src/main/java/org/apache/tajo/storage/TupleRange.java tajo-common/src/main/java/org/apache/tajo/datum/TextDatum.java tajo-common/src/main/java/org/apache/tajo/datum/DatumFactory.java tajo-storage/src/main/java/org/apache/tajo/storage/index/bst/BSTIndex.java
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed. Thanks for quick review.

        Show
        hyunsik Hyunsik Choi added a comment - committed. Thanks for quick review.
        Hide
        hyunsik Hyunsik Choi added a comment -

        There are many findbug errors in tajo-core. We'll fix them later in other jira issues.

        Show
        hyunsik Hyunsik Choi added a comment - There are many findbug errors in tajo-core. We'll fix them later in other jira issues.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.8.0-build #71 (See https://builds.apache.org/job/Tajo-0.8.0-build/71/)
        TAJO-759: Fix findbug errors added recently. (hyunsik: rev 031d5dd6596e3a6f22099bc599fdf380b841f605)

        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/ColumnStats.java
        • tajo-rpc/src/main/java/org/apache/tajo/rpc/ServerCallable.java
        • tajo-common/src/main/java/org/apache/tajo/common/type/IPv4.java
        • tajo-common/src/main/java/org/apache/tajo/datum/DateDatum.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/index/bst/BSTIndex.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/NoSuchColumnException.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/GroupbyNode.java
        • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoPreparedStatement.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/MemoryUtil.java
        • tajo-common/src/main/java/org/apache/tajo/datum/TimestampDatum.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/Target.java
        • tajo-common/src/main/java/org/apache/tajo/datum/CharDatum.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/FieldEval.java
        • tajo-common/src/main/java/org/apache/tajo/datum/TimeDatum.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/trevni/TrevniAppender.java
        • tajo-common/src/main/java/org/apache/tajo/datum/Inet4Datum.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/TableStats.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/TupleRange.java
        • tajo-client/src/main/java/org/apache/tajo/client/TajoDump.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/SortSpec.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/IndexDesc.java
        • tajo-project/pom.xml
        • tajo-common/src/main/java/org/apache/tajo/datum/TextDatum.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Column.java
        • tajo-common/src/main/java/org/apache/tajo/datum/DatumFactory.java
        • CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.8.0-build #71 (See https://builds.apache.org/job/Tajo-0.8.0-build/71/ ) TAJO-759 : Fix findbug errors added recently. (hyunsik: rev 031d5dd6596e3a6f22099bc599fdf380b841f605) tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/ColumnStats.java tajo-rpc/src/main/java/org/apache/tajo/rpc/ServerCallable.java tajo-common/src/main/java/org/apache/tajo/common/type/IPv4.java tajo-common/src/main/java/org/apache/tajo/datum/DateDatum.java tajo-storage/src/main/java/org/apache/tajo/storage/index/bst/BSTIndex.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/NoSuchColumnException.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/GroupbyNode.java tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoPreparedStatement.java tajo-storage/src/main/java/org/apache/tajo/storage/MemoryUtil.java tajo-common/src/main/java/org/apache/tajo/datum/TimestampDatum.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/Target.java tajo-common/src/main/java/org/apache/tajo/datum/CharDatum.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/FieldEval.java tajo-common/src/main/java/org/apache/tajo/datum/TimeDatum.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java tajo-storage/src/main/java/org/apache/tajo/storage/trevni/TrevniAppender.java tajo-common/src/main/java/org/apache/tajo/datum/Inet4Datum.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/TableStats.java tajo-storage/src/main/java/org/apache/tajo/storage/TupleRange.java tajo-client/src/main/java/org/apache/tajo/client/TajoDump.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/SortSpec.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/IndexDesc.java tajo-project/pom.xml tajo-common/src/main/java/org/apache/tajo/datum/TextDatum.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Column.java tajo-common/src/main/java/org/apache/tajo/datum/DatumFactory.java CHANGES.txt

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development