Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-735

Remove multiple SLF4J bindings message.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0, 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      See title. When run tajo cli, next message is shown.

      SLF4J: Class path contains multiple SLF4J bindings.
      SLF4J: Found binding in [jar:file:/home/hdfs/hadoop-2.2.0/share/hadoop/common/lib/slf4j-log4j12-1.7.5.jar!/org/slf4j/impl/StaticLoggerBinder.class]
      SLF4J: Found binding in [jar:file:/home/tajo/tajo-0.8.0-SNAPSHOT/lib/slf4j-log4j12-1.7.5.jar!/org/slf4j/impl/StaticLoggerBinder.class]
      SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
      SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
      

      This is because hadoop and tajo have slf4j library.

      1. TAJO-735.patch
        0.4 kB
        Hyoungjun Kim

        Issue Links

          Activity

          Hide
          hjkim Hyoungjun Kim added a comment -

          Added filtering slf4j jar file in BIN/tajo script.

          Show
          hjkim Hyoungjun Kim added a comment - Added filtering slf4j jar file in BIN/tajo script.
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12638450/TAJO-735.patch
          against master revision e036ea3.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-dist.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/304//testReport/
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/304//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12638450/TAJO-735.patch against master revision e036ea3. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-dist. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/304//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/304//console This message is automatically generated.
          Hide
          blrunner Jaehwa Jung added a comment - - edited

          Hi Hyoungjun.

          Thank you for your contribution. Unfortunately, there is a duplicated issue (TAJO-67).
          Could you upload your patch at the existing issue?

          Cheers
          Jaehwa

          Show
          blrunner Jaehwa Jung added a comment - - edited Hi Hyoungjun. Thank you for your contribution. Unfortunately, there is a duplicated issue ( TAJO-67 ). Could you upload your patch at the existing issue? Cheers Jaehwa
          Hide
          hyunsik Hyunsik Choi added a comment -

          This is a duplicated issue to TAJO-67. Since the patch was submitted to here, I closed TAJO-67. Hyoungjun does not need to resubmit your patch.

          Show
          hyunsik Hyunsik Choi added a comment - This is a duplicated issue to TAJO-67 . Since the patch was submitted to here, I closed TAJO-67 . Hyoungjun does not need to resubmit your patch.
          Hide
          hyunsik Hyunsik Choi added a comment -

          +1

          tsql becomes more neat Many thanks.

          Show
          hyunsik Hyunsik Choi added a comment - +1 tsql becomes more neat Many thanks.
          Hide
          blrunner Jaehwa Jung added a comment -

          +1

          Hyunsik, thank you for your comment.

          I've tested the patch successfully on my local cluster.

          Show
          blrunner Jaehwa Jung added a comment - +1 Hyunsik, thank you for your comment. I've tested the patch successfully on my local cluster.
          Hide
          hyunsik Hyunsik Choi added a comment -

          Thank you Jaehwa for finding the duplicated issue and your testing. I've committed it to master and branch-0.8.0.

          Show
          hyunsik Hyunsik Choi added a comment - Thank you Jaehwa for finding the duplicated issue and your testing. I've committed it to master and branch-0.8.0.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #155 (See https://builds.apache.org/job/Tajo-master-build/155/)
          TAJO-735: Remove multiple SLF4J bindings message. (hyoungjunkim via hyunsik) (hyunsik: rev dd7d041acecfc8bb7d9e80d6a808420807d50b21)

          • CHANGES.txt
          • tajo-dist/src/main/bin/tajo
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #155 (See https://builds.apache.org/job/Tajo-master-build/155/ ) TAJO-735 : Remove multiple SLF4J bindings message. (hyoungjunkim via hyunsik) (hyunsik: rev dd7d041acecfc8bb7d9e80d6a808420807d50b21) CHANGES.txt tajo-dist/src/main/bin/tajo
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-0.8.0-build #56 (See https://builds.apache.org/job/Tajo-0.8.0-build/56/)
          TAJO-735: Remove multiple SLF4J bindings message. (hyoungjunkim via hyunsik) (hyunsik: rev 4dc22f76039b77eccf434094d2f3d65433814721)

          • tajo-dist/src/main/bin/tajo
          • CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.8.0-build #56 (See https://builds.apache.org/job/Tajo-0.8.0-build/56/ ) TAJO-735 : Remove multiple SLF4J bindings message. (hyoungjunkim via hyunsik) (hyunsik: rev 4dc22f76039b77eccf434094d2f3d65433814721) tajo-dist/src/main/bin/tajo CHANGES.txt

            People

            • Assignee:
              hjkim Hyoungjun Kim
              Reporter:
              hjkim Hyoungjun Kim
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development