Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-718

A group-by clause with the same columns but aliased causes planning error.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0, 0.9.0
    • Fix Version/s: 0.8.0, 0.9.0
    • Component/s: Planner/Optimizer
    • Labels:
      None

      Description

      The reproduction SQL statement is as follows:

      SELECT
        "lineitem".l_orderkey AS l_orderkey,
        "lineitem".l_orderkey AS l_orderkey1,
        COUNT ("lineitem".l_orderkey) AS T57801e5322bc50
      FROM
        "lineitem"
      GROUP BY
        l_orderkey, l_orderkey1
      ORDER BY
        l_orderkey, l_orderkey1;
      
      1. TAJO-718.patch
        9 kB
        Hyunsik Choi

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.8.0-build #47 (See https://builds.apache.org/job/Tajo-0.8.0-build/47/)
        TAJO-718: A group-by clause with the same columns but aliased causes planning error. (hyunsik) (hyunsik: rev 50d433f53f1de94097e2012e32338cf4c81e33fd)

        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/rewrite/ProjectionPushDownRule.java
        • tajo-core/tajo-core-backend/src/test/resources/queries/TestCaseByCases/testTAJO718Case.sql
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprNormalizer.java
        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/test/resources/results/TestCaseByCases/testTAJO718Case.result
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCaseByCases.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.8.0-build #47 (See https://builds.apache.org/job/Tajo-0.8.0-build/47/ ) TAJO-718 : A group-by clause with the same columns but aliased causes planning error. (hyunsik) (hyunsik: rev 50d433f53f1de94097e2012e32338cf4c81e33fd) tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/rewrite/ProjectionPushDownRule.java tajo-core/tajo-core-backend/src/test/resources/queries/TestCaseByCases/testTAJO718Case.sql tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprNormalizer.java CHANGES.txt tajo-core/tajo-core-backend/src/test/resources/results/TestCaseByCases/testTAJO718Case.result tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCaseByCases.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #144 (See https://builds.apache.org/job/Tajo-master-build/144/)
        TAJO-718: A group-by clause with the same columns but aliased causes planning error. (Add missed test query files) (hyunsik: rev 5d94b031bad1505af42aacc3a89435953ff73eec)

        • tajo-core/tajo-core-backend/src/test/resources/results/TestCaseByCases/testTAJO718Case.result
        • tajo-core/tajo-core-backend/src/test/resources/queries/TestCaseByCases/testTAJO718Case.sql
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #144 (See https://builds.apache.org/job/Tajo-master-build/144/ ) TAJO-718 : A group-by clause with the same columns but aliased causes planning error. (Add missed test query files) (hyunsik: rev 5d94b031bad1505af42aacc3a89435953ff73eec) tajo-core/tajo-core-backend/src/test/resources/results/TestCaseByCases/testTAJO718Case.result tajo-core/tajo-core-backend/src/test/resources/queries/TestCaseByCases/testTAJO718Case.sql
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master and branch-0.8.0.

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master and branch-0.8.0.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-build #143 (See https://builds.apache.org/job/Tajo-master-build/143/)
        TAJO-718: A group-by clause with the same columns but aliased causes planning error. (hyunsik) (hyunsik: rev 8c1f0404240bad92a7f48e858d9dc28a17ccc20f)

        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCaseByCases.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprNormalizer.java
        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/rewrite/ProjectionPushDownRule.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #143 (See https://builds.apache.org/job/Tajo-master-build/143/ ) TAJO-718 : A group-by clause with the same columns but aliased causes planning error. (hyunsik) (hyunsik: rev 8c1f0404240bad92a7f48e858d9dc28a17ccc20f) tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCaseByCases.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprNormalizer.java CHANGES.txt tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/rewrite/ProjectionPushDownRule.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12637129/TAJO-718.patch
        against master revision 9d00f9f.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 196 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/271//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/271//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/271//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12637129/TAJO-718.patch against master revision 9d00f9f. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 196 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/271//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/271//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/271//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment - - edited

        Created a review request against branch master in reviewboard.
        https://reviews.apache.org/r/19721

        Show
        hyunsik Hyunsik Choi added a comment - - edited Created a review request against branch master in reviewboard. https://reviews.apache.org/r/19721

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development