Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-717

Improve file splitting for large number of splits

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0, 0.9.0
    • Component/s: Storage
    • Labels:
      None

      Description

      In currently, The storageManager invoke the getFileBlockStorageLocations() per input path, it occurred too many rpc to the associated datanodes

      • reducing remote call to datanode
      1. TAJO-717_20140404_14:07:24.patch
        22 kB
        Jinho Kim
      2. TAJO-717_20140407_17:28:49.patch
        26 kB
        Jinho Kim
      3. TAJO-717.patch
        25 kB
        Jinho Kim

        Activity

        Hide
        jhkim Jinho Kim added a comment -

        Created a review request against branch master in reviewboard
        https://reviews.apache.org/r/19821/

        Show
        jhkim Jinho Kim added a comment - Created a review request against branch master in reviewboard https://reviews.apache.org/r/19821/
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12637622/TAJO-717.patch
        against master revision bbbf21d.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 197 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend tajo-storage.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/284//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/284//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/284//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12637622/TAJO-717.patch against master revision bbbf21d. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 197 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend tajo-storage. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/284//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/284//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/284//console This message is automatically generated.
        Hide
        blrunner Jaehwa Jung added a comment -

        Hi Jinho.

        Could you rebase the patch against the recent revision?

        Cheers
        Jaehwa

        Show
        blrunner Jaehwa Jung added a comment - Hi Jinho. Could you rebase the patch against the recent revision? Cheers Jaehwa
        Hide
        jhkim Jinho Kim added a comment -

        Updated the review request against branch master in reviewboard
        https://reviews.apache.org/r/19821/

        Show
        jhkim Jinho Kim added a comment - Updated the review request against branch master in reviewboard https://reviews.apache.org/r/19821/
        Hide
        jhkim Jinho Kim added a comment -

        Thanks, Jaehwa
        I've rebased on master

        Show
        jhkim Jinho Kim added a comment - Thanks, Jaehwa I've rebased on master
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12638624/TAJO-717_20140404_14%3A07%3A24.patch
        against master revision dd7d041.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 198 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend tajo-storage.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/305//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/305//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/305//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12638624/TAJO-717_20140404_14%3A07%3A24.patch against master revision dd7d041. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 198 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend tajo-storage. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/305//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/305//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/305//console This message is automatically generated.
        Hide
        jhkim Jinho Kim added a comment -

        Updated the review request against branch master in reviewboard

        Show
        jhkim Jinho Kim added a comment - Updated the review request against branch master in reviewboard
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12638951/TAJO-717_20140407_17%3A28%3A49.patch
        against master revision 5b0cf0d.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 201 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend tajo-storage.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/310//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/310//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/310//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12638951/TAJO-717_20140407_17%3A28%3A49.patch against master revision 5b0cf0d. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 201 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend tajo-storage. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/310//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/310//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/310//console This message is automatically generated.
        Hide
        jhkim Jinho Kim added a comment -

        This issue got +1 from reviewboard.
        I've just committed it to both master branch and branch-0.8.0.

        Show
        jhkim Jinho Kim added a comment - This issue got +1 from reviewboard. I've just committed it to both master branch and branch-0.8.0.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #164 (See https://builds.apache.org/job/Tajo-master-build/164/)
        TAJO-717: Improve file splitting for large number of splits. (jinho) (jinossy: rev d99bd085e4f02bd11a9133c6bef8942b9dc27723)

        • tajo-storage/src/main/java/org/apache/tajo/storage/rcfile/RCFile.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/AbstractStorageManager.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java
        • CHANGES.txt
        • tajo-storage/pom.xml
        • tajo-storage/src/test/java/org/apache/tajo/storage/TestStorageManager.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/DefaultTaskScheduler.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/fragment/FileFragment.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #164 (See https://builds.apache.org/job/Tajo-master-build/164/ ) TAJO-717 : Improve file splitting for large number of splits. (jinho) (jinossy: rev d99bd085e4f02bd11a9133c6bef8942b9dc27723) tajo-storage/src/main/java/org/apache/tajo/storage/rcfile/RCFile.java tajo-storage/src/main/java/org/apache/tajo/storage/AbstractStorageManager.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java CHANGES.txt tajo-storage/pom.xml tajo-storage/src/test/java/org/apache/tajo/storage/TestStorageManager.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/DefaultTaskScheduler.java tajo-storage/src/main/java/org/apache/tajo/storage/fragment/FileFragment.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-0.8.0-build #64 (See https://builds.apache.org/job/Tajo-0.8.0-build/64/)
        TAJO-717: Improve file splitting for large number of splits. (jinho) (jinossy: rev 70aca839ca7ff28d3449255ed10cf3f569ebf31a)

        • tajo-storage/src/main/java/org/apache/tajo/storage/fragment/FileFragment.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/rcfile/RCFile.java
        • CHANGES.txt
        • tajo-storage/src/main/java/org/apache/tajo/storage/AbstractStorageManager.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/DefaultTaskScheduler.java
        • tajo-storage/pom.xml
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java
        • tajo-storage/src/test/java/org/apache/tajo/storage/TestStorageManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-0.8.0-build #64 (See https://builds.apache.org/job/Tajo-0.8.0-build/64/ ) TAJO-717 : Improve file splitting for large number of splits. (jinho) (jinossy: rev 70aca839ca7ff28d3449255ed10cf3f569ebf31a) tajo-storage/src/main/java/org/apache/tajo/storage/fragment/FileFragment.java tajo-storage/src/main/java/org/apache/tajo/storage/rcfile/RCFile.java CHANGES.txt tajo-storage/src/main/java/org/apache/tajo/storage/AbstractStorageManager.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/DefaultTaskScheduler.java tajo-storage/pom.xml tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java tajo-storage/src/test/java/org/apache/tajo/storage/TestStorageManager.java

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development