Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-671

RangeParitionAlgorithm.computeCardinality() should return a positive value

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None

      Description

      See the title.
      Sometimes, the return value of computeCardinality() is negative and an unexpected action is caused in UniformRangePartition.partition().

      1. TAJO-671_2.patch
        0.8 kB
        Jihoon Son
      2. TAJO-671.patch
        0.8 kB
        Jihoon Son

        Activity

        Hide
        jihoonson Jihoon Son added a comment -

        Since this change is so trivial, I directly uploaded the patch to JIRA.

        Show
        jihoonson Jihoon Son added a comment - Since this change is so trivial, I directly uploaded the patch to JIRA.
        Hide
        jihoonson Jihoon Son added a comment -

        Fix a missing case.

        Show
        jihoonson Jihoon Son added a comment - Fix a missing case.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12633108/TAJO-671.patch
        against master revision ba6fc72.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 184 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/197//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/197//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/197//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12633108/TAJO-671.patch against master revision ba6fc72. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 184 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/197//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/197//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/197//console This message is automatically generated.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12633114/TAJO-671_2.patch
        against master revision ba6fc72.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 184 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/198//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/198//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/198//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12633114/TAJO-671_2.patch against master revision ba6fc72. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 184 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/198//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/198//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/198//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        The patch and issue is very reasonable. Could you add some unit tests to reproduce the unexpected cases you mentioned?

        Show
        hyunsik Hyunsik Choi added a comment - The patch and issue is very reasonable. Could you add some unit tests to reproduce the unexpected cases you mentioned?
        Hide
        jihoonson Jihoon Son added a comment -

        Sure. I'll add some unit tests.

        Show
        jihoonson Jihoon Son added a comment - Sure. I'll add some unit tests.
        Hide
        jihoonson Jihoon Son added a comment -

        This issue is fixed in TAJO-692.

        Show
        jihoonson Jihoon Son added a comment - This issue is fixed in TAJO-692 .

          People

          • Assignee:
            jihoonson Jihoon Son
            Reporter:
            jihoonson Jihoon Son
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development