Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-670

Change daemon's hostname to canonical hostname

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0, 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      Hadoop's block location use canonical host name. But Tajo uses host name set in the physical server. If the host name of the physical server running Tajo is short name, can't find local block.

      1. TAJO-670.patch
        0.6 kB
        Hyoungjun Kim

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.8.0-build #14 (See https://builds.apache.org/job/Tajo-0.8.0-build/14/)
        TAJO-670: Change daemon's hostname to canonical hostname. (hyoungjunkim via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=bc3e86c55eb8b933ce7513af506c2724cb665b5e)

        • CHANGES.txt
        • tajo-common/src/main/java/org/apache/tajo/util/NetUtils.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.8.0-build #14 (See https://builds.apache.org/job/Tajo-0.8.0-build/14/ ) TAJO-670 : Change daemon's hostname to canonical hostname. (hyoungjunkim via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=bc3e86c55eb8b933ce7513af506c2724cb665b5e ) CHANGES.txt tajo-common/src/main/java/org/apache/tajo/util/NetUtils.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #108 (See https://builds.apache.org/job/Tajo-master-build/108/)
        TAJO-670: Change daemon's hostname to canonical hostname. (hyoungjunkim via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=fddd2236ad72fe40456fb0e115d493476b9d6e6a)

        • tajo-common/src/main/java/org/apache/tajo/util/NetUtils.java
        • CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #108 (See https://builds.apache.org/job/Tajo-master-build/108/ ) TAJO-670 : Change daemon's hostname to canonical hostname. (hyoungjunkim via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=fddd2236ad72fe40456fb0e115d493476b9d6e6a ) tajo-common/src/main/java/org/apache/tajo/util/NetUtils.java CHANGES.txt
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed to 0.8 and master branch. Thanks!

        Show
        hyunsik Hyunsik Choi added a comment - committed to 0.8 and master branch. Thanks!
        Hide
        hyunsik Hyunsik Choi added a comment - - edited

        +1

        Thank you for nice finding. As you mentioned, the worker's hostname can vary according to host's configuration. It is may be hard for this patch to have unit tests. If I get some idea, I'll add unit tests.

        Show
        hyunsik Hyunsik Choi added a comment - - edited +1 Thank you for nice finding. As you mentioned, the worker's hostname can vary according to host's configuration. It is may be hard for this patch to have unit tests. If I get some idea, I'll add unit tests.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12633100/TAJO-670.patch
        against master revision ba6fc72.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-common.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/196//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/196//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12633100/TAJO-670.patch against master revision ba6fc72. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-common. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/196//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/196//console This message is automatically generated.
        Hide
        hjkim Hyoungjun Kim added a comment -

        Please review this patch.

        Show
        hjkim Hyoungjun Kim added a comment - Please review this patch.

          People

          • Assignee:
            hjkim Hyoungjun Kim
            Reporter:
            hjkim Hyoungjun Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development