Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-651

HcatalogStore should support (de)serialization of RCFile

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0, 0.9.0
    • Component/s: Catalog
    • Labels:
      None

      Description

      Currently, hcatalogstore does not use serde property in hive meta

      # Storage Information            
      SerDe Library:          org.apache.hadoop.hive.serde2.columnar.ColumnarSerDe     
      InputFormat:            org.apache.hadoop.hive.ql.io.RCFileInputFormat   
      OutputFormat:           org.apache.hadoop.hive.ql.io.RCFileOutputFormat  
      Compressed:             No                       
      Num Buckets:            -1                       
      Bucket Columns:         []                       
      Sort Columns:           []                       
      Storage Desc Params:             
              serialization.format    1
      

        Issue Links

          Activity

          Hide
          jhkim Jinho Kim added a comment -

          Created a review request against branch master in reviewboard
          https://reviews.apache.org/r/19170/

          Show
          jhkim Jinho Kim added a comment - Created a review request against branch master in reviewboard https://reviews.apache.org/r/19170/
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12634345/TAJO-651.patch
          against master revision 44b28e6.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 184 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-common tajo-catalog/tajo-catalog-drivers/tajo-hcatalog tajo-core/tajo-core-backend tajo-storage.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/214//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/214//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/214//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/214//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12634345/TAJO-651.patch against master revision 44b28e6. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 184 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-common tajo-catalog/tajo-catalog-drivers/tajo-hcatalog tajo-core/tajo-core-backend tajo-storage. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/214//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/214//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/214//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/214//console This message is automatically generated.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #119 (See https://builds.apache.org/job/Tajo-master-build/119/)
          TAJO-651: HcatalogStore should support (de)serialization of RCFile. (jinho) (jinossy: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=db5e954f4395f22437e59d93fd97477145d44686)

          • tajo-storage/src/test/java/org/apache/tajo/storage/TestStorages.java
          • tajo-storage/src/main/java/org/apache/tajo/storage/rcfile/RCFile.java
          • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStoreClientPool.java
          • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogUtil.java
          • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/TpchTestBase.java
          • tajo-core/tajo-core-backend/src/test/resources/results/testBuildDDL.result
          • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/client/TestDDLBuilder.java
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableMeta.java
          • CHANGES.txt
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogConstants.java
          • tajo-storage/src/main/java/org/apache/tajo/storage/CSVFile.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/benchmark/TPCH.java
          • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/TestHCatalogStore.java
          • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNullValues.java
          • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #119 (See https://builds.apache.org/job/Tajo-master-build/119/ ) TAJO-651 : HcatalogStore should support (de)serialization of RCFile. (jinho) (jinossy: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=db5e954f4395f22437e59d93fd97477145d44686 ) tajo-storage/src/test/java/org/apache/tajo/storage/TestStorages.java tajo-storage/src/main/java/org/apache/tajo/storage/rcfile/RCFile.java tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStoreClientPool.java tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogUtil.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/TpchTestBase.java tajo-core/tajo-core-backend/src/test/resources/results/testBuildDDL.result tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/client/TestDDLBuilder.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableMeta.java CHANGES.txt tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogConstants.java tajo-storage/src/main/java/org/apache/tajo/storage/CSVFile.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/benchmark/TPCH.java tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/TestHCatalogStore.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNullValues.java tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java
          Hide
          jhkim Jinho Kim added a comment -

          This issue got +1 from RB.
          I've just committed it

          Show
          jhkim Jinho Kim added a comment - This issue got +1 from RB. I've just committed it
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-0.8.0-build #23 (See https://builds.apache.org/job/Tajo-0.8.0-build/23/)
          TAJO-651: HcatalogStore should support (de)serialization of RCFile. (jinho) (jinossy: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=7a7009b391bebe598579d8a77c94ba78fd76d153)

          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogConstants.java
          • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/client/TestDDLBuilder.java
          • tajo-storage/src/main/java/org/apache/tajo/storage/CSVFile.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java
          • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStoreClientPool.java
          • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/TestHCatalogStore.java
          • tajo-storage/src/main/java/org/apache/tajo/storage/rcfile/RCFile.java
          • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java
          • tajo-core/tajo-core-backend/src/test/resources/results/testBuildDDL.result
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/benchmark/TPCH.java
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableMeta.java
          • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/TpchTestBase.java
          • tajo-storage/src/test/java/org/apache/tajo/storage/TestStorages.java
          • CHANGES.txt
          • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogUtil.java
          • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNullValues.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.8.0-build #23 (See https://builds.apache.org/job/Tajo-0.8.0-build/23/ ) TAJO-651 : HcatalogStore should support (de)serialization of RCFile. (jinho) (jinossy: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=7a7009b391bebe598579d8a77c94ba78fd76d153 ) tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogConstants.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/client/TestDDLBuilder.java tajo-storage/src/main/java/org/apache/tajo/storage/CSVFile.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStoreClientPool.java tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/TestHCatalogStore.java tajo-storage/src/main/java/org/apache/tajo/storage/rcfile/RCFile.java tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java tajo-core/tajo-core-backend/src/test/resources/results/testBuildDDL.result tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/benchmark/TPCH.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableMeta.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/TpchTestBase.java tajo-storage/src/test/java/org/apache/tajo/storage/TestStorages.java CHANGES.txt tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogUtil.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNullValues.java

            People

            • Assignee:
              jhkim Jinho Kim
              Reporter:
              jhkim Jinho Kim
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development