Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-650

Repartitioner::scheduleHashShuffledFetches should adjust the number of tasks

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0, 0.9.0
    • Fix Version/s: 0.8.0, 0.9.0
    • Component/s: Data Shuffle
    • Labels:
      None

      Description

      Even though Repartitioner::scheduleHashShuffledFetches gets the number of proper number of tasks for reoptimization, it does not adjust the number of tasks. It seems to be omitted in some change. This patch recovers the feature.

      1. TAJO-650_140306_135535.patch
        5 kB
        Hyunsik Choi
      2. TAJO-650.patch
        4 kB
        Hyunsik Choi

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.8.0-build #12 (See https://builds.apache.org/job/Tajo-0.8.0-build/12/)
        TAJO-650: Repartitioner::scheduleHashShuffledFetches should adjust the number of tasks. (hyunsik: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=63deb30232ae3099ae794800de0534a61c5cb170)

        • tajo-common/src/main/java/org/apache/tajo/util/TUtil.java
        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.8.0-build #12 (See https://builds.apache.org/job/Tajo-0.8.0-build/12/ ) TAJO-650 : Repartitioner::scheduleHashShuffledFetches should adjust the number of tasks. (hyunsik: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=63deb30232ae3099ae794800de0534a61c5cb170 ) tajo-common/src/main/java/org/apache/tajo/util/TUtil.java CHANGES.txt tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #105 (See https://builds.apache.org/job/Tajo-master-build/105/)
        TAJO-650: Repartitioner::scheduleHashShuffledFetches should adjust the number of tasks. (hyunsik: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=462abc47113a5c41fed783c34cd5b35a8eae4758)

        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java
        • CHANGES.txt
        • tajo-common/src/main/java/org/apache/tajo/util/TUtil.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #105 (See https://builds.apache.org/job/Tajo-master-build/105/ ) TAJO-650 : Repartitioner::scheduleHashShuffledFetches should adjust the number of tasks. (hyunsik: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=462abc47113a5c41fed783c34cd5b35a8eae4758 ) tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java CHANGES.txt tajo-common/src/main/java/org/apache/tajo/util/TUtil.java
        Hide
        hyunsik Hyunsik Choi added a comment -

        got +1 on RB. I just committed to 0.8 and master branch.

        Show
        hyunsik Hyunsik Choi added a comment - got +1 on RB. I just committed to 0.8 and master branch.
        Hide
        hyunsik Hyunsik Choi added a comment -

        Fixed the bug of the round robin schedule.

        Updated the review request against branch master in reviewboard
        https://reviews.apache.org/r/18731/

        Show
        hyunsik Hyunsik Choi added a comment - Fixed the bug of the round robin schedule. Updated the review request against branch master in reviewboard https://reviews.apache.org/r/18731/
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12632489/TAJO-650.patch
        against master revision f4a9fd1.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 183 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/182//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/182//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/182//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12632489/TAJO-650.patch against master revision f4a9fd1. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 183 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/182//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/182//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/182//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        Created a review request against branch master in reviewboard
        https://reviews.apache.org/r/18731/

        Show
        hyunsik Hyunsik Choi added a comment - Created a review request against branch master in reviewboard https://reviews.apache.org/r/18731/

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development