Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-645

Task.Reporter can cause NPE during reporting.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.8.0, 0.9.0
    • Fix Version/s: 0.8.0, 0.9.0
    • Component/s: Worker
    • Labels:
      None

      Description

      See the title. This problem causes the following error messages.

      014-03-03 19:52:27,680 ERROR worker.Task (Task.java:run(687)) - 
      java.lang.NullPointerException
      	at org.apache.tajo.worker.Task$Reporter$1.run(Task.java:681)
      	at java.lang.Thread.run(Thread.java:724)
      2014-03-03 19:52:27,689 INFO  worker.Task (Task.java:<init>(181)) - Output File Path: hdfs://localhost:52744/tmp/tajo-hyunsik/staging/q_1393843945346_0001/RESULT/part-01-000000
      

      The main cause is to start the report thread in Task before this.context is initialized as follows:

          this.reporter = new Reporter(taskId, masterProxy);
          this.reporter.startCommunicationThread();
          ...
          this.context = new TaskAttemptContext(systemConf, taskId,
              request.getFragments().toArray(new FragmentProto[request.getFragments().size()]), taskDir);
      
      1. TAJO-645.patch
        1 kB
        Hyunsik Choi

        Activity

        Hide
        hyunsik Hyunsik Choi added a comment -

        Created a review request against branch master in reviewboard
        https://reviews.apache.org/r/18682/

        Show
        hyunsik Hyunsik Choi added a comment - Created a review request against branch master in reviewboard https://reviews.apache.org/r/18682/
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12632230/TAJO-645.patch
        against master revision 15c4576.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 183 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/174//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/174//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/174//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12632230/TAJO-645.patch against master revision 15c4576. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 183 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/174//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/174//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/174//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        This issue got +1 on RB. committed to branch-0.8.0 and master.

        Show
        hyunsik Hyunsik Choi added a comment - This issue got +1 on RB. committed to branch-0.8.0 and master.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #98 (See https://builds.apache.org/job/Tajo-master-build/98/)
        TAJO-645: Task.Reporter can cause NPE during reporting. (hyunsik: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=f4a9fd183b5a4a61eef82e570215303ee4f10f0b)

        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/Task.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #98 (See https://builds.apache.org/job/Tajo-master-build/98/ ) TAJO-645 : Task.Reporter can cause NPE during reporting. (hyunsik: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=f4a9fd183b5a4a61eef82e570215303ee4f10f0b ) CHANGES.txt tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/Task.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.8.0-build #5 (See https://builds.apache.org/job/Tajo-0.8.0-build/5/)
        TAJO-645: Task.Reporter can cause NPE during reporting. (hyunsik: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=0c5b7702a6818080397f970077aa3f28fcab0f93)

        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/Task.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.8.0-build #5 (See https://builds.apache.org/job/Tajo-0.8.0-build/5/ ) TAJO-645 : Task.Reporter can cause NPE during reporting. (hyunsik: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=0c5b7702a6818080397f970077aa3f28fcab0f93 ) CHANGES.txt tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/Task.java

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development