Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-635

Improve tests of query semantic verification

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0, 0.9.0
    • Fix Version/s: 0.8.0, 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      See TAJO-633. This is caused by some missed visitor functions. When I investigated TAJO-633, I found that there are more missed methods in BasicEvalNodeVisitor and EvalNodeVisitor2. Also, I found that ExprTestBase::testEval() does not use PreLogicalPlanVerifier, LogicalOptimizer, and LogicalPlanVerifier. As a result, query semantic verification has not been tested fully. This patch fixes all of them.

      1. TAJO-635.patch
        12 kB
        Hyunsik Choi

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #90 (See https://builds.apache.org/job/Tajo-master-build/90/)
        TAJO-635: Improve tests of query semantic verification. (hyunsik: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=03718031a113af7ccd7ddba2df7513f6b0b21c42)

        • tajo-algebra/src/main/java/org/apache/tajo/algebra/FunctionExpr.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprsVerifier.java
        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/EvalNodeVisitor2.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/BetweenPredicateEval.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/BasicEvalNodeVisitor.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BaseAlgebraVisitor.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestSQLExpression.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #90 (See https://builds.apache.org/job/Tajo-master-build/90/ ) TAJO-635 : Improve tests of query semantic verification. (hyunsik: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=03718031a113af7ccd7ddba2df7513f6b0b21c42 ) tajo-algebra/src/main/java/org/apache/tajo/algebra/FunctionExpr.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprsVerifier.java CHANGES.txt tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/EvalNodeVisitor2.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/BetweenPredicateEval.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/BasicEvalNodeVisitor.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BaseAlgebraVisitor.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestSQLExpression.java
        Hide
        hyunsik Hyunsik Choi added a comment -

        I missed to mention that this issue got +1 on Rb.

        Show
        hyunsik Hyunsik Choi added a comment - I missed to mention that this issue got +1 on Rb.
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master branch and branch-0.8.0.

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master branch and branch-0.8.0.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12631142/TAJO-635.patch
        against master revision 56fbd99.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 185 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-algebra tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/162//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/162//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/162//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-algebra.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/162//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12631142/TAJO-635.patch against master revision 56fbd99. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 185 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-algebra tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/162//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/162//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/162//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-algebra.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/162//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        Created a review request against branch master in reviewboard
        https://reviews.apache.org/r/18506/

        Show
        hyunsik Hyunsik Choi added a comment - Created a review request against branch master in reviewboard https://reviews.apache.org/r/18506/

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development