Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-634

ExecutionBlock must be sorted by start time in querydetail.jsp

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0, 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently implementation, ExecutionBlock is sorted by ID in querydetail.jsp.
      It must be sorted by start time.

      1. TAJO-643.patch
        8 kB
        Hyoungjun Kim

        Activity

        Hide
        hjkim Hyoungjun Kim added a comment -

        I fixed the following items.

        • Sort by started time instead of EB ID in querydetail.jsp
        • A bug which ignore status filter when task sorting in querytasks.jsp
        • Broken html table tag in cluster.jsp

        And I found a bug that a dead worker doesn't listing in dead worker table when a worker started with QueryMaster mode and TaskRunner mode in a single worker. So I fixed that bug in this patch.

        Show
        hjkim Hyoungjun Kim added a comment - I fixed the following items. Sort by started time instead of EB ID in querydetail.jsp A bug which ignore status filter when task sorting in querytasks.jsp Broken html table tag in cluster.jsp And I found a bug that a dead worker doesn't listing in dead worker table when a worker started with QueryMaster mode and TaskRunner mode in a single worker. So I fixed that bug in this patch.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12631764/TAJO-643.patch
        against master revision f594542.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 183 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/169//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/169//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/169//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12631764/TAJO-643.patch against master revision f594542. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 183 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/169//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/169//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/169//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        +1

        Thank you for your contribution.

        Show
        hyunsik Hyunsik Choi added a comment - +1 Thank you for your contribution.
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master and branch-0.8.0.

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master and branch-0.8.0.

          People

          • Assignee:
            hjkim Hyoungjun Kim
            Reporter:
            hjkim Hyoungjun Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development