Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-609

PlannerUtil::getRelationLineage ignores PartitionedTableScanNode

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: Planner/Optimizer
    • Labels:
      None

      Description

      Currently, PlannerUtil::getRelationLineage ignores PartitionedTableScanNode. As a result, PlannerUtil::getRelationLineage can return empty relations. It results in wrong estimation of relation size. Finally, in the case where a broadcast join between a partitioned table and a small table, this problem causes the bug to choose the larger table instead of smaller one to be loaded on hash table.

      This patch fixes this bug, refactors inner-join related methods, and added more comments on them.

      1. TAJO-609.patch
        19 kB
        Hyunsik Choi

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #71 (See https://builds.apache.org/job/Tajo-master-build/71/)
        TAJO-609: PlannerUtil::getRelationLineage ignores PartitionedTableScanNode. (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=57bf90e220d881f39f0c91877edc57be7005a596)

        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestHashJoinExec.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/LocalTajoTestingUtility.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PlannerUtil.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java
        • CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #71 (See https://builds.apache.org/job/Tajo-master-build/71/ ) TAJO-609 : PlannerUtil::getRelationLineage ignores PartitionedTableScanNode. (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=57bf90e220d881f39f0c91877edc57be7005a596 ) tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestHashJoinExec.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/LocalTajoTestingUtility.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PlannerUtil.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java CHANGES.txt
        Hide
        hyunsik Hyunsik Choi added a comment -

        This issue got +1 on RB. committed it to master branch. Thank you for the reviews.

        Show
        hyunsik Hyunsik Choi added a comment - This issue got +1 on RB. committed it to master branch. Thank you for the reviews.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12629755/TAJO-609.patch
        against master revision c586227.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 173 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/141//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/141//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/141//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12629755/TAJO-609.patch against master revision c586227. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 173 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/141//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/141//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/141//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        Created a review request against branch master in reviewboard
        https://reviews.apache.org/r/18264/

        Show
        hyunsik Hyunsik Choi added a comment - Created a review request against branch master in reviewboard https://reviews.apache.org/r/18264/

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development