Details

    • Type: Task
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:

      Description

      The name of Options class is not good for presenting its purpose. We should rename Options to KeyValueList. Also, it is a general purpose rather than for catalog. We need to move it to tajo-common.

      1. TAJO-605.patch
        66 kB
        Jinho Kim
      2. TAJO-605_20140430_10:46:06.patch
        72 kB
        Jinho Kim

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #212 (See https://builds.apache.org/job/Tajo-master-build/212/)
        TAJO-605: Rename Options to KeyValueList. (jinho) (jinossy: rev 5db47466b00b7405a7decf1fbe036f4ebfb960ec)

        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java
        • tajo-core/src/main/java/org/apache/tajo/master/session/Session.java
        • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java
        • tajo-core/src/test/java/org/apache/tajo/TpchTestBase.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/TestLogicalOptimizer.java
        • tajo-storage/src/test/java/org/apache/tajo/storage/v2/TestStorages.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/logical/CreateTableNode.java
        • tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/TestPlannerUtil.java
        • tajo-common/src/main/java/org/apache/tajo/util/KeyValueSet.java
        • tajo-core/src/main/java/org/apache/tajo/engine/query/QueryContext.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/DDLBuilder.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java
        • tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableMeta.java
        • tajo-storage/src/test/java/org/apache/tajo/storage/TestMergeScanner.java
        • tajo-core/src/test/java/org/apache/tajo/worker/TestRangeRetrieverHandler.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java
        • tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestKeyValueSet.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java
        • tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java
        • tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestOptions.java
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/logical/PersistentStoreNode.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/StorageUtil.java
        • tajo-core/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestNullValues.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Options.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java
        • tajo-core/src/test/java/org/apache/tajo/LocalTajoTestingUtility.java
        • tajo-common/src/main/proto/PrimitiveProtos.proto
        • tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlanner.java
        • tajo-storage/src/test/java/org/apache/tajo/storage/TestStorages.java
        • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/TestHCatalogStore.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #212 (See https://builds.apache.org/job/Tajo-master-build/212/ ) TAJO-605 : Rename Options to KeyValueList. (jinho) (jinossy: rev 5db47466b00b7405a7decf1fbe036f4ebfb960ec) tajo-core/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java tajo-core/src/main/java/org/apache/tajo/master/session/Session.java tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java tajo-core/src/test/java/org/apache/tajo/TpchTestBase.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java tajo-core/src/test/java/org/apache/tajo/engine/planner/TestLogicalOptimizer.java tajo-storage/src/test/java/org/apache/tajo/storage/v2/TestStorages.java tajo-core/src/main/java/org/apache/tajo/engine/planner/logical/CreateTableNode.java tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java tajo-core/src/test/java/org/apache/tajo/engine/planner/TestPlannerUtil.java tajo-common/src/main/java/org/apache/tajo/util/KeyValueSet.java tajo-core/src/main/java/org/apache/tajo/engine/query/QueryContext.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/DDLBuilder.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableMeta.java tajo-storage/src/test/java/org/apache/tajo/storage/TestMergeScanner.java tajo-core/src/test/java/org/apache/tajo/worker/TestRangeRetrieverHandler.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestKeyValueSet.java CHANGES tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestOptions.java tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java tajo-core/src/main/java/org/apache/tajo/engine/planner/logical/PersistentStoreNode.java tajo-storage/src/main/java/org/apache/tajo/storage/StorageUtil.java tajo-core/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestNullValues.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Options.java tajo-core/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java tajo-core/src/test/java/org/apache/tajo/LocalTajoTestingUtility.java tajo-common/src/main/proto/PrimitiveProtos.proto tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java tajo-core/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlanner.java tajo-storage/src/test/java/org/apache/tajo/storage/TestStorages.java tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/TestHCatalogStore.java
        Hide
        jhkim Jinho Kim added a comment -

        This issue got +1 from reviewboard.
        I've just committed it

        Show
        jhkim Jinho Kim added a comment - This issue got +1 from reviewboard. I've just committed it
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12642579/TAJO-605_20140430_10%3A46%3A06.patch
        against master revision 6200311.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 17 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-common tajo-catalog/tajo-catalog-drivers/tajo-hcatalog tajo-catalog/tajo-catalog-server tajo-client tajo-common tajo-core tajo-storage.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/401//testReport/
        Findbugs results: https://builds.apache.org/job/PreCommit-TAJO-Build/401//findbugsResult
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/401//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12642579/TAJO-605_20140430_10%3A46%3A06.patch against master revision 6200311. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 17 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-common tajo-catalog/tajo-catalog-drivers/tajo-hcatalog tajo-catalog/tajo-catalog-server tajo-client tajo-common tajo-core tajo-storage. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/401//testReport/ Findbugs results: https://builds.apache.org/job/PreCommit-TAJO-Build/401//findbugsResult Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/401//console This message is automatically generated.
        Hide
        jhkim Jinho Kim added a comment -

        Updated the review request against branch master in reviewboard
        https://reviews.apache.org/r/20831/

        Show
        jhkim Jinho Kim added a comment - Updated the review request against branch master in reviewboard https://reviews.apache.org/r/20831/
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12642418/TAJO-605.patch
        against master revision 6cc5006.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 16 new or modified test files.

        -1 javac. The patch appears to cause the build to fail.

        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/396//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12642418/TAJO-605.patch against master revision 6cc5006. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 16 new or modified test files. -1 javac. The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/396//console This message is automatically generated.
        Hide
        jhkim Jinho Kim added a comment -

        Created a review request against branch master in reviewboard
        https://reviews.apache.org/r/20831/

        Show
        jhkim Jinho Kim added a comment - Created a review request against branch master in reviewboard https://reviews.apache.org/r/20831/

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development