Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-586

containFunction shouldn't throw NoSuchFunctionException

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: Catalog
    • Labels:
      None

      Description

      containFunction should return boolean value

      2014-02-05 15:18:23,088 INFO  catalog.CatalogServer (CatalogServer.java:start(166)) - Catalog Server startup (127.0.0.1:11353)
      2014-02-05 15:18:23,098 ERROR catalog.AbstractCatalogClient (AbstractCatalogClient.java:containFunction(407)) - org.apache.tajo.catalog.exception.NoSuchFunctionException: function test10() does not exist
      com.google.protobuf.ServiceException: org.apache.tajo.catalog.exception.NoSuchFunctionException: function test10() does not exist
      	at org.apache.tajo.rpc.ServerCallable.withRetries(ServerCallable.java:110)
      	at org.apache.tajo.catalog.AbstractCatalogClient.containFunction(AbstractCatalogClient.java:400)
      	at org.apache.tajo.catalog.TestCatalog.testRegisterAndFindFunc(TestCatalog.java:178)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      	at java.lang.reflect.Method.invoke(Method.java:597)
      	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
      	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
      	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
      	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
      	at org.junit.internal.runners.statements.ExpectException.evaluate(ExpectException.java:22)
      	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
      	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
      	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
      	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
      	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
      	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
      	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
      	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
      	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
      	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30)
      	at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
      	at org.junit.runner.JUnitCore.run(JUnitCore.java:157)
      	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:74)
      	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:202)
      	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:65)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      	at java.lang.reflect.Method.invoke(Method.java:597)
      	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:120)
      Caused by: org.apache.tajo.catalog.exception.NoSuchFunctionException: function test10() does not exist
      	at org.apache.tajo.catalog.CatalogServer$CatalogProtocolHandler.findFunction(CatalogServer.java:523)
      	at org.apache.tajo.catalog.CatalogServer$CatalogProtocolHandler.containFunction(CatalogServer.java:497)
      	at org.apache.tajo.catalog.CatalogServer$CatalogProtocolHandler.containFunction(CatalogServer.java:589)
      	at org.apache.tajo.catalog.AbstractCatalogClient$18.call(AbstractCatalogClient.java:403)
      	at org.apache.tajo.catalog.AbstractCatalogClient$18.call(AbstractCatalogClient.java:400)
      	at org.apache.tajo.rpc.ServerCallable.withRetries(ServerCallable.java:96)
      

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #57 (See https://builds.apache.org/job/Tajo-master-build/57/)
        TAJO-586: containFunction shouldn't throw NoSuchFunctionException. (jinho) (jinossy: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=d0206493bfb2a60b647ad2d1dd555d3da50892b7)

        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java
        • CHANGES.txt
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java
        • tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprAnnotator.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #57 (See https://builds.apache.org/job/Tajo-master-build/57/ ) TAJO-586 : containFunction shouldn't throw NoSuchFunctionException. (jinho) (jinossy: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=d0206493bfb2a60b647ad2d1dd555d3da50892b7 ) tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java CHANGES.txt tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprAnnotator.java
        Hide
        jhkim Jinho Kim added a comment -

        This issue got +1 from reviewboard.
        I've just committed it to master branch.

        Show
        jhkim Jinho Kim added a comment - This issue got +1 from reviewboard. I've just committed it to master branch.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12627085/TAJO-586.patch
        against master revision 5177dcf.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 249 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-server tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/107//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/107//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/107//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-server.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/107//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12627085/TAJO-586.patch against master revision 5177dcf. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 249 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-server tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/107//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/107//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/107//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-server.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/107//console This message is automatically generated.
        Hide
        jhkim Jinho Kim added a comment -

        Created a review request against branch master in reviewboard
        https://reviews.apache.org/r/17735/

        Show
        jhkim Jinho Kim added a comment - Created a review request against branch master in reviewboard https://reviews.apache.org/r/17735/

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development