Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: Build
    • Labels:
      None

      Description

      Fix warnings in tajo-rpc.

        Activity

        Hide
        jhkim Jinho Kim added a comment -

        I've attached the patch.

        Show
        jhkim Jinho Kim added a comment - I've attached the patch.
        Hide
        jhkim Jinho Kim added a comment - - edited

        Created a review request against branch master in reviewboard
        https://reviews.apache.org/r/17112/

        Show
        jhkim Jinho Kim added a comment - - edited Created a review request against branch master in reviewboard https://reviews.apache.org/r/17112/
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12623891/TAJO-535.patch
        against master revision d04f9a5.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-rpc.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/62//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/62//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12623891/TAJO-535.patch against master revision d04f9a5. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-rpc. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/62//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/62//console This message is automatically generated.
        Hide
        jhkim Jinho Kim added a comment -

        This issue got +1 from reviewboard.
        I've just committed it to master branch.

        Show
        jhkim Jinho Kim added a comment - This issue got +1 from reviewboard. I've just committed it to master branch.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #21 (See https://builds.apache.org/job/Tajo-master-build/21/)
        TAJO-535: Fix warnings in tajo-rpc. (jinho) (jinossy: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=b75ea74d5120bce7eb1bc7a50430a3a04529cb8c)

        • tajo-rpc/src/main/java/org/apache/tajo/rpc/ServerCallable.java
        • tajo-rpc/src/main/java/org/apache/tajo/rpc/RpcConnectionPool.java
        • CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #21 (See https://builds.apache.org/job/Tajo-master-build/21/ ) TAJO-535 : Fix warnings in tajo-rpc. (jinho) (jinossy: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=b75ea74d5120bce7eb1bc7a50430a3a04529cb8c ) tajo-rpc/src/main/java/org/apache/tajo/rpc/ServerCallable.java tajo-rpc/src/main/java/org/apache/tajo/rpc/RpcConnectionPool.java CHANGES.txt

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development