Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-518

tajo-algebra and ProjectionPushDownRule code cleanup

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: Planner/Optimizer
    • Labels:
      None

      Description

      This patch fixes some potential bugs commented in TAJO-501 reviews.
      https://reviews.apache.org/r/17040/

      1. TAJO-518_20140119_22:01:33.patch
        35 kB
        Hyunsik Choi
      2. TAJO-518.patch
        10 kB
        Hyunsik Choi

        Activity

        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12623684/TAJO-518.patch
        against master revision ebb12b7.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 164 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-algebra tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/57//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/57//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-algebra.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/57//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/57//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12623684/TAJO-518.patch against master revision ebb12b7. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 164 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-algebra tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/57//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/57//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-algebra.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/57//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/57//console This message is automatically generated.
        Hide
        jihoonson Jihoon Son added a comment -

        Thanks for your fast work.
        But, actually, I haven't finished the review of TAJO-501 yet, because its size is quite large.
        May I proceed more detailed review on TAJO-501?

        Show
        jihoonson Jihoon Son added a comment - Thanks for your fast work. But, actually, I haven't finished the review of TAJO-501 yet, because its size is quite large. May I proceed more detailed review on TAJO-501 ?
        Hide
        hyunsik Hyunsik Choi added a comment -

        That's fine. Please go ahead.

        Show
        hyunsik Hyunsik Choi added a comment - That's fine. Please go ahead.
        Hide
        hyunsik Hyunsik Choi added a comment -

        Updated the review request against branch master in reviewboard
        https://reviews.apache.org/r/17081/

        Show
        hyunsik Hyunsik Choi added a comment - Updated the review request against branch master in reviewboard https://reviews.apache.org/r/17081/
        Hide
        hyunsik Hyunsik Choi added a comment -

        I've just uploaded a new patch that reflects your latest comments.
        https://reviews.apache.org/r/17081/

        Show
        hyunsik Hyunsik Choi added a comment - I've just uploaded a new patch that reflects your latest comments. https://reviews.apache.org/r/17081/
        Hide
        hyunsik Hyunsik Choi added a comment -

        Got +1 from RB. committed it to master branch.

        Show
        hyunsik Hyunsik Choi added a comment - Got +1 from RB. committed it to master branch.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #18 (See https://builds.apache.org/job/Tajo-master-build/18/)
        TAJO-518: tajo-algebra and ProjectionPushDownRule code cleanup. (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=c670c8a98b96a35031b155e4e5c28e8909784f8f)

        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestEvalTreeUtil.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java
        • tajo-algebra/src/main/java/org/apache/tajo/algebra/CaseWhenPredicate.java
        • tajo-algebra/src/main/java/org/apache/tajo/algebra/BinaryOperator.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/rewrite/ProjectionPushDownRule.java
        • tajo-algebra/src/main/java/org/apache/tajo/algebra/DropTable.java
        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlan.java
        • tajo-algebra/src/main/java/org/apache/tajo/algebra/Aggregation.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BaseAlgebraVisitor.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java
        • tajo-algebra/src/main/java/org/apache/tajo/algebra/Expr.java
        • tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprNormalizer.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #18 (See https://builds.apache.org/job/Tajo-master-build/18/ ) TAJO-518 : tajo-algebra and ProjectionPushDownRule code cleanup. (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=c670c8a98b96a35031b155e4e5c28e8909784f8f ) tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestEvalTreeUtil.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java tajo-algebra/src/main/java/org/apache/tajo/algebra/CaseWhenPredicate.java tajo-algebra/src/main/java/org/apache/tajo/algebra/BinaryOperator.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/rewrite/ProjectionPushDownRule.java tajo-algebra/src/main/java/org/apache/tajo/algebra/DropTable.java CHANGES.txt tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlan.java tajo-algebra/src/main/java/org/apache/tajo/algebra/Aggregation.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BaseAlgebraVisitor.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java tajo-algebra/src/main/java/org/apache/tajo/algebra/Expr.java tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprNormalizer.java

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development