Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-508

Apply findbugs-excludeFilterFile to TajoQA

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: conf and scripts
    • Labels:
      None

      Description

      There are many findbugs errors reporting by Tajo QA.
      We need to exclude antlr parser and protobuf warnings since these are machine generated.

      • dev-support/findbugs-exclude.xml
      1. TAJO-508_2.patch
        17 kB
        Jinho Kim
      2. TAJO-508.patch
        9 kB
        Jinho Kim

        Activity

        Hide
        jhkim Jinho Kim added a comment -

        I've added bug-patterns refer to Hbase

        Show
        jhkim Jinho Kim added a comment - I've added bug-patterns refer to Hbase
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12623403/TAJO-508.patch
        against master revision 69700bf.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 212 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend tajo-core/tajo-core-storage.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/50//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/50//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/50//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-storage.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/50//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12623403/TAJO-508.patch against master revision 69700bf. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 212 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend tajo-core/tajo-core-storage. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/50//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/50//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/50//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-storage.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/50//console This message is automatically generated.
        Hide
        jhkim Jinho Kim added a comment - - edited

        I've uploaded the second patch that fixes the jira color tags.
        https://reviews.apache.org/r/16971/

        Show
        jhkim Jinho Kim added a comment - - edited I've uploaded the second patch that fixes the jira color tags. https://reviews.apache.org/r/16971/
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12623419/TAJO-508_2.patch
        against master revision 69700bf.

        -1 @author. The patch appears to contain 4 @author tags which the Tajo community has agreed to not allow in code contributions.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 212 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend tajo-core/tajo-core-storage.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/51//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/51//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/51//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-storage.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/51//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12623419/TAJO-508_2.patch against master revision 69700bf. -1 @author. The patch appears to contain 4 @author tags which the Tajo community has agreed to not allow in code contributions. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 212 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend tajo-core/tajo-core-storage. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/51//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/51//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/51//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-storage.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/51//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        +1

        The patch looks nice. The remain warnings appear some kind of TODO list

        Show
        hyunsik Hyunsik Choi added a comment - +1 The patch looks nice. The remain warnings appear some kind of TODO list
        Hide
        jhkim Jinho Kim added a comment -

        Thank you for the review.
        I've just committed it.

        Show
        jhkim Jinho Kim added a comment - Thank you for the review. I've just committed it.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #15 (See https://builds.apache.org/job/Tajo-master-build/15/)
        TAJO-508: Apply findbugs-excludeFilterFile to TajoQA. (jinho) (jinossy: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=b822c288274bd7863d8a4de9c41060b321906894)

        • dev-support/test-patch.sh
        • tajo-project/pom.xml
        • tajo-core/tajo-core-storage/pom.xml
        • tajo-core/tajo-core-backend/src/main/findbugs/findbugs-exclude.xml
        • pom.xml
        • CHANGES.txt
        • dev-support/findbugs-exclude.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #15 (See https://builds.apache.org/job/Tajo-master-build/15/ ) TAJO-508 : Apply findbugs-excludeFilterFile to TajoQA. (jinho) (jinossy: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=b822c288274bd7863d8a4de9c41060b321906894 ) dev-support/test-patch.sh tajo-project/pom.xml tajo-core/tajo-core-storage/pom.xml tajo-core/tajo-core-backend/src/main/findbugs/findbugs-exclude.xml pom.xml CHANGES.txt dev-support/findbugs-exclude.xml

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development