Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: Storage
    • Labels:
      None

      Description

      Suppose a following table.

      CREATE TABLE t1 (logtime DATE, user TEXT);
      

      When I run the following query, I met an error that DATE type cannot be supported by RawFile.

      select * from t1 order by logtime limit 10;
      

      The detailed error logs are as follows.

      2014-01-16 12:51:35,799 ERROR worker.Task (Task.java:run(378)) - java.io.IOException: Cannot support data type: DATE
              at org.apache.tajo.storage.RawFile$RawFileAppender.addTuple(RawFile.java:485)
              at org.apache.tajo.engine.planner.physical.RangeShuffleFileWriteExec.next(RangeShuffleFileWriteExec.java:100)
              at org.apache.tajo.worker.Task.run(Task.java:370)
              at org.apache.tajo.worker.TaskRunner$1.run(TaskRunner.java:392)
              at java.lang.Thread.run(Thread.java:701)
      

        Activity

        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-build #45 (See https://builds.apache.org/job/Tajo-master-build/45/)
        TAJO-506: RawFile cannot support DATE type. (jinho) (jinossy: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=567183fc20e10d56390fd1b14052d082c6ef4623)

        • tajo-core/tajo-core-backend/src/test/resources/queries/TestSortQuery/testSortWithDate.sql
        • tajo-common/src/main/java/org/apache/tajo/datum/TimestampDatum.java
        • tajo-storage/src/test/java/org/apache/tajo/storage/TestStorages.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/RangePartitionAlgorithm.java
        • tajo-core/tajo-core-backend/src/test/resources/dataset/TestSortQuery/table1.tbl
        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/test/resources/results/TestSortQuery/testSortWithDate.result
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestSortQuery.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/RowStoreUtil.java
        • tajo-core/tajo-core-backend/src/test/resources/queries/TestSortQuery/create_table_with_date_ddl.sql
        • tajo-common/src/test/java/org/apache/tajo/datum/TestTimestampDatum.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/StorageUtil.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/RawFile.java
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-build #45 (See https://builds.apache.org/job/Tajo-master-build/45/ ) TAJO-506 : RawFile cannot support DATE type. (jinho) (jinossy: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=567183fc20e10d56390fd1b14052d082c6ef4623 ) tajo-core/tajo-core-backend/src/test/resources/queries/TestSortQuery/testSortWithDate.sql tajo-common/src/main/java/org/apache/tajo/datum/TimestampDatum.java tajo-storage/src/test/java/org/apache/tajo/storage/TestStorages.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/RangePartitionAlgorithm.java tajo-core/tajo-core-backend/src/test/resources/dataset/TestSortQuery/table1.tbl CHANGES.txt tajo-core/tajo-core-backend/src/test/resources/results/TestSortQuery/testSortWithDate.result tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestSortQuery.java tajo-storage/src/main/java/org/apache/tajo/storage/RowStoreUtil.java tajo-core/tajo-core-backend/src/test/resources/queries/TestSortQuery/create_table_with_date_ddl.sql tajo-common/src/test/java/org/apache/tajo/datum/TestTimestampDatum.java tajo-storage/src/main/java/org/apache/tajo/storage/StorageUtil.java tajo-storage/src/main/java/org/apache/tajo/storage/RawFile.java
        Hide
        jhkim Jinho Kim added a comment -

        Thank you for the review.
        I've just committed it to master branch.

        Show
        jhkim Jinho Kim added a comment - Thank you for the review. I've just committed it to master branch.
        Hide
        jihoonson Jihoon Son added a comment - - edited

        +1
        This patch works well on a real cluster.

        Show
        jihoonson Jihoon Son added a comment - - edited +1 This patch works well on a real cluster.
        Hide
        hyunsik Hyunsik Choi added a comment -

        +1
        The patch looks nice and includes all necessary unit tests.

        Show
        hyunsik Hyunsik Choi added a comment - +1 The patch looks nice and includes all necessary unit tests.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12625829/TAJO-506.patch
        against master revision 179a707.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 7 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 212 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-common tajo-core/tajo-core-backend tajo-storage.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/92//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/92//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/92//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/92//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12625829/TAJO-506.patch against master revision 179a707. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 212 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-common tajo-core/tajo-core-backend tajo-storage. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/92//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/92//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/92//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/92//console This message is automatically generated.
        Hide
        jhkim Jinho Kim added a comment -

        In addition, I added time and timestamp

        Show
        jhkim Jinho Kim added a comment - In addition, I added time and timestamp
        Hide
        jhkim Jinho Kim added a comment -

        Created a review request against branch master in reviewboard
        https://reviews.apache.org/r/17491/

        Show
        jhkim Jinho Kim added a comment - Created a review request against branch master in reviewboard https://reviews.apache.org/r/17491/

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jihoonson Jihoon Son
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development