Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-499

Shorten the length of classpath in shell command

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently TAJO uses as a file-by-file in the classpath. When type ps command, Tajo's process command line is too long.
      Hadoop uses wildcard in classpath like "lib/*".

      1. TAJO-499.patch
        2 kB
        Hyoungjun Kim

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #15 (See https://builds.apache.org/job/Tajo-master-build/15/)
        TAJO-499: Shorten the length of classpath in shell command. (hyoungjunkim via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=35a710379d41f5d31f7c3928e33ed3ffed51cc7f)

        • CHANGES.txt
        • tajo-dist/src/main/bin/tajo
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #15 (See https://builds.apache.org/job/Tajo-master-build/15/ ) TAJO-499 : Shorten the length of classpath in shell command. (hyoungjunkim via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=35a710379d41f5d31f7c3928e33ed3ffed51cc7f ) CHANGES.txt tajo-dist/src/main/bin/tajo
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master. Thanks!

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master. Thanks!
        Hide
        charsyam DaeMyung Kang added a comment -

        +1.
        It works well with tsql

        Show
        charsyam DaeMyung Kang added a comment - +1. It works well with tsql
        Hide
        jhkim Jinho Kim added a comment -

        ++++1
        I really need it

        Show
        jhkim Jinho Kim added a comment - ++++1 I really need it
        Hide
        hyunsik Hyunsik Choi added a comment -

        +1

        The patch looks good for me. TajoQA gave -1 due to test included. Actually, it doesn't need unit test since this patch only changes shell script.

        Show
        hyunsik Hyunsik Choi added a comment - +1 The patch looks good for me. TajoQA gave -1 due to test included. Actually, it doesn't need unit test since this patch only changes shell script.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12623364/TAJO-499.patch
        against master revision 69700bf.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-dist.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/47//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/47//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12623364/TAJO-499.patch against master revision 69700bf. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-dist. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/47//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/47//console This message is automatically generated.
        Hide
        hjkim Hyoungjun Kim added a comment -

        I changed the followings in bin/tajo.

        • remove *.xml from classpath
        • remove all jars in lib from classpath
        • add lib/* to classpath
        • export CLASSPATH
        • remove -classpath $CLASSPATH from exec command line

        The following is Tajo's daemon process list after changing .

        $ ps -ef | grep TajoMaster
        hadoop   31402     1 17 21:10 pts/0    00:00:07 /usr/java/default/bin/java -Dproc_master -XX:+PrintGCTimeStamps -Xmx2000m -Dtajo.log.dir=/home/hadoop/tajo/logs -Dtajo.log.file=tajo-hadoop-master-gruter101.gruter.com.log -Dtajo.home.dir=/home/hadoop/tajo -Dtajo.id.str=hadoop -Dtajo.root.logger=INFO,DRFA -Djava.library.path=/home/hadoop/hadoop-2.2.0/lib/native/ -Dtajo.policy.file=tajo-policy.xml org.apache.tajo.master.TajoMaster
        
        $ ps -ef | grep TajoWorker
        hadoop   30927     1  9 21:10 ?        00:00:08 /usr/java/default/bin/java -Dproc_worker -XX:+PrintGCTimeStamps -Xmx8000m -Dtajo.log.dir=/home/hadoop/tajo/logs -Dtajo.log.file=tajo-hadoop-worker-gruter104.gruter.com.log -Dtajo.home.dir=/home/hadoop/tajo -Dtajo.id.str=hadoop -Dtajo.root.logger=INFO,DRFA -Djava.library.path=/home/hadoop/hadoop-2.2.0/lib/native/ -Dtajo.policy.file=tajo-policy.xml org.apache.tajo.worker.TajoWorker
        

        Please review this patch.

        Show
        hjkim Hyoungjun Kim added a comment - I changed the followings in bin/tajo. remove *.xml from classpath remove all jars in lib from classpath add lib/* to classpath export CLASSPATH remove -classpath $CLASSPATH from exec command line The following is Tajo's daemon process list after changing . $ ps -ef | grep TajoMaster hadoop 31402 1 17 21:10 pts/0 00:00:07 /usr/java/ default /bin/java -Dproc_master -XX:+PrintGCTimeStamps -Xmx2000m -Dtajo.log.dir=/home/hadoop/tajo/logs -Dtajo.log.file=tajo-hadoop-master-gruter101.gruter.com.log -Dtajo.home.dir=/home/hadoop/tajo -Dtajo.id.str=hadoop -Dtajo.root.logger=INFO,DRFA -Djava.library.path=/home/hadoop/hadoop-2.2.0/lib/ native / -Dtajo.policy.file=tajo-policy.xml org.apache.tajo.master.TajoMaster $ ps -ef | grep TajoWorker hadoop 30927 1 9 21:10 ? 00:00:08 /usr/java/ default /bin/java -Dproc_worker -XX:+PrintGCTimeStamps -Xmx8000m -Dtajo.log.dir=/home/hadoop/tajo/logs -Dtajo.log.file=tajo-hadoop-worker-gruter104.gruter.com.log -Dtajo.home.dir=/home/hadoop/tajo -Dtajo.id.str=hadoop -Dtajo.root.logger=INFO,DRFA -Djava.library.path=/home/hadoop/hadoop-2.2.0/lib/ native / -Dtajo.policy.file=tajo-policy.xml org.apache.tajo.worker.TajoWorker Please review this patch.

          People

          • Assignee:
            hjkim Hyoungjun Kim
            Reporter:
            hjkim Hyoungjun Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development