Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: Function/UDF
    • Labels:
      None

      Description

      digest(text, 'md2')
      digest(text, 'md5')
      digest(text, 'sha1')
      digest(text, 'sha256')
      digest(text, 'sha384')
      digest(text, 'sha512')

      1. TAJO-498.2.patch
        5 kB
        DaeMyung Kang
      2. TAJO-498.patch
        6 kB
        DaeMyung Kang

        Activity

        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-build #20 (See https://builds.apache.org/job/Tajo-master-build/20/)
        TAJO-498: Implement digest(text, text) function. (DaeMyung Kang via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=9af2fca12204648a16759aedf75a0234b438ae9b)

        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/string/Digest.java
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-build #20 (See https://builds.apache.org/job/Tajo-master-build/20/ ) TAJO-498 : Implement digest(text, text) function. (DaeMyung Kang via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=9af2fca12204648a16759aedf75a0234b438ae9b ) CHANGES.txt tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/string/Digest.java
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master branch. Thanks!

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master branch. Thanks!
        Hide
        hyunsik Hyunsik Choi added a comment -

        +1

        The patch looks nice.

        Show
        hyunsik Hyunsik Choi added a comment - +1 The patch looks nice.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12623950/TAJO-498.2.patch
        against master revision d04f9a5.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 158 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/67//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/67//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/67//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12623950/TAJO-498.2.patch against master revision d04f9a5. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 158 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/67//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/67//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/67//console This message is automatically generated.
        Hide
        charsyam DaeMyung Kang added a comment -

        I rebased patch and uploaded it.

        Thank you.

        Show
        charsyam DaeMyung Kang added a comment - I rebased patch and uploaded it. Thank you.
        Hide
        hyunsik Hyunsik Choi added a comment -

        The patch looks good for me. But, this issue may be conflict to TAJO-409. BTW, this is relatively trivial. So, I'll review this after TAJO-409.

        Show
        hyunsik Hyunsik Choi added a comment - The patch looks good for me. But, this issue may be conflict to TAJO-409 . BTW, this is relatively trivial. So, I'll review this after TAJO-409 .
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12622667/TAJO-498.patch
        against master revision 69700bf.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 546 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/44//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/44//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/44//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12622667/TAJO-498.patch against master revision 69700bf. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 546 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/44//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/44//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/44//console This message is automatically generated.
        Hide
        charsyam DaeMyung Kang added a comment -

        Please review this patch.

        Show
        charsyam DaeMyung Kang added a comment - Please review this patch.

          People

          • Assignee:
            charsyam DaeMyung Kang
            Reporter:
            charsyam DaeMyung Kang
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development