Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Duplicate
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: Function/UDF
    • Labels:
      None

      Description

      sha1('1') ---> 356a192b7913b04c54574d18c28d46e6395428ab
      sha1('tajo') ---> 02b0e20540b89f0b735092bbac8093eb2e3804cf

      1. TAJO-495.patch
        4 kB
        DaeMyung Kang

        Activity

        Hide
        charsyam DaeMyung Kang added a comment -

        Please reivew this patch.

        Show
        charsyam DaeMyung Kang added a comment - Please reivew this patch.
        Hide
        jihoonson Jihoon Son added a comment -

        This patch looks good to me, but I couldn't verify tests due to a problem of my machine.
        Would anyone verify the patch, please?

        Show
        jihoonson Jihoon Son added a comment - This patch looks good to me, but I couldn't verify tests due to a problem of my machine. Would anyone verify the patch, please?
        Hide
        sirpkt Keuntae Park added a comment -

        It works fine as it passes 'mvn clean install' successfully.

        However, how about implementing more generalized function 'digest' like PostgreSQL?

        digest(text, type), where type can be one of md5, sha1, sha224, sha256, sha384 and sha512.
        (http://www.postgresql.org/docs/9.3/static/pgcrypto.html)

        Show
        sirpkt Keuntae Park added a comment - It works fine as it passes 'mvn clean install' successfully. However, how about implementing more generalized function 'digest' like PostgreSQL? digest(text, type), where type can be one of md5, sha1, sha224, sha256, sha384 and sha512. ( http://www.postgresql.org/docs/9.3/static/pgcrypto.html )
        Hide
        charsyam DaeMyung Kang added a comment -

        Keuntae Park
        I just think SHA-1 is also popular hash function like md5.
        so I might think it is better to use "sha1" function directly.

        but I think your opinion makes sense.
        so I make new issue to support digest also.
        (https://issues.apache.org/jira/browse/TAJO-498)

        what do you think about this?

        Show
        charsyam DaeMyung Kang added a comment - Keuntae Park I just think SHA-1 is also popular hash function like md5. so I might think it is better to use "sha1" function directly. but I think your opinion makes sense. so I make new issue to support digest also. ( https://issues.apache.org/jira/browse/TAJO-498 ) what do you think about this?
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12622491/TAJO-495.patch
        against master revision 69700bf.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 546 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/45//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/45//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/45//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12622491/TAJO-495.patch against master revision 69700bf. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 546 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/45//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/45//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/45//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        +1 for only digest

        Both claims are all reasonable. I've considered it in many aspects for a while. Regarding code maintenance and consistency of user experience, I prefer only digest support.

        Actually, other hashing functions (e.g., md5, sha512) are widely used too. For example, if we support sha1 and do not support sha512, it may cause inconsistency. It may be confuse for users.

        Show
        hyunsik Hyunsik Choi added a comment - +1 for only digest Both claims are all reasonable. I've considered it in many aspects for a while. Regarding code maintenance and consistency of user experience, I prefer only digest support. Actually, other hashing functions (e.g., md5, sha512) are widely used too. For example, if we support sha1 and do not support sha512, it may cause inconsistency. It may be confuse for users.
        Hide
        charsyam DaeMyung Kang added a comment -

        TAJO-498 contains this issue. so I just make this issue duplicated.

        Show
        charsyam DaeMyung Kang added a comment - TAJO-498 contains this issue. so I just make this issue duplicated.

          People

          • Assignee:
            charsyam DaeMyung Kang
            Reporter:
            charsyam DaeMyung Kang
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development