Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-480

Umbrella Jira for adding ALTER TABLE statement

    Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0, 0.9.0
    • Component/s: Catalog, SQL Parser
    • Labels:

      Description

      ALTER TABLE statement is necessary feature for modifying meta data in catalog. This is an umbrella jira for adding ALTER TABLE statement. We will make additional jira issues.

      1. rename_patch.patch
        14 kB
        Hyunsik Choi
      2. TAJO-480.Henrick.03.patch.txt
        95 kB
        Alvin Henrick
      3. TAJO-480.Henrick.04.patch.txt
        116 kB
        Alvin Henrick
      4. TAJO-480.Henrick.06.patch.txt
        138 kB
        Alvin Henrick

        Issue Links

          Activity

          Hide
          jihoonson Jihoon Son added a comment -

          +1 for this issue.
          Since the ALTER TABLE statement is widely used, we should support it.

          Show
          jihoonson Jihoon Son added a comment - +1 for this issue. Since the ALTER TABLE statement is widely used, we should support it.
          Hide
          hyunsik Hyunsik Choi added a comment -

          Thank you Alvin Henrick for taking this issue.

          Show
          hyunsik Hyunsik Choi added a comment - Thank you Alvin Henrick for taking this issue.
          Hide
          alvinhenrick Alvin Henrick added a comment -

          You are welcome Hyunsik. It's going to be very big commit ...I will post the patch for review very soon.I am almost done with rename table , rename column and currently working on add column.

          Show
          alvinhenrick Alvin Henrick added a comment - You are welcome Hyunsik. It's going to be very big commit ...I will post the patch for review very soon.I am almost done with rename table , rename column and currently working on add column.
          Hide
          jhkim Jinho Kim added a comment -

          Great Alvin Henrick!
          I'm looking forward to your contribution.

          Show
          jhkim Jinho Kim added a comment - Great Alvin Henrick ! I'm looking forward to your contribution.
          Hide
          alvinhenrick Alvin Henrick added a comment -

          1) Implemented Alter Table.
          2) Made changes to various component like algebra,parser,catalog,planner and engine etc.
          3) Only implemented MemStore for review.Before I proceed any further felt like it needs to be reviewed.
          4) Need to implement AbstractDBStore.WIP
          5) Need to improve exception handling and logging.WIP.

          Please feel free to advice comment. Appreciate your help in reviewing the code.

          Link to review page ==> https://reviews.apache.org/r/19685/

          Thanks!
          Warm Regards,
          Alvin.

          Show
          alvinhenrick Alvin Henrick added a comment - 1) Implemented Alter Table. 2) Made changes to various component like algebra,parser,catalog,planner and engine etc. 3) Only implemented MemStore for review.Before I proceed any further felt like it needs to be reviewed. 4) Need to implement AbstractDBStore.WIP 5) Need to improve exception handling and logging.WIP. Please feel free to advice comment. Appreciate your help in reviewing the code. Link to review page ==> https://reviews.apache.org/r/19685/ Thanks! Warm Regards, Alvin.
          Hide
          hyunsik Hyunsik Choi added a comment -

          Alvin,

          You did incredible work for short time!
          Since the patch is big, I'll finish the review as soon as possible.

          Best regards,
          Hyunsik

          Show
          hyunsik Hyunsik Choi added a comment - Alvin, You did incredible work for short time! Since the patch is big, I'll finish the review as soon as possible. Best regards, Hyunsik
          Hide
          alvinhenrick Alvin Henrick added a comment -

          Hyunsik ,
          Can I fork this repository https://github.com/apache/tajo.git instead of this https://git-wip-us.apache.org/repos/asf/tajo.git . Are they always in sink ???

          It's easier to fork the repository and get upstream changes and send the pull request.

          I don't think so I have direct commit rights but fork , pull and merge are the best features of git.

          Thanks!
          Warm Regards,
          Alvin.

          Show
          alvinhenrick Alvin Henrick added a comment - Hyunsik , Can I fork this repository https://github.com/apache/tajo.git instead of this https://git-wip-us.apache.org/repos/asf/tajo.git . Are they always in sink ??? It's easier to fork the repository and get upstream changes and send the pull request. I don't think so I have direct commit rights but fork , pull and merge are the best features of git. Thanks! Warm Regards, Alvin.
          Hide
          hyunsik Hyunsik Choi added a comment -

          Hi Alvin,

          They are synchronized, but github mirror has small delay. I think that this delay would not be a problem.

          I also think that easy pull and merge will reduce our burden of lots of git command typing. Since we cannot directly merge the pull requests into our code via Github, there are an alternative way to make pull and merge process easier. Please take a look at this mailing list thread (http://markmail.org/message/g43orpozb6hoymg5).

          After I discuss it in dev mailing list, I'll ask this feature to ASF infra team. I think that we can use this github support soon. I hope that you enjoy Tajo contribution.

          Thanks,
          Hyunsik

          Show
          hyunsik Hyunsik Choi added a comment - Hi Alvin, They are synchronized, but github mirror has small delay. I think that this delay would not be a problem. I also think that easy pull and merge will reduce our burden of lots of git command typing. Since we cannot directly merge the pull requests into our code via Github, there are an alternative way to make pull and merge process easier. Please take a look at this mailing list thread ( http://markmail.org/message/g43orpozb6hoymg5 ). After I discuss it in dev mailing list, I'll ask this feature to ASF infra team. I think that we can use this github support soon. I hope that you enjoy Tajo contribution. Thanks, Hyunsik
          Hide
          alvinhenrick Alvin Henrick added a comment -

          Please find the patch attached.The only thing left is AbstractDBStore implementation. Currently working on it.

          At present it only supports MemStore.

          Thanks!
          Warm Regards,
          Alvin.

          Show
          alvinhenrick Alvin Henrick added a comment - Please find the patch attached.The only thing left is AbstractDBStore implementation. Currently working on it. At present it only supports MemStore. Thanks! Warm Regards, Alvin.
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12637243/TAJO-480.Henrick.03.patch.txt
          against master revision 9d00f9f.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 7 new or modified test files.

          -1 javac. The patch appears to cause the build to fail.

          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/273//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12637243/TAJO-480.Henrick.03.patch.txt against master revision 9d00f9f. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified test files. -1 javac. The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/273//console This message is automatically generated.
          Hide
          hyunsik Hyunsik Choi added a comment -

          Even though Tajo QA seems to be failed due to hunk merge, I could apply successfully your latest patch. I'll review the patch today's night.

          Show
          hyunsik Hyunsik Choi added a comment - Even though Tajo QA seems to be failed due to hunk merge, I could apply successfully your latest patch. I'll review the patch today's night.
          Hide
          alvinhenrick Alvin Henrick added a comment -

          Done!!!. End to End solution implemented.
          Added new unit test in TestCatalog to verify various drivers.

          Show
          alvinhenrick Alvin Henrick added a comment - Done!!!. End to End solution implemented. Added new unit test in TestCatalog to verify various drivers.
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12637605/TAJO-480.Henrick.04.patch.txt
          against master revision bbbf21d.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified test files.

          -1 javac. The patch appears to cause the build to fail.

          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/283//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12637605/TAJO-480.Henrick.04.patch.txt against master revision bbbf21d. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 8 new or modified test files. -1 javac. The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/283//console This message is automatically generated.
          Hide
          hyunsik Hyunsik Choi added a comment -

          Excellent! I'm reviewing and testing the latest patch. I'll comment soon.

          Show
          hyunsik Hyunsik Choi added a comment - Excellent! I'm reviewing and testing the latest patch. I'll comment soon.
          Hide
          hyunsik Hyunsik Choi added a comment - - edited

          Hi Alvin Henrick,

          I just made some trivial patch. It fixes an already-existing bug of table paths and add some unit tests to verify the bugs. This patch only contains the difference from your patch. So, you can directly apply it on your work. I hope that this patch will be included in your work.

          Best regards,
          Hyunsik Choi

          Show
          hyunsik Hyunsik Choi added a comment - - edited Hi Alvin Henrick , I just made some trivial patch. It fixes an already-existing bug of table paths and add some unit tests to verify the bugs. This patch only contains the difference from your patch. So, you can directly apply it on your work. I hope that this patch will be included in your work. Best regards, Hyunsik Choi
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12637774/rename_patch.patch
          against master revision 40851e5.

          -1 patch. The patch command could not apply the patch.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified test files.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/286//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12637774/rename_patch.patch against master revision 40851e5. -1 patch. The patch command could not apply the patch. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/286//console This message is automatically generated.
          Hide
          alvinhenrick Alvin Henrick added a comment -

          The final working patch. What a relief

          Thanks Hyunsik for your help.

          Show
          alvinhenrick Alvin Henrick added a comment - The final working patch. What a relief Thanks Hyunsik for your help.
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12637844/TAJO-480.Henrick.06.patch.txt
          against master revision 40851e5.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 14 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-algebra tajo-catalog/tajo-catalog-client tajo-catalog/tajo-catalog-common tajo-catalog/tajo-catalog-drivers/tajo-hcatalog tajo-catalog/tajo-catalog-server tajo-core/tajo-core-backend.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/290//testReport/
          Findbugs results: https://builds.apache.org/job/PreCommit-TAJO-Build/290//findbugsResult
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/290//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12637844/TAJO-480.Henrick.06.patch.txt against master revision 40851e5. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 14 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-algebra tajo-catalog/tajo-catalog-client tajo-catalog/tajo-catalog-common tajo-catalog/tajo-catalog-drivers/tajo-hcatalog tajo-catalog/tajo-catalog-server tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/290//testReport/ Findbugs results: https://builds.apache.org/job/PreCommit-TAJO-Build/290//findbugsResult Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/290//console This message is automatically generated.
          Hide
          hyunsik Hyunsik Choi added a comment -

          +1 for the latest patch. You just added a big feature to Tajo. Thank you for your nice contribution!

          Show
          hyunsik Hyunsik Choi added a comment - +1 for the latest patch. You just added a big feature to Tajo. Thank you for your nice contribution!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #149 (See https://builds.apache.org/job/Tajo-master-build/149/)
          TAJO-480: Umbrella Jira for adding ALTER TABLE statement. (Alvin Henrick via hyunsik) (hyunsik: rev bd418a5c3edb8bb8df4be31866a5d3ec9b407f88)

          • tajo-algebra/src/main/java/org/apache/tajo/algebra/ColumnDefinition.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java
          • tajo-docs/src/main/sphinx/functions/datetime_func_and_operators.rst
          • tajo-core/tajo-core-backend/src/test/resources/queries/TestDropTable/table1_ddl.sql
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/SimpleAlgebraVisitor.java
          • tajo-core/tajo-core-backend/src/test/resources/dataset/TestDropTable/table1.tbl
          • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestDropTable.java
          • tajo-catalog/tajo-catalog-client/src/main/proto/CatalogProtocol.proto
          • CHANGES.txt
          • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
          • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanVisitor.java
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/ColumnNameAlreadyExistException.java
          • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BasicLogicalPlanVisitor.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/NodeType.java
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableType.java
          • tajo-algebra/src/main/java/org/apache/tajo/algebra/AlterTableOpType.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/AlgebraVisitor.java
          • tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto
          • tajo-algebra/src/main/java/org/apache/tajo/algebra/AlterTable.java
          • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/HiveQLAnalyzer.java
          • tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java
          • tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/CatalogService.java
          • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java
          • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/GlobalEngine.java
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
          • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java
          • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/QueryTestCaseBase.java
          • tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLLexer.g4
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java
          • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestAlterTable.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PlannerUtil.java
          • tajo-algebra/src/main/java/org/apache/tajo/algebra/OpType.java
          • tajo-core/tajo-core-backend/src/test/resources/queries/TestAlterTable/table1_ddl.sql
          • tajo-core/tajo-core-backend/src/test/resources/queries/TestAlterTable/alter_table_add_new_column_ddl.sql
          • tajo-core/tajo-core-backend/src/test/resources/queries/TestDropTable/drop_table_ddl.sql
          • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BaseAlgebraVisitor.java
          • tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4
          • tajo-core/tajo-core-backend/src/test/resources/dataset/TestAlterTable/table1.tbl
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanPreprocessor.java
          • tajo-core/tajo-core-backend/src/test/resources/queries/TestAlterTable/alter_table_rename_table_ddl.sql
          • tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java
          • tajo-core/tajo-core-backend/src/test/resources/queries/TestAlterTable/alter_table_rename_column_ddl.sql
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/AlterTableNode.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #149 (See https://builds.apache.org/job/Tajo-master-build/149/ ) TAJO-480 : Umbrella Jira for adding ALTER TABLE statement. (Alvin Henrick via hyunsik) (hyunsik: rev bd418a5c3edb8bb8df4be31866a5d3ec9b407f88) tajo-algebra/src/main/java/org/apache/tajo/algebra/ColumnDefinition.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java tajo-docs/src/main/sphinx/functions/datetime_func_and_operators.rst tajo-core/tajo-core-backend/src/test/resources/queries/TestDropTable/table1_ddl.sql tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/SimpleAlgebraVisitor.java tajo-core/tajo-core-backend/src/test/resources/dataset/TestDropTable/table1.tbl tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestDropTable.java tajo-catalog/tajo-catalog-client/src/main/proto/CatalogProtocol.proto CHANGES.txt tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanVisitor.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/ColumnNameAlreadyExistException.java tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BasicLogicalPlanVisitor.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/NodeType.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableType.java tajo-algebra/src/main/java/org/apache/tajo/algebra/AlterTableOpType.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/AlgebraVisitor.java tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto tajo-algebra/src/main/java/org/apache/tajo/algebra/AlterTable.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/HiveQLAnalyzer.java tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/CatalogService.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/QueryTestCaseBase.java tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLLexer.g4 tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestAlterTable.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PlannerUtil.java tajo-algebra/src/main/java/org/apache/tajo/algebra/OpType.java tajo-core/tajo-core-backend/src/test/resources/queries/TestAlterTable/table1_ddl.sql tajo-core/tajo-core-backend/src/test/resources/queries/TestAlterTable/alter_table_add_new_column_ddl.sql tajo-core/tajo-core-backend/src/test/resources/queries/TestDropTable/drop_table_ddl.sql tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BaseAlgebraVisitor.java tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4 tajo-core/tajo-core-backend/src/test/resources/dataset/TestAlterTable/table1.tbl tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanPreprocessor.java tajo-core/tajo-core-backend/src/test/resources/queries/TestAlterTable/alter_table_rename_table_ddl.sql tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java tajo-core/tajo-core-backend/src/test/resources/queries/TestAlterTable/alter_table_rename_column_ddl.sql tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/AlterTableNode.java
          Hide
          hyunsik Hyunsik Choi added a comment -

          committed it to master and branch-0.8.0. Thank you Alvin!

          Show
          hyunsik Hyunsik Choi added a comment - committed it to master and branch-0.8.0. Thank you Alvin!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-0.8.0-build #53 (See https://builds.apache.org/job/Tajo-0.8.0-build/53/)
          TAJO-480: Umbrella Jira for adding ALTER TABLE statement. (Alvin Henrick via hyunsik) (hyunsik: rev f75c2e59b52fe089af9d30dd8b6a8cdccd646294)

          • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableType.java
          • tajo-core/tajo-core-backend/src/test/resources/queries/TestAlterTable/alter_table_rename_table_ddl.sql
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java
          • tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table2_ddl.sql
          • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestAlterTable.java
          • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BaseAlgebraVisitor.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/ColumnNameAlreadyExistException.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/NodeType.java
          • tajo-core/tajo-core-backend/src/test/resources/queries/TestDropTable/table1_ddl.sql
          • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/HiveQLAnalyzer.java
          • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BasicLogicalPlanVisitor.java
          • tajo-docs/src/main/sphinx/functions/datetime_func_and_operators.rst
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java
          • tajo-core/tajo-core-backend/src/test/resources/queries/TestAlterTable/table1_ddl.sql
          • tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java
          • tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java
          • tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table1_ddl.sql
          • tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4
          • tajo-core/tajo-core-backend/src/test/resources/dataset/TestAlterTable/table1.tbl
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanPreprocessor.java
          • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestDropTable.java
          • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java
          • tajo-core/tajo-core-backend/src/test/resources/queries/TestAlterTable/alter_table_rename_column_ddl.sql
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/AlgebraVisitor.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanVisitor.java
          • tajo-core/tajo-core-backend/src/test/resources/queries/TestAlterTable/alter_table_add_new_column_ddl.sql
          • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
          • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/QueryTestCaseBase.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PlannerUtil.java
          • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNetTypes.java
          • tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/CatalogService.java
          • tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto
          • tajo-algebra/src/main/java/org/apache/tajo/algebra/ColumnDefinition.java
          • tajo-catalog/tajo-catalog-client/src/main/proto/CatalogProtocol.proto
          • tajo-algebra/src/main/java/org/apache/tajo/algebra/AlterTableOpType.java
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
          • tajo-core/tajo-core-backend/src/test/resources/dataset/TestDropTable/table1.tbl
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/SimpleAlgebraVisitor.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/AlterTableNode.java
          • tajo-algebra/src/main/java/org/apache/tajo/algebra/AlterTable.java
          • tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLLexer.g4
          • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java
          • CHANGES.txt
          • tajo-algebra/src/main/java/org/apache/tajo/algebra/OpType.java
          • tajo-core/tajo-core-backend/src/test/resources/queries/TestDropTable/drop_table_ddl.sql
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/GlobalEngine.java
          • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.8.0-build #53 (See https://builds.apache.org/job/Tajo-0.8.0-build/53/ ) TAJO-480 : Umbrella Jira for adding ALTER TABLE statement. (Alvin Henrick via hyunsik) (hyunsik: rev f75c2e59b52fe089af9d30dd8b6a8cdccd646294) tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableType.java tajo-core/tajo-core-backend/src/test/resources/queries/TestAlterTable/alter_table_rename_table_ddl.sql tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table2_ddl.sql tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestAlterTable.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BaseAlgebraVisitor.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/ColumnNameAlreadyExistException.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/NodeType.java tajo-core/tajo-core-backend/src/test/resources/queries/TestDropTable/table1_ddl.sql tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/HiveQLAnalyzer.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BasicLogicalPlanVisitor.java tajo-docs/src/main/sphinx/functions/datetime_func_and_operators.rst tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java tajo-core/tajo-core-backend/src/test/resources/queries/TestAlterTable/table1_ddl.sql tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/table1_ddl.sql tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4 tajo-core/tajo-core-backend/src/test/resources/dataset/TestAlterTable/table1.tbl tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanPreprocessor.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestDropTable.java tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java tajo-core/tajo-core-backend/src/test/resources/queries/TestAlterTable/alter_table_rename_column_ddl.sql tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/AlgebraVisitor.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanVisitor.java tajo-core/tajo-core-backend/src/test/resources/queries/TestAlterTable/alter_table_add_new_column_ddl.sql tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/QueryTestCaseBase.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PlannerUtil.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNetTypes.java tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/CatalogService.java tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto tajo-algebra/src/main/java/org/apache/tajo/algebra/ColumnDefinition.java tajo-catalog/tajo-catalog-client/src/main/proto/CatalogProtocol.proto tajo-algebra/src/main/java/org/apache/tajo/algebra/AlterTableOpType.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java tajo-core/tajo-core-backend/src/test/resources/dataset/TestDropTable/table1.tbl tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/SimpleAlgebraVisitor.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/AlterTableNode.java tajo-algebra/src/main/java/org/apache/tajo/algebra/AlterTable.java tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLLexer.g4 tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java CHANGES.txt tajo-algebra/src/main/java/org/apache/tajo/algebra/OpType.java tajo-core/tajo-core-backend/src/test/resources/queries/TestDropTable/drop_table_ddl.sql tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java

            People

            • Assignee:
              alvinhenrick Alvin Henrick
              Reporter:
              hyunsik Hyunsik Choi
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development