Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-478

Add request-patch-review.py that helps submitting patches to jira and reviewboard.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None

      Description

      As we discussed the recent review process, review requests to reviewboard are strongly recommended in Tajo project.

      http://markmail.org/message/rszy3knctczko23d#query:+page:1+mid:qnozgapggzmwxqrw+state:results

      This patch adds a helper utility to allow users to create a patch against a specified branch, submit the patch to a specified Jira, and create a review request in reviewboard.

      This utility is borrowed from Apache Kafka.
      https://github.com/apache/kafka/blob/trunk/kafka-patch-review.py

      But, I modified some options and add several new features, and this patch includes its documentation.

      1. TAJO-478_20140105_02:22:58.patch
        14 kB
        Hyunsik Choi
      2. TAJO-478_20140105_02:25:29.patch
        14 kB
        Hyunsik Choi
      3. TAJO-478_20140109_15:44:43.patch
        14 kB
        Hyunsik Choi
      4. TAJO-478_20140115_18:48:36.patch
        15 kB
        Hyunsik Choi
      5. TAJO-478_20140115_19:01:21.patch
        33 kB
        Hyunsik Choi
      6. TAJO-478_20140115_23:31:17.patch
        15 kB
        Hyunsik Choi
      7. TAJO-478.patch
        253 kB
        Hyunsik Choi

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #16 (See https://builds.apache.org/job/Tajo-master-build/16/)
        TAJO-478: Add request-patch-review.py that helps submitting patches to jira and reviewboard. (hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=568c52392e0e4532ac78df762137d43072d46cbc)

        • tajo-project/src/site/markdown/review-request-tool.md
        • tajo-project/src/site/site.xml
        • CHANGES.txt
        • request-patch-review.py
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #16 (See https://builds.apache.org/job/Tajo-master-build/16/ ) TAJO-478 : Add request-patch-review.py that helps submitting patches to jira and reviewboard. (hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=568c52392e0e4532ac78df762137d43072d46cbc ) tajo-project/src/site/markdown/review-request-tool.md tajo-project/src/site/site.xml CHANGES.txt request-patch-review.py
        Hide
        hyunsik Hyunsik Choi added a comment -

        Got +1 from RB, and committed it to master branch.

        Show
        hyunsik Hyunsik Choi added a comment - Got +1 from RB, and committed it to master branch.
        Hide
        hyunsik Hyunsik Choi added a comment -

        This patch includes only a python script and markdown document. So, we don't need to count Its test inclusion check.

        Show
        hyunsik Hyunsik Choi added a comment - This patch includes only a python script and markdown document. So, we don't need to count Its test inclusion check.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12623147/TAJO-478_20140115_23%3A31%3A17.patch
        against master revision 69700bf.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/43//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/43//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12623147/TAJO-478_20140115_23%3A31%3A17.patch against master revision 69700bf. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/43//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/43//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        Updated the review request against branch master in reviewboard
        https://reviews.apache.org/r/16635/

        Show
        hyunsik Hyunsik Choi added a comment - Updated the review request against branch master in reviewboard https://reviews.apache.org/r/16635/
        Hide
        hyunsik Hyunsik Choi added a comment -

        I uploaded wrong patch. I'll resubmit the latest patch.

        Show
        hyunsik Hyunsik Choi added a comment - I uploaded wrong patch. I'll resubmit the latest patch.
        Hide
        tajoqa Tajo QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12623107/TAJO-478_20140115_19%3A01%3A21.patch
        against master revision 69700bf.

        -1 @author. The patch appears to contain 6 @author tags which the Tajo community has agreed to not allow in code contributions.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/41//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/41//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12623107/TAJO-478_20140115_19%3A01%3A21.patch against master revision 69700bf. -1 @author. The patch appears to contain 6 @author tags which the Tajo community has agreed to not allow in code contributions. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/41//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/41//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        For several weeks, I've tested it. It works well. I think that the latest patch is ready to be committed. Please review it.

        Show
        hyunsik Hyunsik Choi added a comment - For several weeks, I've tested it. It works well. I think that the latest patch is ready to be committed. Please review it.
        Hide
        hyunsik Hyunsik Choi added a comment -

        Updated the review request against branch master in reviewboard
        https://reviews.apache.org/r/16635/

        Show
        hyunsik Hyunsik Choi added a comment - Updated the review request against branch master in reviewboard https://reviews.apache.org/r/16635/
        Hide
        hyunsik Hyunsik Choi added a comment -

        Updated the review request against branch master in reviewboard
        https://reviews.apache.org/r/16635/

        Show
        hyunsik Hyunsik Choi added a comment - Updated the review request against branch master in reviewboard https://reviews.apache.org/r/16635/
        Hide
        hyunsik Hyunsik Choi added a comment -

        Updated the review request against branch master in reviewboard
        https://reviews.apache.org/r/16635/

        Show
        hyunsik Hyunsik Choi added a comment - Updated the review request against branch master in reviewboard https://reviews.apache.org/r/16635/
        Hide
        hyunsik Hyunsik Choi added a comment -

        Updated the review request against branch master in reviewboard
        https://reviews.apache.org/r/16635/

        Show
        hyunsik Hyunsik Choi added a comment - Updated the review request against branch master in reviewboard https://reviews.apache.org/r/16635/
        Hide
        hyunsik Hyunsik Choi added a comment -

        Updated the review request against branch master in reviewboard
        https://reviews.apache.org/r/16635/

        Show
        hyunsik Hyunsik Choi added a comment - Updated the review request against branch master in reviewboard https://reviews.apache.org/r/16635/
        Hide
        hyunsik Hyunsik Choi added a comment -

        Created a review request against branch master in reviewboard
        https://reviews.apache.org/r/16635/

        Show
        hyunsik Hyunsik Choi added a comment - Created a review request against branch master in reviewboard https://reviews.apache.org/r/16635/

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development