Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: Planner/Optimizer
    • Labels:
      None

      Description

      This would be more convenient if we implement it.

      1. TAJO-460.diff
        11 kB
        Min Zhou
      2. TAJO-460-v2.diff
        11 kB
        Min Zhou

        Activity

        Hide
        coderplay Min Zhou added a comment -

        This patch intentionally evaded a schema problem described at TAJO-463, cuz this issue is for CTAS.

        Show
        coderplay Min Zhou added a comment - This patch intentionally evaded a schema problem described at TAJO-463 , cuz this issue is for CTAS.
        Hide
        hyunsik Hyunsik Choi added a comment -

        Nice job! the patch looks good for me.

        By the way, there is something to be checked. TestInsertQuery causes test failures after this patch because the following line causes NPE in some tests.

        473 line in GlobalEngine
        queryContext.setPartitions(storeTableNode.getPartitions());
        

        The main cause is that storeTableNode does not always have PartitionDesc instance.

        Besides, I'm expecting that you were very confuse because so far, we have used the word 'partition' to indicate shuffle. So, I've just created an refactoring issue (TAJO-464) to rename 'partition' actually meaning 'shuffle' to 'shuffle'.

        Thanks!

        Show
        hyunsik Hyunsik Choi added a comment - Nice job! the patch looks good for me. By the way, there is something to be checked. TestInsertQuery causes test failures after this patch because the following line causes NPE in some tests. 473 line in GlobalEngine queryContext.setPartitions(storeTableNode.getPartitions()); The main cause is that storeTableNode does not always have PartitionDesc instance. Besides, I'm expecting that you were very confuse because so far, we have used the word 'partition' to indicate shuffle. So, I've just created an refactoring issue ( TAJO-464 ) to rename 'partition' actually meaning 'shuffle' to 'shuffle'. Thanks!
        Hide
        coderplay Min Zhou added a comment -

        oops, My fault. I just test my case, didn't ran the whole cases in order to save time , cuz this could take me couple of hours. Is there anyway to trigger a auto testing by tools like hudson from this jira?

        Show
        coderplay Min Zhou added a comment - oops, My fault. I just test my case, didn't ran the whole cases in order to save time , cuz this could take me couple of hours. Is there anyway to trigger a auto testing by tools like hudson from this jira?
        Hide
        coderplay Min Zhou added a comment - - edited

        Solved the problem you mentioned and passed all test cases.

        Show
        coderplay Min Zhou added a comment - - edited Solved the problem you mentioned and passed all test cases.
        Hide
        hyunsik Hyunsik Choi added a comment -

        There is no automatic precommit build. I created the issue (TAJO-166) for that. ASF infra only provides a trigger to call a jenkins job, and we should make a script to fetch a latest patch, test the patch, and send a report to the corresponding jira issue.

        Nevertheless, reviewboard is good for reviewing patches because reviewboard allows reviewer to add inline comments on diff.

        Anyway, +1 for this patch. Thanks!

        Show
        hyunsik Hyunsik Choi added a comment - There is no automatic precommit build. I created the issue ( TAJO-166 ) for that. ASF infra only provides a trigger to call a jenkins job, and we should make a script to fetch a latest patch, test the patch, and send a report to the corresponding jira issue. Nevertheless, reviewboard is good for reviewing patches because reviewboard allows reviewer to add inline comments on diff. Anyway, +1 for this patch. Thanks!
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed the patch to master branch.

        Show
        hyunsik Hyunsik Choi added a comment - committed the patch to master branch.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-trunk-postcommit #650 (See https://builds.apache.org/job/Tajo-trunk-postcommit/650/)
        TAJO-460: CTAS statement should support partitioned table. (Min Zhou via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=d39bb99809384c25214f4847c8de06e9ac012e98)

        • tajo-core/tajo-core-backend/src/test/queries/create_partitioned_table_as_select.sql
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionDesc.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/query/QueryContext.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Query.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/GlobalEngine.java
        • CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-trunk-postcommit #650 (See https://builds.apache.org/job/Tajo-trunk-postcommit/650/ ) TAJO-460 : CTAS statement should support partitioned table. (Min Zhou via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=d39bb99809384c25214f4847c8de06e9ac012e98 ) tajo-core/tajo-core-backend/src/test/queries/create_partitioned_table_as_select.sql tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionDesc.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/query/QueryContext.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Query.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/GlobalEngine.java CHANGES.txt

          People

          • Assignee:
            coderplay Min Zhou
            Reporter:
            coderplay Min Zhou
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development