Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: Expression, SQL Parser
    • Labels:
      None

      Description

      Time literal represents a time literal value. Its BNF grammar is as follows:

      <time literal>    ::=   TIME <time string>
      <time string>    ::=   <quote> <unquoted time string> <quote>
      <unquoted time string>    ::=   <time value> [ <time zone interval> ]
      <time zone interval>    ::=   <sign> <hours value> <colon> <minutes value>
      
      1. TAJO-439.patch
        21 kB
        DaeMyung Kang
      2. TAJO-439-2.patch
        17 kB
        DaeMyung Kang

        Activity

        Hide
        charsyam DaeMyung Kang added a comment -

        I implemented Time Literal.
        Please review this.

        Show
        charsyam DaeMyung Kang added a comment - I implemented Time Literal. Please review this.
        Hide
        charsyam DaeMyung Kang added a comment -

        I removed to_char for Time, I might think it doesn't need. and postgresql doesn't support it.

        Show
        charsyam DaeMyung Kang added a comment - I removed to_char for Time, I might think it doesn't need. and postgresql doesn't support it.
        Hide
        jihoonson Jihoon Son added a comment -

        +1, This patch looks good to me.
        I'll commit if there aren't any objections for a while.

        Show
        jihoonson Jihoon Son added a comment - +1, This patch looks good to me. I'll commit if there aren't any objections for a while.
        Hide
        hyunsik Hyunsik Choi added a comment -

        +1

        Ship it.

        Show
        hyunsik Hyunsik Choi added a comment - +1 Ship it.
        Hide
        jihoonson Jihoon Son added a comment -

        I've just committed the patch.
        Thanks for your contribution!

        Show
        jihoonson Jihoon Son added a comment - I've just committed the patch. Thanks for your contribution!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-trunk-postcommit #642 (See https://builds.apache.org/job/Tajo-trunk-postcommit/642/)
        TAJO-439: Time literal support. (DaeMyung Kang via jihoon) (jihoonson: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=3a5a617c6bb1dd10d026ab0735f9031623a66d30)

        • tajo-algebra/src/main/java/org/apache/tajo/algebra/TimeLiteral.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestSQLDateTimeTypes.java
        • tajo-common/src/main/java/org/apache/tajo/datum/DatumFactory.java
        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/AlgebraVisitor.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BaseAlgebraVisitor.java
        • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/TextSerializerDeserializer.java
        • tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4
        • tajo-algebra/src/main/java/org/apache/tajo/algebra/OpType.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java
        • tajo-common/src/main/java/org/apache/tajo/datum/TimeDatum.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-trunk-postcommit #642 (See https://builds.apache.org/job/Tajo-trunk-postcommit/642/ ) TAJO-439 : Time literal support. (DaeMyung Kang via jihoon) (jihoonson: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=3a5a617c6bb1dd10d026ab0735f9031623a66d30 ) tajo-algebra/src/main/java/org/apache/tajo/algebra/TimeLiteral.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestSQLDateTimeTypes.java tajo-common/src/main/java/org/apache/tajo/datum/DatumFactory.java CHANGES.txt tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/AlgebraVisitor.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BaseAlgebraVisitor.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/TextSerializerDeserializer.java tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4 tajo-algebra/src/main/java/org/apache/tajo/algebra/OpType.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java tajo-common/src/main/java/org/apache/tajo/datum/TimeDatum.java

          People

          • Assignee:
            charsyam DaeMyung Kang
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development