Timestamp literal represents timestamp constant. It has the following bnf grammar.
<timestamp literal> ::= TIMESTAMP <timestamp string>
<timestamp string> ::= <quote> <unquoted timestamp string> <quote>
<unquoted timestamp string> ::= <unquoted date string> <space> <unquoted time string>
<unquoted date string> ::= <date value>
<unquoted time string> ::= <time value> [ <time zone interval> ]
<date value> ::= <years value> <minus sign> <months value> <minus sign> <days value>
<time value> ::= <hours value> <colon> <minutes value> <colon> <seconds value>
<time zone interval> ::= <sign> <hours value> <colon> <minutes value>
This patch looks good to me.
FAILURE: Integrated in Tajo-trunk-postcommit #635 (See https://builds.apache.org/job/Tajo-trunk-postcommit/635/)
TAJO-437: Timestamp literal support. (hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=4319ded3aa974dfca35fd2630b97b8f2601507c4)
committed it to master. Thanks!
+1 for the patch.
'mvn clean install -Phcatalog-0.12.0' finished successfully.
I uploaded the updated patch.
It looks great.
But, I'm not sure why it includes 'jquery-min.js'. Could you explain about it?
Thank you for the review. I uploaded the second patch which reflects your comments.
Hyunsik Choi and second, serialize function in tajo-common/src/main/java/org/apache/tajo/json/DatumAdapter.java
I think you should add break statement after
break; <--- need to add this;
break; <-- add break even though it works same.
[Hyunsik Choi first of all, you should add license to files for build.
after adding license.
"mvn clean install" is ok.
This patch mainly does as follows:
In addition, this patch includes some refactorings: