Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-425

RAWFILE_SYNC_INTERVAL has not default value.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      RAWFILE_SYNC_INTERVAL has not default value in the TajoConf class

      RAWFILE_SYNC_INTERVAL("rawfile.sync.interval", null)
      

        Activity

        Hide
        jhkim Jinho Kim added a comment -

        Created a review request against branch master in reviewboard
        https://reviews.apache.org/r/20829/

        Show
        jhkim Jinho Kim added a comment - Created a review request against branch master in reviewboard https://reviews.apache.org/r/20829/
        Hide
        jhkim Jinho Kim added a comment -

        I've rename 'rawfile.sync.interval' to 'rowfile.sync.interval'

        Show
        jhkim Jinho Kim added a comment - I've rename 'rawfile.sync.interval' to 'rowfile.sync.interval'
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12642409/TAJO-425.patch
        against master revision 6cc5006.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 189 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-common tajo-core tajo-storage.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/399//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/399//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/399//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12642409/TAJO-425.patch against master revision 6cc5006. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 189 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-common tajo-core tajo-storage. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/399//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/399//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/399//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        +1

        The patch seems to remove the typo error and add rowfile default value.

        Show
        hyunsik Hyunsik Choi added a comment - +1 The patch seems to remove the typo error and add rowfile default value.
        Hide
        jhkim Jinho Kim added a comment -

        Thank you for the review!

        Show
        jhkim Jinho Kim added a comment - Thank you for the review!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #210 (See https://builds.apache.org/job/Tajo-master-build/210/)
        TAJO-425: RAWFILE_SYNC_INTERVAL has not default value. (jinho) (jinossy: rev 620031113edb3a9dab4132530f936f1244d134ae)

        • tajo-core/src/test/java/org/apache/tajo/storage/TestRowFile.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/RowFile.java
        • tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #210 (See https://builds.apache.org/job/Tajo-master-build/210/ ) TAJO-425 : RAWFILE_SYNC_INTERVAL has not default value. (jinho) (jinossy: rev 620031113edb3a9dab4132530f936f1244d134ae) tajo-core/src/test/java/org/apache/tajo/storage/TestRowFile.java tajo-storage/src/main/java/org/apache/tajo/storage/RowFile.java tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java CHANGES

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            hjkim Hyoungjun Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development