Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: Catalog
    • Labels:
      None

      Description

      I didn't implement functions for partitioned table when I implemented HCatalogStore. Because Tajo couldn't provide partitioned table.

      But for now, it seems that Tajo can provide partitioned table over the short haul. So, HCatalogStore needs to update for partitioned table.

      1. TAJO-405_2.patch
        5 kB
        Jaehwa Jung
      2. TAJO-405.patch
        6 kB
        Jaehwa Jung

        Activity

        Hide
        blrunner Jaehwa Jung added a comment -

        I uploaded the patch.
        Please review this.

        Show
        blrunner Jaehwa Jung added a comment - I uploaded the patch. Please review this.
        Hide
        hyunsik Hyunsik Choi added a comment -

        The patch looks good for me. However, there is lack of unit tests. In order to verify this feature, we have to test manually this feature.

        Show
        hyunsik Hyunsik Choi added a comment - The patch looks good for me. However, there is lack of unit tests. In order to verify this feature, we have to test manually this feature.
        Hide
        blrunner Jaehwa Jung added a comment -

        Thanks you for your review.

        I knew unit tests for HCatalogStore.
        But it needs to handle another issue because there are critical things as follows:

        • set up hive metastore by derby db
        • startup hive metastore server for tests
        • write some hive queries.

        So, I already created a issue at TAJO-327. And I'll start to work on this week

        Show
        blrunner Jaehwa Jung added a comment - Thanks you for your review. I knew unit tests for HCatalogStore. But it needs to handle another issue because there are critical things as follows: set up hive metastore by derby db startup hive metastore server for tests write some hive queries. So, I already created a issue at TAJO-327 . And I'll start to work on this week
        Hide
        blrunner Jaehwa Jung added a comment -

        I updated the patch to remove unnecessary dependency.
        Please review it again.

        Show
        blrunner Jaehwa Jung added a comment - I updated the patch to remove unnecessary dependency. Please review it again.
        Hide
        hyunsik Hyunsik Choi added a comment -

        +1

        Thank you for your contribution!

        Show
        hyunsik Hyunsik Choi added a comment - +1 Thank you for your contribution!
        Hide
        blrunner Jaehwa Jung added a comment -

        Thanks Hyunsik.
        I just committed it to master branch.

        Show
        blrunner Jaehwa Jung added a comment - Thanks Hyunsik. I just committed it to master branch.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-trunk-postcommit #612 (See https://builds.apache.org/job/Tajo-trunk-postcommit/612/)
        TAJO-405: Improve HCatalogStore to support partitioned table. (jaehwa) (jhjung: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=93bae895f539ca1c787150210ce78b2d3233d366)

        • CHANGES.txt
        • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java
        • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/pom.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-trunk-postcommit #612 (See https://builds.apache.org/job/Tajo-trunk-postcommit/612/ ) TAJO-405 : Improve HCatalogStore to support partitioned table. (jaehwa) (jhjung: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=93bae895f539ca1c787150210ce78b2d3233d366 ) CHANGES.txt tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/pom.xml

          People

          • Assignee:
            blrunner Jaehwa Jung
            Reporter:
            blrunner Jaehwa Jung
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development