Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-404

Tajo does not recognize boolean literal

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Labels:
      None

      Description

      See the title. So, the following statement does not work in Tajo.

      select true;
      
      select * from table where true;
      

      This patch adds boolean literal support. In addition, this patch contains some trivial bug fixes about parsing and logical planning.

      1. TAJO-404.patch
        12 kB
        Hyunsik Choi

        Issue Links

          Activity

          Hide
          hyunsik Hyunsik Choi added a comment - - edited

          Such a query 'select true;' can be executed only in testSimpleEval. After TAJO-356, this query will be executed in tsql.

          Show
          hyunsik Hyunsik Choi added a comment - - edited Such a query 'select true;' can be executed only in testSimpleEval. After TAJO-356 , this query will be executed in tsql.
          Hide
          jhkim Jinho Kim added a comment -

          +1
          I've verified unit test.

          Show
          jhkim Jinho Kim added a comment - +1 I've verified unit test.
          Hide
          hyunsik Hyunsik Choi added a comment -

          committed this patch to master.

          Show
          hyunsik Hyunsik Choi added a comment - committed this patch to master.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Tajo-trunk-postcommit #610 (See https://builds.apache.org/job/Tajo-trunk-postcommit/610/)
          TAJO-404: Tajo does not recognize boolean literal. (hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=34a296f9549e988acf03313bb0abcab9d4495e64)

          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/GlobalEngine.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/EvalNodeVisitor2.java
          • CHANGES.txt
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java
          • tajo-algebra/src/main/java/org/apache/tajo/algebra/LiteralValue.java
          • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestSQLExpression.java
          • tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/BasicEvalNodeVisitor.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/CastEval.java
          • tajo-algebra/src/main/java/org/apache/tajo/algebra/BooleanLiteral.java
          • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestInsertQuery.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Tajo-trunk-postcommit #610 (See https://builds.apache.org/job/Tajo-trunk-postcommit/610/ ) TAJO-404 : Tajo does not recognize boolean literal. (hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=34a296f9549e988acf03313bb0abcab9d4495e64 ) tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/EvalNodeVisitor2.java CHANGES.txt tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java tajo-algebra/src/main/java/org/apache/tajo/algebra/LiteralValue.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestSQLExpression.java tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4 tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/BasicEvalNodeVisitor.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/CastEval.java tajo-algebra/src/main/java/org/apache/tajo/algebra/BooleanLiteral.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestInsertQuery.java

            People

            • Assignee:
              hyunsik Hyunsik Choi
              Reporter:
              hyunsik Hyunsik Choi
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development