Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: Function/UDF
    • Labels:
      None

      Description

      abs(-1) ===> 1
      abs(1) ===> 1
      abs(1.0) ===> 1.0
      abs(-1.0) ===> 1.0

      1. TAJO-394_2.patch
        12 kB
        Hyunsik Choi
      2. TAJO-394.patch
        11 kB
        DaeMyung Kang

        Activity

        Hide
        charsyam DaeMyung Kang added a comment -

        Please review this.

        until now, I know parse minus value cauese error.
        (so I couldn't make minus value test.)

        Show
        charsyam DaeMyung Kang added a comment - Please review this. until now, I know parse minus value cauese error. (so I couldn't make minus value test.)
        Hide
        hyunsik Hyunsik Choi added a comment -

        +1

        The patch looks good for me. Since this patch gone stale, I rebased your patch. In addition, I added additional unit tests for minus values to the updated patch.

        Show
        hyunsik Hyunsik Choi added a comment - +1 The patch looks good for me. Since this patch gone stale, I rebased your patch. In addition, I added additional unit tests for minus values to the updated patch.
        Hide
        hyunsik Hyunsik Choi added a comment -

        I just committed the latest patch to the master branch. Thank you for your contribution.

        Show
        hyunsik Hyunsik Choi added a comment - I just committed the latest patch to the master branch. Thank you for your contribution.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-trunk-postcommit #603 (See https://builds.apache.org/job/Tajo-trunk-postcommit/603/)
        TAJO-394: Implement abs function. (DaeMyung Kang via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=2c7f552a54080d98545bc4b3cb162b48eadcf287)

        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMaster.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/math/AbsLong.java
        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/math/AbsDouble.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/math/AbsFloat.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/math/AbsInt.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestMathFunctions.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-trunk-postcommit #603 (See https://builds.apache.org/job/Tajo-trunk-postcommit/603/ ) TAJO-394 : Implement abs function. (DaeMyung Kang via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=2c7f552a54080d98545bc4b3cb162b48eadcf287 ) tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMaster.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/math/AbsLong.java CHANGES.txt tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/math/AbsDouble.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/math/AbsFloat.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/math/AbsInt.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestMathFunctions.java

          People

          • Assignee:
            charsyam DaeMyung Kang
            Reporter:
            charsyam DaeMyung Kang
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development