Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-389

The LazyTuple does not work when number format exception occurs in text deserializer

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.2-incubating
    • Fix Version/s: 0.8.0
    • Component/s: Storage
    • Labels:
      None

      Description

      unexpected case should be NullDatum.

        Activity

        Hide
        jhkim Jinho Kim added a comment -

        I've attached the patch.
        verified 'mvn clean install'.

        Show
        jhkim Jinho Kim added a comment - I've attached the patch. verified 'mvn clean install'.
        Hide
        charsyam DaeMyung Kang added a comment -

        Jinho Kim How about trying trim() when Exception is NumberFormatException only and retry?

        Show
        charsyam DaeMyung Kang added a comment - Jinho Kim How about trying trim() when Exception is NumberFormatException only and retry?
        Hide
        jhkim Jinho Kim added a comment -

        DaeMyung,
        user should be found a invalid data. so we've not needed slowly code.

        Show
        jhkim Jinho Kim added a comment - DaeMyung, user should be found a invalid data. so we've not needed slowly code.
        Hide
        charsyam DaeMyung Kang added a comment -

        Jinho Kim ok. I got it

        Show
        charsyam DaeMyung Kang added a comment - Jinho Kim ok. I got it
        Hide
        jihoonson Jihoon Son added a comment -

        +1.
        This patch looks good to me.

        Show
        jihoonson Jihoon Son added a comment - +1. This patch looks good to me.
        Hide
        jhkim Jinho Kim added a comment -

        Thanks guys for the review.
        I've just committed it.

        Show
        jhkim Jinho Kim added a comment - Thanks guys for the review. I've just committed it.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-trunk-postcommit #591 (See https://builds.apache.org/job/Tajo-trunk-postcommit/591/)
        TAJO-389: The LazyTuple does not work when number format exception occurs in text deserializer. (jinho) (jinossy: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=19b6abc3ec9c6b9f276194937e00ba3fe976e012)

        • CHANGES.txt
        • tajo-core/tajo-core-storage/src/test/java/org/apache/tajo/storage/TestLazyTuple.java
        • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/LazyTuple.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-trunk-postcommit #591 (See https://builds.apache.org/job/Tajo-trunk-postcommit/591/ ) TAJO-389 : The LazyTuple does not work when number format exception occurs in text deserializer. (jinho) (jinossy: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=19b6abc3ec9c6b9f276194937e00ba3fe976e012 ) CHANGES.txt tajo-core/tajo-core-storage/src/test/java/org/apache/tajo/storage/TestLazyTuple.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/LazyTuple.java

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development