Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: Function/UDF
    • Labels:
      None
    1. TAJO-364.patch
      10 kB
      DaeMyung Kang

      Activity

      Hide
      hudson Hudson added a comment -

      SUCCESS: Integrated in Tajo-trunk-postcommit #588 (See https://builds.apache.org/job/Tajo-trunk-postcommit/588/)
      TAJO-364: Implement mod/div function. (DaeMyung Kang via jaehwa) (jhjung: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=45de54bcd915f125c6bf39f3fb62d5b4f0d0780f)

      • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMaster.java
      • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/math/Div.java
      • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/math/Mod.java
      • CHANGES.txt
      • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestMathFunctions.java
      Show
      hudson Hudson added a comment - SUCCESS: Integrated in Tajo-trunk-postcommit #588 (See https://builds.apache.org/job/Tajo-trunk-postcommit/588/ ) TAJO-364 : Implement mod/div function. (DaeMyung Kang via jaehwa) (jhjung: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=45de54bcd915f125c6bf39f3fb62d5b4f0d0780f ) tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMaster.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/math/Div.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/math/Mod.java CHANGES.txt tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestMathFunctions.java
      Hide
      blrunner Jaehwa Jung added a comment -

      +1 for the patch.

      Thanks for your contribution.
      I've just committed now.

      Show
      blrunner Jaehwa Jung added a comment - +1 for the patch. Thanks for your contribution. I've just committed now.
      Hide
      charsyam DaeMyung Kang added a comment -

      Keuntae Park Thank you. good job!!!.

      Show
      charsyam DaeMyung Kang added a comment - Keuntae Park Thank you. good job!!!.
      Hide
      sirpkt Keuntae Park added a comment - - edited

      It looks good to me.
      'mvn clean install' finished successfully.

      However, I think that issue name should be changed to 'Implement mod/div function'

      Show
      sirpkt Keuntae Park added a comment - - edited It looks good to me. 'mvn clean install' finished successfully. However, I think that issue name should be changed to 'Implement mod/div function'
      Hide
      charsyam DaeMyung Kang added a comment -

      Please review this.

      Show
      charsyam DaeMyung Kang added a comment - Please review this.

        People

        • Assignee:
          charsyam DaeMyung Kang
          Reporter:
          charsyam DaeMyung Kang
        • Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development